Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41551

Block drag/drop broken for clean theme on /my

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Step 1: use behat (yay thanks Urs + David)

      • Use the Behat test in /my/tests in the Pull branch. Check the related MoodleSelenium2Driver extension described in https://tracker.moodle.org/browse/MDL-44326
      • If you have questions ask David - he may even be able to test this quickly for you and advise if it fails.

      Step 2: test clean manually.

      • Select the “clean” theme.
      • Open the /my page.
      • Activate page editing (click on “Customize this page”).
      • Drag a block from the right column into the middle “content” region.
      • Drag the block back into the right column.
      • Open the block configuration page with the “Actions” menu.
      • In the “On this page” section select “Content” from the “Region” popup.
      • Save the changes => The block is shown in the “Content” region.
      • Move all blocks from the right column into the “Content” region. => The content region stretches to the right page border.
      • Click on one of the block headers in the “Content” region to activate drag and drop. => the content region is narrowed and the empty right column is shown to accept blocks.
      • Drag the blocks back where they where.

      Step 3: test we haven't broken base.

      • Log in as admin
      • Change to base
        • Turn on allowthemechangeonurl
        • on the url add ?theme=base
      • Browse to a course and turn on editing
      • Drag a block from left to right.
      • Drag a block from right to left.
      • Refresh the page and check all is well still.
      Show
      Step 1: use behat (yay thanks Urs + David) Use the Behat test in /my/tests in the Pull branch. Check the related MoodleSelenium2Driver extension described in https://tracker.moodle.org/browse/MDL-44326 If you have questions ask David - he may even be able to test this quickly for you and advise if it fails. Step 2: test clean manually. Select the “clean” theme. Open the /my page. Activate page editing (click on “Customize this page”). Drag a block from the right column into the middle “content” region. Drag the block back into the right column. Open the block configuration page with the “Actions” menu. In the “On this page” section select “Content” from the “Region” popup. Save the changes => The block is shown in the “Content” region. Move all blocks from the right column into the “Content” region. => The content region stretches to the right page border. Click on one of the block headers in the “Content” region to activate drag and drop. => the content region is narrowed and the empty right column is shown to accept blocks. Drag the blocks back where they where. Step 3: test we haven't broken base. Log in as admin Change to base Turn on allowthemechangeonurl on the url add ?theme=base Browse to a course and turn on editing Drag a block from left to right. Drag a block from right to left. Refresh the page and check all is well still.
    • Difficulty:
      Difficult
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      41551-27
    • Pull Master Diff URL:
    • Story Points:
      100

      Description

      We try to automatically create drop zones for layouts which do not specify them when we are drag/dropping. However, we aren't properly handling these nodes after they are created.

      In particular, the central block in the Clean theme does not have the appropriate wrapperage - an element with id block-region-[region] (block-region-content). We should automagically create this, and indeed we do, but we don't actually return it or attempt to make use of it and thus we get an error: 'Can not call all of undefined'.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                7 Vote for this issue
                Watchers:
                14 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14