Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41568

Import fixed English strings (en_fix) into the main English pack

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.5, 2.5, 2.6
    • Fix Version/s: 2.4.6, 2.5.2
    • Component/s: Language
    • Labels:

      Description

      As a part of regular release process, en_fix pack from AMOS should be merged into the core English language

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              mudrd8mz David Mudrák added a comment -

              Thanks Helen Foster, submitting for integration now.

              Show
              mudrd8mz David Mudrák added a comment - Thanks Helen Foster , submitting for integration now.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Integrated (24, 25 and master), thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (24, 25 and master), thanks!
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              nobody tested and passed this, as suggested, thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - nobody tested and passed this, as suggested, thanks!
              Hide
              tsala Helen Foster added a comment -

              Yes! An issue which I voted for has been integrated

              Show
              tsala Helen Foster added a comment - Yes! An issue which I voted for has been integrated
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Crap, I didn't look to votes. Else… lol.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Crap, I didn't look to votes. Else… lol.
              Hide
              dmonllao David Monllaó added a comment -

              Failing, this is breaking behat tests. Pull branches with fixes on top of current integration.

              25

              • git pull git://github.com/dmonllao/moodle.git MDL-41568_25-fix_behat

              master

              • git pull git://github.com/dmonllao/moodle.git MDL-41568_master-fix_behat
              Show
              dmonllao David Monllaó added a comment - Failing, this is breaking behat tests. Pull branches with fixes on top of current integration. 25 git pull git://github.com/dmonllao/moodle.git MDL-41568 _25-fix_behat master git pull git://github.com/dmonllao/moodle.git MDL-41568 _master-fix_behat
              Hide
              poltawski Dan Poltawski added a comment -

              Removing the integration date from this, which is making it show up in some searches prematurely.

              Show
              poltawski Dan Poltawski added a comment - Removing the integration date from this, which is making it show up in some searches prematurely.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Super, thanks! About the integration date… it's a problem we have with cloned issues..

              Although seems it has solution(s):

              https://answers.atlassian.com/questions/29053/clearing-fields-on-cloned-issues-during-cloning-action

              I think we can use the post-action to clear those 2 integration fields. They aren't ever set on manual creation.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Super, thanks! About the integration date… it's a problem we have with cloned issues.. Although seems it has solution(s): https://answers.atlassian.com/questions/29053/clearing-fields-on-cloned-issues-during-cloning-action I think we can use the post-action to clear those 2 integration fields. They aren't ever set on manual creation.
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated the fixes to behat.

              Show
              poltawski Dan Poltawski added a comment - Integrated the fixes to behat.
              Hide
              poltawski Dan Poltawski added a comment -

              behat says 'yay'

              Show
              poltawski Dan Poltawski added a comment - behat says 'yay'
              Hide
              mudrd8mz David Mudrák added a comment -

              Note that I have to manually clear all Git related fields. It would be nice to get rid of them on cloning, too.

              Show
              mudrd8mz David Mudrák added a comment - Note that I have to manually clear all Git related fields. It would be nice to get rid of them on cloning, too.
              Hide
              poltawski Dan Poltawski added a comment -

              Congratulations! This change has been integrated upstream and is now available from our git and download mirrors. To celebrate, here is a joke:

              A SQL query goes into a bar, walks up to two tables and asks, "Can I join you?"

              Show
              poltawski Dan Poltawski added a comment - Congratulations! This change has been integrated upstream and is now available from our git and download mirrors. To celebrate, here is a joke: A SQL query goes into a bar, walks up to two tables and asks, "Can I join you?"

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Sep/13