Moodle
  1. Moodle
  2. MDL-41600

qformat_blackboard_six tests fails if ddmatch installed

    Details

    • Rank:
      52709

      Description

      If you have qtype_ddmatch installed, qformat_blackboard_six will generate ddmatch questions for QUESTION_MATCHING in the blackboard xml instead of qtype_match ones.

      As explained in the process_matching code of the format, this is because match actually loses data, ddmatch retains it all correctly.

      The fix is to use the same "is ddmatch installed" check in the test, and to set the expected qtype and subanswers to the relevant output.

        Activity

        Hide
        Frédéric Massart added a comment -

        Hi Adam,

        thanks for reporting this and providing a patch. Your patch looks really good. Could you please just use the constants instead of raw values for the keys format?

        Cheers,
        Fred

        Show
        Frédéric Massart added a comment - Hi Adam, thanks for reporting this and providing a patch. Your patch looks really good. Could you please just use the constants instead of raw values for the keys format? Cheers, Fred
        Hide
        Adam Olley added a comment -

        Hi Fred,

        You'd think I wouldn't forget that with the constants used /right above/ where I used the raw number instead.

        Fix'd on all 3 branches

        Show
        Adam Olley added a comment - Hi Fred, You'd think I wouldn't forget that with the constants used /right above/ where I used the raw number instead. Fix'd on all 3 branches
        Hide
        Frédéric Massart added a comment -

        Awesome, thanks! Pushing for integration now.

        Show
        Frédéric Massart added a comment - Awesome, thanks! Pushing for integration now.
        Hide
        Tim Hunt added a comment -

        Adam, the first line of your commit comment is too long. http://docs.moodle.org/dev/Commit_cheat_sheet. Would be good if you could amend that before this is integrated.

        Otherwise, +1 from me too.

        Show
        Tim Hunt added a comment - Adam, the first line of your commit comment is too long. http://docs.moodle.org/dev/Commit_cheat_sheet . Would be good if you could amend that before this is integrated. Otherwise, +1 from me too.
        Hide
        Adam Olley added a comment -

        Done, also rebased commits onto the latest state of the branches from moodle's github.

        Show
        Adam Olley added a comment - Done, also rebased commits onto the latest state of the branches from moodle's github.
        Hide
        Sam Hemelryk added a comment -

        Thanks Adam this has been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks Adam this has been integrated now.
        Hide
        Jason Fowler added a comment -

        All good, thanks Adam

        Show
        Jason Fowler added a comment - All good, thanks Adam
        Hide
        Damyon Wiese added a comment -

        This issue along with 77 of it's friends has been sent upstream and released to the world.

        Thankyou for your contribution.

        Show
        Damyon Wiese added a comment - This issue along with 77 of it's friends has been sent upstream and released to the world. Thankyou for your contribution.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: