Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41630

Oauth helper should not exit on failed request

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.8, 2.4.5, 2.5.1
    • Fix Version/s: 2.4.7, 2.5.3
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. Download the Evernote repository
      2. Enter anything for API key and secret
      3. Go to your private files and navigate the Evernote repo
      4. Make sure you see a proper error message rather than a JSON error
      5. Enter proper credentials
      6. Make sure it works nicely
      Show
      Download the Evernote repository Enter anything for API key and secret Go to your private files and navigate the Evernote repo Make sure you see a proper error message rather than a JSON error Enter proper credentials Make sure it works nicely
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-41630-master

      Description

      In oauthlib.php oauth_helper::request_token()

              if (empty($result['oauth_token'])) {
                  // failed
                  var_dump($result);
                  exit;
              }
      

      This does not allow for anyone to nicely handle the error.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                fred Frédéric Massart
                Reporter:
                fred Frédéric Massart
                Peer reviewer:
                Dan Poltawski
                Integrator:
                Sam Hemelryk
                Tester:
                Andrew Davis
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Nov/13