[MDL-41630] Oauth helper should not exit on failed request - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Download the Evernote repository

Enter anything for API key and secret

Go to your private files and navigate the Evernote repo

Make sure you see a proper error message rather than a JSON error

Enter proper credentials

Make sure it works nicely
Show
Download the Evernote repository Enter anything for API key and secret Go to your private files and navigate the Evernote repo Make sure you see a proper error message rather than a JSON error Enter proper credentials Make sure it works nicely
Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Master Branch:
~~MDL-41630~~-master
Pull Master Diff URL:
https://github.com/FMCorz/moodle/compare/ee78814...MDL-41630-master

In oauthlib.php oauth_helper::request_token()

        if (empty($result['oauth_token'])) {

            // failed

            var_dump($result);

            exit;

This does not allow for anyone to nicely handle the error.

Discovered while testing

MDL-41743 can we trim trailing spaces from admin fields?

Participants:: Andrew Davis, Damyon Wiese, Dan Poltawski, Frédéric Massart, Sam Hemelryk

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón