Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41635

Livelog string in course report settings is missing.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.10, 2.4.7, 2.5.1, 2.6
    • Fix Version/s: 2.4.8, 2.5.4, 2.6.1
    • Component/s: Reports
    • Labels:

      Description

      String for livelog report plugin in course reports section is missing.

      Attaching screenshot and fix.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              bencosk Filip Benčo added a comment -

              Screenshot

              Show
              bencosk Filip Benčo added a comment - Screenshot
              Hide
              poltawski Dan Poltawski added a comment -

              Requesting peer review for Filip

              Show
              poltawski Dan Poltawski added a comment - Requesting peer review for Filip
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Hi Filip,

              Thanks for this patch.

              [Y] Syntax
              [Y] Whitespace
              [Y] Output
              [Y] Language
              [-] Databases
              [N] Testing (instructions and automated tests)
              [Y] Security
              [-] Documentation
              [N] Git
              [Y] Sanity check

              Testing

              If you could write some testing instructions to guide the person testing to how to confirm things are working as expected that'd be great thanks.

              Git

              We typically format our commit messages as:

              MDL-XXXXX component: Short description
               
              Optional longer description
              

              If you could update the git commit accordingly that will help others trying to trace the history of a change in the future.

              Otherwise this is good to go for integration.

              Show
              dobedobedoh Andrew Nicols added a comment - Hi Filip, Thanks for this patch. [Y] Syntax [Y] Whitespace [Y] Output [Y] Language [-] Databases [N] Testing (instructions and automated tests) [Y] Security [-] Documentation [N] Git [Y] Sanity check Testing If you could write some testing instructions to guide the person testing to how to confirm things are working as expected that'd be great thanks. Git We typically format our commit messages as: MDL-XXXXX component: Short description   Optional longer description If you could update the git commit accordingly that will help others trying to trace the history of a change in the future. Otherwise this is good to go for integration.
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              I just observed this after installing essential theme, and as it is loss of functionality, I have created branches on behalf of Filip and added testing instructions.

              Show
              rajeshtaneja Rajesh Taneja added a comment - I just observed this after installing essential theme, and as it is loss of functionality, I have created branches on behalf of Filip and added testing instructions.
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Request another round of review, before pushing it for integration.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Request another round of review, before pushing it for integration.
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Assigning this to self, as can't assign to Filip.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Assigning this to self, as can't assign to Filip.
              Hide
              poltawski Dan Poltawski added a comment -

              Hi Raj,

              You seem to have fixed this in a different way to the patch in Filips original branches (which gets rid of the whole popup action bit)?

              Show
              poltawski Dan Poltawski added a comment - Hi Raj, You seem to have fixed this in a different way to the patch in Filips original branches (which gets rid of the whole popup action bit)?
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Yes Dan,

              This is similar behaviour as Site administration -> Reports -> Live logs

              Live logs are shown in new window on Site administration -> Reports -> Live logs, so tried to keep it similar.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Yes Dan, This is similar behaviour as Site administration -> Reports -> Live logs Live logs are shown in new window on Site administration -> Reports -> Live logs, so tried to keep it similar.
              Hide
              poltawski Dan Poltawski added a comment -

              Alright, integrated, thanks Raj

              Show
              poltawski Dan Poltawski added a comment - Alright, integrated, thanks Raj
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Failing this sorry Raj, no Live logs link in 24

              Show
              samhemelryk Sam Hemelryk added a comment - Failing this sorry Raj, no Live logs link in 24
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Thanks Sam,

              I haven't gone deep in why this was not working on 24, but adding string to action link works and displays live logs link under Current course ->

              {COURSE}

              -> Reports -> Live logs

              Have added another commit on top for 24 only.

              Dan: Can you please look at last commit for 24.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Thanks Sam, I haven't gone deep in why this was not working on 24, but adding string to action link works and displays live logs link under Current course -> {COURSE} -> Reports -> Live logs Have added another commit on top for 24 only. Dan: Can you please look at last commit for 24.
              Hide
              poltawski Dan Poltawski added a comment -

              Alright, thanks Raj - back to testing.

              Show
              poltawski Dan Poltawski added a comment - Alright, thanks Raj - back to testing.
              Hide
              poltawski Dan Poltawski added a comment -
              Show
              poltawski Dan Poltawski added a comment - Ping Sam Hemelryk
              Hide
              poltawski Dan Poltawski added a comment -

              Sam asked me to pass this on his behalf

              Show
              poltawski Dan Poltawski added a comment - Sam asked me to pass this on his behalf
              Hide
              poltawski Dan Poltawski added a comment -

              Congratulations, this change has now made its way upstream. Thanks for your contribution!

              “ Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. ” - Rick Osborne

              Show
              poltawski Dan Poltawski added a comment - Congratulations, this change has now made its way upstream. Thanks for your contribution! “ Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live. ” - Rick Osborne

                People

                • Votes:
                  6 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/Jan/14