Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41646

Wiki has odd wiki_info CSS to underline some error messages

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Try to edit a wiki,
      On preview a preview warning is generated check class of this dialog, and ensure styles are fine.
      and grep to make sure there are no any other mentions of wiki_info class.

      Show
      Try to edit a wiki, On preview a preview warning is generated check class of this dialog, and ensure styles are fine. and grep to make sure there are no any other mentions of wiki_info class.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      mod/wiki/pagelib.php
      1050: echo $OUTPUT->notification(get_string('previewwarning', 'wiki'), 'notifyproblem wiki_info');

      The above line adds the class "wiki_info" to the error message. This makes the text inside darkred, and underlines it. The text inside a notifyproblem is already red, underlines generally indicate hyperlinks and there seems no reason to have this one error message in the whole of Moodle look slightly different so I suggest removing the "wiki_info" class. And since the accompanying CSS only seems to be used for this purpose, to remove those lines too (mod/wiki/styles.css lines 51 - 54)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              apsdehal Amanpreet Singh
              Reporter:
              bawjaws David Scotson
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Damyon Wiese
              Tester:
              Sam Hemelryk
              Participants:
              Component watchers:
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14