Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41646

Wiki has odd wiki_info CSS to underline some error messages

    Details

    • Testing Instructions:
      Hide

      Try to edit a wiki,
      On preview a preview warning is generated check class of this dialog, and ensure styles are fine.
      and grep to make sure there are no any other mentions of wiki_info class.

      Show
      Try to edit a wiki, On preview a preview warning is generated check class of this dialog, and ensure styles are fine. and grep to make sure there are no any other mentions of wiki_info class.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      mod/wiki/pagelib.php
      1050: echo $OUTPUT->notification(get_string('previewwarning', 'wiki'), 'notifyproblem wiki_info');

      The above line adds the class "wiki_info" to the error message. This makes the text inside darkred, and underlines it. The text inside a notifyproblem is already red, underlines generally indicate hyperlinks and there seems no reason to have this one error message in the whole of Moodle look slightly different so I suggest removing the "wiki_info" class. And since the accompanying CSS only seems to be used for this purpose, to remove those lines too (mod/wiki/styles.css lines 51 - 54)

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              salvetore Michael de Raadt added a comment -

              Thanks, David.

              Show
              salvetore Michael de Raadt added a comment - Thanks, David.
              Show
              apsdehal Amanpreet Singh added a comment - Diff at https://github.com/apsdehal/moodle/tree/MDL-41646
              Hide
              bawjaws David Scotson added a comment -
              Show
              bawjaws David Scotson added a comment - Direct link for diff: https://github.com/apsdehal/moodle/compare/MDL-41644
              Hide
              cibot CiBoT added a comment -

              Results for MDL-41646

              • Error: the repository field is empty. Nothing was checked.
              Show
              cibot CiBoT added a comment - Results for MDL-41646 Error: the repository field is empty. Nothing was checked.
              Hide
              fred Frédéric Massart added a comment -

              Thanks for submitting this patch Amanpreet.

              Before we can push that for integration, could you just expand a bit your testing instructions to guide the user to the page where the error is displayed, and ensure that the styles are good on the affected themes?

              Cheers,
              Fred

              Show
              fred Frédéric Massart added a comment - Thanks for submitting this patch Amanpreet. Before we can push that for integration, could you just expand a bit your testing instructions to guide the user to the page where the error is displayed, and ensure that the styles are good on the affected themes? Cheers, Fred
              Hide
              cibot CiBoT added a comment -
              Show
              cibot CiBoT added a comment - Results for MDL-41646 Remote repository: git://github.com/apsdehal/moodle.git Remote branch MDL-41646 _25 to be integrated into upstream MOODLE_25_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1292 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1292/artifact/work/smurf.html Remote branch MDL-41646 _26 to be integrated into upstream MOODLE_26_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1293 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1293/artifact/work/smurf.html Remote branch MDL-41646 to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1294 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1294/artifact/work/smurf.html
              Hide
              fred Frédéric Massart added a comment -

              Thanks. Pushing for integration.

              Show
              fred Frédéric Massart added a comment - Thanks. Pushing for integration.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              cibot CiBoT added a comment -

              Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

              Show
              cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
              Hide
              damyon Damyon Wiese added a comment -

              Thanks Amanpreet,

              This change makes sense, integrated to 25, 26 and master.

              Show
              damyon Damyon Wiese added a comment - Thanks Amanpreet, This change makes sense, integrated to 25, 26 and master.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Tested and passed thanks guys

              Show
              samhemelryk Sam Hemelryk added a comment - Tested and passed thanks guys
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              I claim to be a simple individual
              liable to err like any other fellow mortal.
              I own, however, that I have humility enough
              to confess my errors and to retrace my steps.

              Mahatma Gandhi

              Your awesome code has met upstream, closing, thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - I claim to be a simple individual liable to err like any other fellow mortal. I own, however, that I have humility enough to confess my errors and to retrace my steps. Mahatma Gandhi Your awesome code has met upstream, closing, thanks!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    10/Mar/14