Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41646

Wiki has odd wiki_info CSS to underline some error messages

    XMLWordPrintable

Details

    • MOODLE_25_STABLE, MOODLE_26_STABLE
    • MOODLE_25_STABLE, MOODLE_26_STABLE
    • Hide

      Try to edit a wiki,
      On preview a preview warning is generated check class of this dialog, and ensure styles are fine.
      and grep to make sure there are no any other mentions of wiki_info class.

      Show
      Try to edit a wiki, On preview a preview warning is generated check class of this dialog, and ensure styles are fine. and grep to make sure there are no any other mentions of wiki_info class.

    Description

      mod/wiki/pagelib.php
      1050: echo $OUTPUT->notification(get_string('previewwarning', 'wiki'), 'notifyproblem wiki_info');

      The above line adds the class "wiki_info" to the error message. This makes the text inside darkred, and underlines it. The text inside a notifyproblem is already red, underlines generally indicate hyperlinks and there seems no reason to have this one error message in the whole of Moodle look slightly different so I suggest removing the "wiki_info" class. And since the accompanying CSS only seems to be used for this purpose, to remove those lines too (mod/wiki/styles.css lines 51 - 54)

      Attachments

        Issue Links

          Activity

            People

              apsdehal Amanpreet Singh
              bawjaws David Scotson
              Frédéric Massart Frédéric Massart
              Damyon Wiese Damyon Wiese
              Sam Hemelryk Sam Hemelryk
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/Mar/14