Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41647

Web services uses non-existant CSS class "success" instead of "notifysuccess"

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      • In webservices change some service user settings(My home ► Site administration ► Plugins ► Web services ► External services
      • Add a new custom service and save changes
      • Click on 'Authorised users'
      • Add some users
      • Underneath the user selection boxes, choose a user
      • Press ave on the resulting page
      • The confirmation should be shown correctly with the 'notifysuccess' style.
      Show
      In webservices change some service user settings(My home ► Site administration ► Plugins ► Web services ► External services Add a new custom service and save changes Click on 'Authorised users' Add some users Underneath the user selection boxes, choose a user Press ave on the resulting page The confirmation should be shown correctly with the 'notifysuccess' style.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull Master Branch:

      Description

      admin/webservice/service_user_settings.php, line 71

      $notification = $OUTPUT->notification(get_string('usersettingssaved', 'webservice'), 'success');
      

      In the above line, I assume the class 'success' was intended to be 'notifysuccess' as used in all similar notifications. There's no CSS that matches 'sucess' so it's not actually doing anything.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              apsdehal Amanpreet Singh
              Reporter:
              bawjaws David Scotson
              Peer reviewer:
              Ankit Agarwal Ankit Agarwal
              Integrator:
              Marina Glancy Marina Glancy
              Tester:
              Andrew Lyons Andrew Lyons
              Participants:
              Component watchers:
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14