Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41647

Web services uses non-existant CSS class "success" instead of "notifysuccess"

    Details

    • Testing Instructions:
      Hide
      • In webservices change some service user settings(My home ► Site administration ► Plugins ► Web services ► External services
      • Add a new custom service and save changes
      • Click on 'Authorised users'
      • Add some users
      • Underneath the user selection boxes, choose a user
      • Press ave on the resulting page
      • The confirmation should be shown correctly with the 'notifysuccess' style.
      Show
      In webservices change some service user settings(My home ► Site administration ► Plugins ► Web services ► External services Add a new custom service and save changes Click on 'Authorised users' Add some users Underneath the user selection boxes, choose a user Press ave on the resulting page The confirmation should be shown correctly with the 'notifysuccess' style.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull Master Branch:

      Description

      admin/webservice/service_user_settings.php, line 71

      $notification = $OUTPUT->notification(get_string('usersettingssaved', 'webservice'), 'success');
      

      In the above line, I assume the class 'success' was intended to be 'notifysuccess' as used in all similar notifications. There's no CSS that matches 'sucess' so it's not actually doing anything.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              salvetore Michael de Raadt added a comment -

              Thanks, David.

              Show
              salvetore Michael de Raadt added a comment - Thanks, David.
              Show
              apsdehal Amanpreet Singh added a comment - Diff at https://github.com/apsdehal/moodle/tree/MDL-41647
              Hide
              cibot CiBoT added a comment -

              Results for MDL-41647

              • Error: the repository field is empty. Nothing was checked.
              Show
              cibot CiBoT added a comment - Results for MDL-41647 Error: the repository field is empty. Nothing was checked.
              Hide
              ankit_frenz Ankit Agarwal added a comment -

              Hi Amanpreet,

              Thanks for the patch. It looks perfect, pushing for integration.

              [y] Syntax
              [y] Whitespace
              [y] Output
              [na] Language
              [na] Databases
              [y] Testing (instructions and automated tests)
              [na] Security
              [na] Documentation
              [y] Git (pull repo was missing, I have updated it.)
              [na] Third party code
              [y] Sanity check

              Cheers

              Show
              ankit_frenz Ankit Agarwal added a comment - Hi Amanpreet, Thanks for the patch. It looks perfect, pushing for integration. [y] Syntax [y] Whitespace [y] Output [na] Language [na] Databases [y] Testing (instructions and automated tests) [na] Security [na] Documentation [y] Git (pull repo was missing, I have updated it.) [na] Third party code [y] Sanity check Cheers
              Show
              cibot CiBoT added a comment - Results for MDL-41647 Remote repository: https://github.com/apsdehal/moodle.git Remote branch MDL-41647 _25 to be integrated into upstream MOODLE_25_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1037 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1037/artifact/work/smurf.html Remote branch MDL-41647 _26 to be integrated into upstream MOODLE_26_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1038 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1038/artifact/work/smurf.html Remote branch MDL-41647 to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1039 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1039/artifact/work/smurf.html
              Hide
              cibot CiBoT added a comment -

              Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

              Show
              cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
              Hide
              marina Marina Glancy added a comment -

              Thanks guys, integrated in 2.5, 2.6 and master

              PS took me some time to find the necessary screen while pre-testing...

              Show
              marina Marina Glancy added a comment - Thanks guys, integrated in 2.5, 2.6 and master PS took me some time to find the necessary screen while pre-testing...
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Thanks Amanpreet,

              This works as expected once I worked out which screen the testing instructions referred to.

              Show
              dobedobedoh Andrew Nicols added a comment - Thanks Amanpreet, This works as expected once I worked out which screen the testing instructions referred to.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              This weeks weekly release is now available and includes your code.
              A big pat on the back to you again for once more being a cog in the Moodle machine.

              Best wishes, the Moodle integration team.

              Show
              samhemelryk Sam Hemelryk added a comment - This weeks weekly release is now available and includes your code. A big pat on the back to you again for once more being a cog in the Moodle machine. Best wishes, the Moodle integration team.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    10/Mar/14