Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41648

Assignment and Grade notifications use 'error' class rather than 'notifyproblem'

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Pre-requisite : 1. Admin access. 2. An ongoing course.

      Firstly , checking for rubric :
      1. Click Turn editing on at the top right of your course homepage.
      2. In the Section of your course where you want the Assignment activity, click + Add an activity or resource then select Assignment and click Add. The Adding a new Assignment page will open.
      3. Configure the settings for your assignment, and from the Grading method drop-down menu, select Rubric.
      4. Click "Save and display" and the Advanced grading page will appear.
      5. Click Define new grading form from scratch.
      6. In the form , fill in some wrong details.
      7. Make sure that all the necessary validation notifications work properly.

      Now, to check for Marking guide , repeat the above steps but select "Marking guide" instead of "Rubric" .

      Show
      Pre-requisite : 1. Admin access. 2. An ongoing course. Firstly , checking for rubric : 1. Click Turn editing on at the top right of your course homepage. 2. In the Section of your course where you want the Assignment activity, click + Add an activity or resource then select Assignment and click Add. The Adding a new Assignment page will open. 3. Configure the settings for your assignment, and from the Grading method drop-down menu, select Rubric. 4. Click "Save and display" and the Advanced grading page will appear. 5. Click Define new grading form from scratch. 6. In the form , fill in some wrong details. 7. Make sure that all the necessary validation notifications work properly. Now, to check for Marking guide , repeat the above steps but select "Marking guide" instead of "Rubric" .
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-41648

      Description

      grade/grading/form/guide/guideeditor.php
      129: $html .= $renderer->notification($this->validationerrors, 'error');

      grade/grading/form/rubric/rubriceditor.php
      133: $html .= $renderer->notification($this->validationerrors, 'error');

      mod/assignment/lib.php
      1160: echo $OUTPUT->notification($advancedgradingwarning, 'error');

      The three lines above use 'error' as a class on a notification.

      This will (coincidentally?) turn the text of the notification red in Standard theme, but not in Base theme or other themes that derive from it.

      Usually 'notifyproblem' is used for this purpose instead and will also turn the text red in Base theme and those that derive from it, including Standard.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              devang2511 Devang Gaur
              Reporter:
              bawjaws David Scotson
              Peer reviewer:
              Jun Pataleta
              Integrator:
              David Monllaó
              Tester:
              cameron1729
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Mar/16