Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.5.1, 2.5.2
-
Fix Version/s: 2.5.3
-
Component/s: Course
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_25_STABLE
-
Fixed Branches:MOODLE_25_STABLE
-
Pull from Repository:
-
Pull Master Branch:wip-
MDL-41676-master -
Pull Master Diff URL:
Description
Logged in as teacher, Edit mode, create a label.
Make that label hidden. Its text is dimmed.
Quit Edit mode.
Now the label is no longer dimmed!
Diagnostic:
See moodle/course/renderer.php, function course_section_cm_text(cm_info $mod, $displayoptions = array())
especially:
if ($this->page->user_is_editing()) {
|
// In editing mode, when an item is conditionally hidden from some users
|
// we show it as greyed out.
|
$conditionalhidden = $this->is_cm_conditionally_hidden($mod);
|
$dim = !$mod->visible || $conditionalhidden;
|
} else {
|
// When not in editing mode, we only show item as hidden if it is
|
// actually not available to the user
|
$conditionalhidden = false;
|
$dim = !$mod->uservisible;
|
}
|
