XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.7
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide
      1. Run phpunit tests - no debuting should be experienced
      2. Run behat tests - no debuting should be experienced
      3. Enable developer debugging and test with various activities in a course:
      • Recent activity block - with events present for adding resource and updating resource
      • Main menu block
      • Social activities block
      • Drag and drop upload of resources
      • Single activity course format
      • Navigation
      • Folder/forum/resource
      • core_course_get_course_contents web service
      Show
      Run phpunit tests - no debuting should be experienced Run behat tests - no debuting should be experienced Enable developer debugging and test with various activities in a course: Recent activity block - with events present for adding resource and updating resource Main menu block Social activities block Drag and drop upload of resources Single activity course format Navigation Folder/forum/resource core_course_get_course_contents web service
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-41690-master
    • Story Points:
      3
    • Sprint:
      BACKEND Sprint 8

      Description

      The following methods of class cm_info were public before Moodle 2.6. They are changed to private in Moodle 2.6 but still can be accessed publicly via magic __call() method.

      They have to display deprecation message if accessed from outside of the class in 2.7 and in 2.8 the array $standardmethods and function __call() need to be completely removed.

      Functions are still used as getter methods for the corresponding properties

          /**
           * List of methods with no arguments that were public prior to Moodle 2.6.
           *
           * They can still be accessed publicly via magic __call() function with no warnings
           * but are not listed in the class methods list.
           * For the consistency of the code it is better to use corresponding properties.
           *
           * These methods be deprecated completely in later versions.
           *
           * @var array $standardmethods
           */
          private static $standardmethods = array(
              // Following methods are not recommended to use because there have associated read-only properties.
              'get_url',
              'get_content',
              'get_extra_classes',
              'get_on_click',
              'get_custom_data',
              'get_after_link',
              'get_after_edit_icons',
              // Method obtain_dynamic_data() should not be called from outside of this class but it was public before Moodle 2.6.
              'obtain_dynamic_data',
          );
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              Damyon Wiese
              Tester:
              David Monllaó
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14