Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41715

Increase the length of Institution and Department fields in user table

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Database SQL/XMLDB
    • Labels:
    • Testing Instructions:
      Hide

      Add and edit users with the fields "Department", "Institution" and "Address" over 200 chars (new limit is 255). Make sure the fields are updated.

      1. Add/edit user using the usual form
      2. Add/edit user(s) using the "Upload users" tool (both in xml and form)
      3. Add/edit user using webservices
      Show
      Add and edit users with the fields "Department", "Institution" and "Address" over 200 chars (new limit is 255). Make sure the fields are updated. Add/edit user using the usual form Add/edit user(s) using the "Upload users" tool (both in xml and form) Add/edit user using webservices
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      wip-MDL-41715-master

      Description

      The length of institution field in user table is 40,
      the length of department field is 30.

      This could be not enough for many institutions and their departments.

      Please, change the length of this fields to a large value, 100 or more.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            marina Marina Glancy added a comment -

            Requesting peer review

            Show
            marina Marina Glancy added a comment - Requesting peer review
            Hide
            phalacee Jason Fowler added a comment -

            I can just see the developer when they set these values to begin with "70 characters should be enough for any address!"

            Anyway, patch looks fine Marina, pushed for integration.

            – Probably needs testing instructions...

            Show
            phalacee Jason Fowler added a comment - I can just see the developer when they set these values to begin with "70 characters should be enough for any address!" Anyway, patch looks fine Marina, pushed for integration. – Probably needs testing instructions...
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Marina - this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Marina - this has been integrated now.
            Hide
            dmonllao David Monllaó added a comment -

            When I upload a CSV file including the address, the specified value is copied to user's institution, department and address fields. Not happening in production master.

            Show
            dmonllao David Monllaó added a comment - When I upload a CSV file including the address, the specified value is copied to user's institution, department and address fields. Not happening in production master.
            Hide
            marina Marina Glancy added a comment - - edited

            David, I can not reproduce it. Can you please attach the CSV file that you are using and screenshot of upload user form?

            Show
            marina Marina Glancy added a comment - - edited David, I can not reproduce it. Can you please attach the CSV file that you are using and screenshot of upload user form?
            Hide
            dmonllao David Monllaó added a comment -

            Sorry marina, 1 sec, I see some optional fields filled when selecting the upload options once the csv. is submitted, probably is my mistake and the problem (if there is a problem) is not part of this issue

            Show
            dmonllao David Monllaó added a comment - Sorry marina, 1 sec, I see some optional fields filled when selecting the upload options once the csv. is submitted, probably is my mistake and the problem (if there is a problem) is not part of this issue
            Hide
            dmonllao David Monllaó added a comment -

            It passes, I had a default value. I've run #3 without specifying an address as it is not part of the supported attributes

            Show
            dmonllao David Monllaó added a comment - It passes, I had a default value. I've run #3 without specifying an address as it is not part of the supported attributes
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Yarrr me 'arties, good job done. Yer code 'as landed and the weeklies ave been released with your contributions in tow.
            The brethren thank ya for yer 'ard work and if there'd been treasure to ave ya would ave got yer cut.

            Thanks for the effort everyone, another successful weekly release has been rolled.
            Please keep in mind code freeze is just around the corner now, get your new features and improvements in ASAP.

            Many thanks
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Yarrr me 'arties, good job done. Yer code 'as landed and the weeklies ave been released with your contributions in tow. The brethren thank ya for yer 'ard work and if there'd been treasure to ave ya would ave got yer cut. Thanks for the effort everyone, another successful weekly release has been rolled. Please keep in mind code freeze is just around the corner now, get your new features and improvements in ASAP. Many thanks Sam

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/13