Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41772

Comments don't restore in Database Activity

    Details

    • Testing Instructions:
      Hide
      1. Create a database activity.
        • In the [Entries] section set "Allow comments on entries" to Yes.
      2. Add some fields.
      3. Save the templates.
      4. Add a couple of entries.
      5. Go to the single view of an entry and add some comments.
      6. Back up the database activity. [Administration ► Database activity administration ► Backup]
      7. Restore the database activity into another course.
      8. Open the new database activity and check that the comments have been restored.
      Show
      Create a database activity. In the [Entries] section set "Allow comments on entries" to Yes. Add some fields. Save the templates. Add a couple of entries. Go to the single view of an entry and add some comments. Back up the database activity. [Administration ► Database activity administration ► Backup] Restore the database activity into another course. Open the new database activity and check that the comments have been restored.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-41772-master

      Description

      Database activity with comments. Backup course with all user info, files etc. Restore as new course on same Moodle instance OR new Moodle instance.

      All fields, records, presets, templates restore perfectly, and no issues with other elements of restored course.

      Backup MBZ shows comments present in comments.xml. Comments don't appear in restored Database activity.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            poltawski Dan Poltawski added a comment -

            Looks good to me, thanks Adrian

            Show
            poltawski Dan Poltawski added a comment - Looks good to me, thanks Adrian
            Hide
            marina Marina Glancy added a comment -

            Something I noticed while testing:
            Duplicating the database activity does not duplicate the entries. For example try duplicating "Image gallery" in "Moodle Features Demo" on qa.moodle.net. Could not find an issue for it

            Show
            marina Marina Glancy added a comment - Something I noticed while testing: Duplicating the database activity does not duplicate the entries. For example try duplicating "Image gallery" in "Moodle Features Demo" on qa.moodle.net. Could not find an issue for it
            Hide
            marina Marina Glancy added a comment -

            Thanks Adrian, integrated in 2.4, 2.5 and master

            Show
            marina Marina Glancy added a comment - Thanks Adrian, integrated in 2.4, 2.5 and master
            Hide
            stencil Ross Manson added a comment -

            Not duplicating the entries would seem logical behaviour, Marina. Fields and templates duplicate nicely.
            Duplicating a forum doesn't duplicate the contents - similar logic to duplicating a database activity.

            Show
            stencil Ross Manson added a comment - Not duplicating the entries would seem logical behaviour, Marina. Fields and templates duplicate nicely. Duplicating a forum doesn't duplicate the contents - similar logic to duplicating a database activity.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This is working as expected.

            Tested for 2.4, 2.5 and master.

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - This is working as expected. Tested for 2.4, 2.5 and master. Test passed.
            Hide
            marina Marina Glancy added a comment -

            And THANK YOU again for making Moodle better every day!

            Another weekly release has been released.

            Show
            marina Marina Glancy added a comment - And THANK YOU again for making Moodle better every day! Another weekly release has been released.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Nov/13