Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41806

Add accessors for scheme, host and port to moodle_url class

    Details

      Description

      In MDL-40848 it was necessary to re-parse a URL in order to extract specific URL components. It would be more efficient to be able to access them using moodle_url directly since the URL is already parsed within the class, but the properties are protected.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              salvetore Michael de Raadt added a comment -

              Thanks for suggesting that, Simon. Unit tests and all.

              Feel free to push this to peer review.

              Show
              salvetore Michael de Raadt added a comment - Thanks for suggesting that, Simon. Unit tests and all. Feel free to push this to peer review.
              Hide
              poltawski Dan Poltawski added a comment -

              Looks perfect to me, thanks Simon - sending for integration.

              Show
              poltawski Dan Poltawski added a comment - Looks perfect to me, thanks Simon - sending for integration.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Integrated (master only), thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (master only), thanks!
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Passed.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Passed.
              Hide
              marina Marina Glancy added a comment -

              And THANK YOU again for making Moodle better every day!

              Another weekly release has been released.

              Show
              marina Marina Glancy added a comment - And THANK YOU again for making Moodle better every day! Another weekly release has been released.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    18/Nov/13