Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41819

Grades lost when editing in the grader report due to max_input_vars

    Details

    • Testing Instructions:
      Hide

      Note: this requires some recent PHP, not 5.3.3.

      1/ set max_input_vars = 20 in your php.ini and restart apache
      2/ create course and enrol a few students (min 5)
      3/ go to gradebook and create some manual grade items
      4/ try to edit grades on grader report
      5/ you should get notice (if debug on - or read error log), but the saving should still work for all grades (especially at the end of the form)
      6/ verify the students per page preference works on grader report
      7/ repeat with backup and restore of course (course should have more than 20 activities)

      PS Do not forget to reset max_input_vars to default 1000 or unlimited after the test or you will start noticing critical bugs in moodle behaviour and create issues like I did ( – Marina )

      Show
      Note: this requires some recent PHP, not 5.3.3. 1/ set max_input_vars = 20 in your php.ini and restart apache 2/ create course and enrol a few students (min 5) 3/ go to gradebook and create some manual grade items 4/ try to edit grades on grader report 5/ you should get notice (if debug on - or read error log), but the saving should still work for all grades (especially at the end of the form) 6/ verify the students per page preference works on grader report 7/ repeat with backup and restore of course (course should have more than 20 activities) PS Do not forget to reset max_input_vars to default 1000 or unlimited after the test or you will start noticing critical bugs in moodle behaviour and create issues like I did ( – Marina )
    • Workaround:
      Hide

      set appropriate max_input_vars in your php.ini

      Show
      set appropriate max_input_vars in your php.ini
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w48_MDL-41819_m27_maxinputvars
    • Story Points (Obsolete):
      40
    • Sprint:
      BACKEND Sprint 7

      Description

      I have a number of manual grade items used to track offline assignments. Recently I've found with the latest moodle version that the last 4-7 students in the grader report do not have their entered grades saved. This seems to be something related to sort - if I sort by their first names and enter the grades again, they are saved properly. If I reverse sort last names, grades are saved properly as well.

      Procedure:

      1. Create a new manual grade item named "Pop Quiz 1 - Neural & Hormonal Lecture"
      2. Have a class of approximately 27 students.
      3. Enter grades using the Grader Report with editing turned on.
      4. Hit update.

      I've noticed that this does not happen when AJAX grading is turned on & working (i.e. the cells are changing color).

      This happens both in Google Chrome (with a variety of extensions) and Safari (with no extensions), on a Mac running Mountain Lion.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  13 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/Jan/14