Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41833

SetType warnings in feedback when trying to delete a response

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.5.2
          • Fix Version/s: 2.4.7, 2.5.3, 2.6
          • Component/s: Feedback
          • Labels:
          • Testing Instructions:
            Hide
            1. Make sure you have all debugging turned on in your php.ini and moodle config.
            2. Create a feedback activity.
            3. submit a feedback as student.
            4. Try deleting the student response as Admin.
            5. make sure you don't get any setType warnings.
            Show
            Make sure you have all debugging turned on in your php.ini and moodle config. Create a feedback activity. submit a feedback as student. Try deleting the student response as Admin. make sure you don't get any setType warnings.
          • Affected Branches:
            MOODLE_25_STABLE
          • Fixed Branches:
            MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            MDL-41833-master
          • Pull Master Diff URL:
          • Sprint:
            BACKEND Sprint 5
          • Story Points (Obsolete):
            2
          • Sprint:
            BACKEND Sprint 5

            Description

            1. Create a feedback activity
            2. submit a feedback as student
            3. Try deleting the student response as Admin.
            4. make sure you don't get the following error:- 

              Did you remember to call setType() for 'completedid'? Defaulting to PARAM_RAW cleaning.
              		 
               
              		 
                  line 1336 of /lib/formslib.php: call to debugging()
              		 
                  line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
              		 
                  line 202 of /lib/formslib.php: call to moodleform->_process_submission()
              		 
                  line 59 of /mod/feedback/delete_completed.php: call to moodleform->moodleform()
              		 
               
              		 
              Skip to main content
              		 
              test
              		 
              You are logged in as Admin User (Log out)
              		 
               

              Gliffy Diagrams

                Attachments

                  Issue Links

                  Testing discovered

                  Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-40047 Replace add_to_log with an event trigger - mod_feedback

                  • Major - Major loss of function, incorrect output
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    grabs Andreas Grabs added a comment -

                    Hi Ankit,
                    thank you very much!
                    Andreas

                    Show
                    grabs Andreas Grabs added a comment - Hi Ankit, thank you very much! Andreas
                    Hide
                    Permalink
                    abgreeve Adrian Greeve added a comment -

                    Thanks Ankit,

                    I see nothing wrong with your patch.
                    Onward and upward!

                    Show
                    abgreeve Adrian Greeve added a comment - Thanks Ankit, I see nothing wrong with your patch. Onward and upward!
                    Hide
                    Permalink
                    ankit_frenz Ankit Agarwal added a comment -

                    Thanks, pushing forward.

                    Show
                    ankit_frenz Ankit Agarwal added a comment - Thanks, pushing forward.
                    Hide
                    Permalink
                    marina Marina Glancy added a comment -

                    I wish all issues were as easy. Thanks, integrated in 2.4, 2.5 and master

                    Show
                    marina Marina Glancy added a comment - I wish all issues were as easy. Thanks, integrated in 2.4, 2.5 and master
                    Hide
                    Permalink
                    salvetore Michael de Raadt added a comment -

                    Test result: Success

                    Tested in 2.4, 2.5 and master.

                    No warnings shown while deleting student responses.

                    Show
                    salvetore Michael de Raadt added a comment - Test result: Success Tested in 2.4, 2.5 and master. No warnings shown while deleting student responses.
                    Hide
                    Permalink
                    marina Marina Glancy added a comment -

                    And THANK YOU again for making Moodle better every day!

                    Another weekly release has been released.

                    Show
                    marina Marina Glancy added a comment - And THANK YOU again for making Moodle better every day! Another weekly release has been released.

                      People

                      • Votes:
                        1 Vote for this issue
                        Watchers:
                        3 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          11/Nov/13