[MDL-41833] SetType warnings in feedback when trying to delete a response - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Make sure you have all debugging turned on in your php.ini and moodle config.

Create a feedback activity.

submit a feedback as student.

Try deleting the student response as Admin.

make sure you don't get any setType warnings.
Show
Make sure you have all debugging turned on in your php.ini and moodle config. Create a feedback activity. submit a feedback as student. Try deleting the student response as Admin. make sure you don't get any setType warnings.
Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull Master Branch:
~~MDL-41833~~-master
Pull Master Diff URL:
https://github.com/ankitagarwal/moodle/compare/da8cd86...MDL-41833-master

make sure you don't get the following error:-

Did you remember to call setType() for 'completedid'? Defaulting to PARAM_RAW cleaning.

    line 1336 of /lib/formslib.php: call to debugging()

    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()

    line 202 of /lib/formslib.php: call to moodleform->_process_submission()

    line 59 of /mod/feedback/delete_completed.php: call to moodleform->moodleform()

Skip to main content

test

You are logged in as Admin User (Log out)

Testing discovered

MDL-40047 Replace add_to_log with an event trigger - mod_feedback

Participants:: Adrian Greeve, Andreas Grabs, Ankit Agarwal, Marina Glancy, Michael de Raadt

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)