Moodle

SetType warnings in feedback when trying to delete a response

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.5.2
  • Fix Version/s: 2.4.7, 2.5.3, 2.6
  • Component/s: Feedback
  • Labels:

Description

  1. Create a feedback activity
  2. submit a feedback as student
  3. Try deleting the student response as Admin.
  4. make sure you don't get the following error:- 
    Did you remember to call setType() for 'completedid'? Defaulting to PARAM_RAW cleaning.

    line 1336 of /lib/formslib.php: call to debugging()
    line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
    line 202 of /lib/formslib.php: call to moodleform->_process_submission()
    line 59 of /mod/feedback/delete_completed.php: call to moodleform->moodleform()

Skip to main content
test
You are logged in as Admin User (Log out)

Issue Links

discovered while testing

Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-40047 Replace add_to_log with an event trigger - mod_feedback

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andreas Grabs added a comment -

Hi Ankit,
thank you very much!
Andreas

Show
Andreas Grabs added a comment - Hi Ankit, thank you very much! Andreas
Hide
Permalink
Adrian Greeve added a comment -

Thanks Ankit,

I see nothing wrong with your patch.
Onward and upward!

Show
Adrian Greeve added a comment - Thanks Ankit, I see nothing wrong with your patch. Onward and upward!
Hide
Permalink
Ankit Agarwal added a comment -

Thanks, pushing forward.

Show
Ankit Agarwal added a comment - Thanks, pushing forward.
Hide
Permalink
Marina Glancy added a comment -

I wish all issues were as easy. Thanks, integrated in 2.4, 2.5 and master

Show
Marina Glancy added a comment - I wish all issues were as easy. Thanks, integrated in 2.4, 2.5 and master
Hide
Permalink
Michael de Raadt added a comment -

Test result: Success

Tested in 2.4, 2.5 and master.

No warnings shown while deleting student responses.

Show
Michael de Raadt added a comment - Test result: Success Tested in 2.4, 2.5 and master. No warnings shown while deleting student responses.
Hide
Permalink
Marina Glancy added a comment -

And THANK YOU again for making Moodle better every day!

Another weekly release has been released.

Show
Marina Glancy added a comment - And THANK YOU again for making Moodle better every day! Another weekly release has been released.

People

Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:

Agile