Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41840

Restore: Page title, breadcrumbs show incorrect stage

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide

      1. If you don't have one already, make a backup of a small course such as the 'XS' test course.

      2. Restore the backup to a new course using default settings. On each page of the process, check the page title (label in browser tab), heading (at top of page depending on theme), and breadcrumbs.

      EXPECTED: The title is the course shortname followed by a colon and then 'Restore'; the heading is the course fullname; the breadcrumbs end with the link 'Restore'.

      EXPECTED: As before, the current stage is correctly indicated by bold highlighting in the strip that shows numbered restore stages.

      3. Import another course (can be the original one) into your new course.

      EXPECTED: The current step doesn't show in page title, heading, or breadcrumbs; these are consistent with restore, except with the word 'Import'.

      NOTE: An equivalent change for backup is included within MDL-41722.

      Show
      1. If you don't have one already, make a backup of a small course such as the 'XS' test course. 2. Restore the backup to a new course using default settings. On each page of the process, check the page title (label in browser tab), heading (at top of page depending on theme), and breadcrumbs. EXPECTED: The title is the course shortname followed by a colon and then 'Restore'; the heading is the course fullname; the breadcrumbs end with the link 'Restore'. EXPECTED: As before, the current stage is correctly indicated by bold highlighting in the strip that shows numbered restore stages. 3. Import another course (can be the original one) into your new course. EXPECTED: The current step doesn't show in page title, heading, or breadcrumbs; these are consistent with restore, except with the word 'Import'. NOTE: An equivalent change for backup is included within MDL-41722 .
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-41840-master

      Description

      While investigating MDL-41722, I noticed that the page title and breadcrumbs show incorrect page in restore as well. This is a regression caused by MDL-41253.

      Unfortunately it is impossible to make this information correct. The reason is that I have modified the code so that, if it takes a long time to make the 'process()' call, it displays a progress bar. As a result, we need to ensure the page header has been printed before this point. But before the process() call finishes, we can't actually tell which page we are on (there might be a form validation error or something).

      To solve this problem I propose to simply delete the information about the current step within restore from the page title and breadcrumbs. It still appears, in bold, in the backup/restore information strip that shows the list of pages, so I think this is sufficient.

      In addition the page title is currently not consistent between restore/import. As part of this change I will make it consistent in these two interfaces (also done in backup as part of another change), and also broadly consistent with e.g. the Participants page.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/13