[MDL-41843] Incorrect uses of namespace in mod/lti/OAuthBody.php - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE
Pull from Repository:
git://github.com/rajeshtaneja/moodle.git
Pull Master Branch:
wip-mdl-41843
Pull Master Diff URL:
https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-41843
Testing Instructions:
Hide

Create a external tool (LTI) activity with

Launch url http://www.imsglobal.org/developers/LTI/test/v1p1/tool.php

key 12345

secret secret

Launch external tool and it should work fine

Modify mod/lti/service.php and add $consumerkey='12345' before if (empty($consumerkey))

In browser go to mod/lti/service.php and make sure you see exception and not Fatal error: Class 'moodle\mod\lti\Exception' not found
Show
Create a external tool (LTI) activity with Launch url http://www.imsglobal.org/developers/LTI/test/v1p1/tool.php key 12345 secret secret Launch external tool and it should work fine Modify mod/lti/service.php and add $consumerkey='12345' before if (empty($consumerkey)) In browser go to mod/lti/service.php and make sure you see exception and not Fatal error: Class 'moodle\mod\lti\Exception' not found

OAuthBody.php states moodle\mod\lti namespace, but Exception class doesn't exist in this namespace, it should be \Exception or use OAuthException.

Participants:: Ankit Agarwal, Dan Poltawski, Dongsheng Cai, Eloy Lafuente (stronk7), Rajesh Taneja, Rossiani Wijaya

Component watchers:: Jake Dallimore, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie