Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41843

Incorrect uses of namespace in mod/lti/OAuthBody.php

    XMLWordPrintable

Details

    • MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • MOODLE_24_STABLE, MOODLE_25_STABLE
    • wip-mdl-41843
    • Hide
      1. Create a external tool (LTI) activity with
        1. Launch url http://www.imsglobal.org/developers/LTI/test/v1p1/tool.php
        2. key 12345
        3. secret secret
      2. Launch external tool and it should work fine
      3. Modify mod/lti/service.php and add $consumerkey='12345' before if (empty($consumerkey))
      4. In browser go to mod/lti/service.php and make sure you see exception and not Fatal error: Class 'moodle\mod\lti\Exception' not found
      Show
      Create a external tool (LTI) activity with Launch url http://www.imsglobal.org/developers/LTI/test/v1p1/tool.php key 12345 secret secret Launch external tool and it should work fine Modify mod/lti/service.php and add $consumerkey='12345' before if (empty($consumerkey)) In browser go to mod/lti/service.php and make sure you see exception and not Fatal error: Class 'moodle\mod\lti\Exception' not found
    • 5
    • BACKEND Sprint 6

    Description

      OAuthBody.php states moodle\mod\lti namespace, but Exception class doesn't exist in this namespace, it should be \Exception or use OAuthException.

      Attachments

        Activity

          People

            rajeshtaneja Rajesh Taneja
            dongsheng Dongsheng Cai
            Ankit Agarwal Ankit Agarwal
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Rossiani Wijaya Rossiani Wijaya
            Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              11/Nov/13