Moodle
  1. Moodle
  2. MDL-41848

SCORM packages can not be added using drag & drop

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: SCORM

      Description

      Discovered while testing MDL-39959. When I drag & drop a scorm package in a section (editing mode enabled) I see the following Javascript alert:

      An error occurred whilst communicating with the server
      

      The JS console reports

      dndupload.js (line 795)
      NetworkError: 500 Internal Server Error - http://localhost/INTEGRATION/master/course/dndupload.php"
      

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Frédéric Massart added a comment -

            Hi Dan,

            your patch looks good. Just a thought about scorm_update_instance() which was also altered in MDL-28579 and was previously that $mform was defined before using it. Does it need to be updated?

            Please feel free to push for integration.

            Cheers,
            Fred

            Show
            Frédéric Massart added a comment - Hi Dan, your patch looks good. Just a thought about scorm_update_instance() which was also altered in MDL-28579 and was previously that $mform was defined before using it. Does it need to be updated? Please feel free to push for integration. Cheers, Fred
            Hide
            Dan Marsden added a comment -

            yeah - makes sense - added and rebased - thanks!

            Show
            Dan Marsden added a comment - yeah - makes sense - added and rebased - thanks!
            Hide
            Sam Hemelryk added a comment -

            Thanks Dan - this has been integrated now.

            Show
            Sam Hemelryk added a comment - Thanks Dan - this has been integrated now.
            Hide
            Ankit Agarwal added a comment -

            Works as described.
            Thanks

            Show
            Ankit Agarwal added a comment - Works as described. Thanks
            Hide
            Dan Poltawski added a comment -

            You did it!

            Thanks for your contribution, this change has been merged upstream and is now available on your local git mirror and on download sites shortly.

            Show
            Dan Poltawski added a comment - You did it! Thanks for your contribution, this change has been merged upstream and is now available on your local git mirror and on download sites shortly.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: