Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41889

get_last_testcourse_id() does not get the last numeric sufix

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Performance
    • Labels:
    • Testing Instructions:
      Hide

      Test 1

      1. Run unit tests admin/tool/generator/tests/maketestsite_test.php

      Test 2

      1. cd /moodle/dirroot
      2. php admin/tool/generator/cli/maketestsite.php --size="S"
      3. You SHOULD NOT see any error
      4. php admin/tool/generator/cli/maketestsite.php --size="S"
      5. You SHOULD NOT see any error
      Show
      Test 1 Run unit tests admin/tool/generator/tests/maketestsite_test.php Test 2 cd /moodle/dirroot php admin/tool/generator/cli/maketestsite.php --size="S" You SHOULD NOT see any error php admin/tool/generator/cli/maketestsite.php --size="S" You SHOULD NOT see any error
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-41889_master
    • Pull Master Diff URL:

      Description

      tool_generator_site_backend::get_last_testcourse_id() is using SQL to order a string field which is a bad idea when we are really interested in ordering their numeric sufixes.

      MDL-41882 already includes this new behaviour

        Attachments

          Activity

            People

            Assignee:
            dmonllao David Monllaó
            Reporter:
            dmonllao David Monllaó
            Peer reviewer:
            Ankit Agarwal
            Integrator:
            Sam Hemelryk
            Tester:
            Michael de Raadt
            Participants:
            Component watchers:
            Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              18/Nov/13