Details

    • Rank:
      53072

      Description

      In the events_cron() function, if an event handler returns false or null, no more handlers of this type will be called for the duration of the cron. This currently happens silently, which can result in problems remaining undetected and event handler records building up.

      It would be very useful if failing handlers were logged in the cron log.

        Issue Links

          Activity

          Hide
          Michael Aherne added a comment -

          Here is a patch to allow these messages to be shown when debugging is switched on.

          Show
          Michael Aherne added a comment - Here is a patch to allow these messages to be shown when debugging is switched on.
          Hide
          Michael de Raadt added a comment -

          Thanks for suggesting this.

          Show
          Michael de Raadt added a comment - Thanks for suggesting this.
          Hide
          Petr Škoda added a comment -

          makes sense, +1

          Show
          Petr Škoda added a comment - makes sense, +1
          Hide
          Sam Hemelryk added a comment -

          Thanks Michael this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Michael this has been integrated now.
          Hide
          Sam Hemelryk added a comment -

          Gar this caused unit test failures.
          The following should reproduce it:

          vendor/bin/phpunit lib/tests/eventslib_test.php
          

          I've added a commit to address these so that it doesn't continue failing while we integrate.
          Please Michael/Petr could you review my commit and if not sufficient produce a better solution for me to integrate.

          Many thanks
          Sam

          Show
          Sam Hemelryk added a comment - Gar this caused unit test failures. The following should reproduce it: vendor/bin/phpunit lib/tests/eventslib_test.php I've added a commit to address these so that it doesn't continue failing while we integrate. Please Michael/Petr could you review my commit and if not sufficient produce a better solution for me to integrate. Many thanks Sam
          Hide
          Petr Škoda added a comment -

          Looks ok, it is legacy code anyway, thanks!

          Show
          Petr Škoda added a comment - Looks ok, it is legacy code anyway, thanks!
          Hide
          Frédéric Massart added a comment -

          Can I please have some testing instructions for this?

          Show
          Frédéric Massart added a comment - Can I please have some testing instructions for this?
          Hide
          Frédéric Massart added a comment -

          Passing thanks.

          Show
          Frédéric Massart added a comment - Passing thanks.
          Hide
          Dan Poltawski added a comment -

          You did it!

          Thanks for your contribution, this change has been merged upstream and is now available on your local git mirror and on download sites shortly.

          Show
          Dan Poltawski added a comment - You did it! Thanks for your contribution, this change has been merged upstream and is now available on your local git mirror and on download sites shortly.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: