Tim Hunt added a comment - 20/Sep/13 8:59 AM Thanks for finding and fixing it. I am surprised I have never seen that error. I assume this is ready for peer review. 1. First line of the commit comment is too long. 2. I would be surprised if the integrators accept the 2.3 branch, since that is now security fixes only. Still, no harm in having the branch. 3. You could usefully edit the testing instructions. They currently explain how to reproduce the bug, not how to verify that it is fixed. So, almost ready for integration, but not quite.

Tim Lock added a comment - 30/Sep/13 10:27 PM Hi Tim, Thanks for you comments, please advise where I can read up on the commit message guidelines?

Adam Olley added a comment - 01/Oct/13 12:12 AM http://docs.moodle.org/dev/Commit_cheat_sheet

Tim Lock added a comment - 01/Oct/13 12:28 AM Updated commit msg and github links

Tim Hunt added a comment - 01/Oct/13 6:36 AM The Master diff URL now points to an unrelated commit.

Tim Lock added a comment - 01/Oct/13 9:52 AM Fixed

Tim Hunt added a comment - 02/Oct/13 10:16 AM I don't really like this. In fact, I really don't like this. But given the horrible state of the formslib code, what you have done is probably the least bad solution. Thanks. Note that, if you want to get depressed search for isError, and you will find other places calling it statically. Anyway, submitting for integration.

Dan Poltawski added a comment - 04/Oct/13 4:27 AM The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao

Dan Poltawski added a comment - 09/Oct/13 2:30 AM - edited Thanks Tim, integrated to master, 25 and 24. Tim your 25 branch contained many more commits so I cherry-picked there, it'd be good if that branch was clean for future. It looks like your MOODLE_25_STABLE branch has lots of commits which are different from upstream: https://github.com/tlock/moodle/compare/moodle:MOODLE_25_STABLE...MOODLE_25_STABLE

Frédéric Massart added a comment - 09/Oct/13 4:02 AM Passing, thanks. I just noticed the following: Did you remember to call setType() for 'id'? Defaulting to PARAM_RAW cleaning. line 1334 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 51 of /mod/quiz/report/grading/gradingsettings_form.php: call to moodleform->moodleform() line 361 of /mod/quiz/report/grading/report.php: call to quiz_grading_settings_form->__construct() line 155 of /mod/quiz/report/grading/report.php: call to quiz_grading_report->display_grading_interface() line 100 of /mod/quiz/report.php: call to quiz_grading_report->display() Did you remember to call setType() for 'mode'? Defaulting to PARAM_RAW cleaning. line 1334 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 51 of /mod/quiz/report/grading/gradingsettings_form.php: call to moodleform->moodleform() line 361 of /mod/quiz/report/grading/report.php: call to quiz_grading_settings_form->__construct() line 155 of /mod/quiz/report/grading/report.php: call to quiz_grading_report->display_grading_interface() line 100 of /mod/quiz/report.php: call to quiz_grading_report->display() Did you remember to call setType() for 'slot'? Defaulting to PARAM_RAW cleaning. line 1334 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 51 of /mod/quiz/report/grading/gradingsettings_form.php: call to moodleform->moodleform() line 361 of /mod/quiz/report/grading/report.php: call to quiz_grading_settings_form->__construct() line 155 of /mod/quiz/report/grading/report.php: call to quiz_grading_report->display_grading_interface() line 100 of /mod/quiz/report.php: call to quiz_grading_report->display() Did you remember to call setType() for 'qid'? Defaulting to PARAM_RAW cleaning. line 1334 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 51 of /mod/quiz/report/grading/gradingsettings_form.php: call to moodleform->moodleform() line 361 of /mod/quiz/report/grading/report.php: call to quiz_grading_settings_form->__construct() line 155 of /mod/quiz/report/grading/report.php: call to quiz_grading_report->display_grading_interface() line 100 of /mod/quiz/report.php: call to quiz_grading_report->display() Did you remember to call setType() for 'page'? Defaulting to PARAM_RAW cleaning. line 1334 of /lib/formslib.php: call to debugging() line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType() line 202 of /lib/formslib.php: call to moodleform->_process_submission() line 51 of /mod/quiz/report/grading/gradingsettings_form.php: call to moodleform->moodleform() line 361 of /mod/quiz/report/grading/report.php: call to quiz_grading_settings_form->__construct() line 155 of /mod/quiz/report/grading/report.php: call to quiz_grading_report->display_grading_interface() line 100 of /mod/quiz/report.php: call to quiz_grading_report->display() Is there an issue for it?

Eloy Lafuente (stronk7) added a comment - 11/Oct/13 2:11 PM Yes, it's happening (somewhere in the French Polynesia, right now). And you did it, raising Moodle to new excellency levels. Or, if you prefer, yes, you fixed that boring issue. Thanks anyway! Ciao