Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41922

Course overview block incorrectly reports to students that quiz/assignments need attention

    Details

    • Testing Instructions:
      Hide
      1. Create a new quiz with a due date in the future
      2. Login as a student enrolled in that course
      3. Confirm that the quiz is reported as needing attention on the dashboard
      4. Attempt but do not finish the quiz
      5. Confirm that the quiz is still reported as needing attention on the dashboard
      6. Attempt and finish the quiz
      7. Confirm that the quiz is no longer reported as needing attention
      Show
      Create a new quiz with a due date in the future Login as a student enrolled in that course Confirm that the quiz is reported as needing attention on the dashboard Attempt but do not finish the quiz Confirm that the quiz is still reported as needing attention on the dashboard Attempt and finish the quiz Confirm that the quiz is no longer reported as needing attention
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull 3.0 Branch:
      MDL-41922-30-c
    • Pull 3.1 Branch:
      MDL-41922-31-c
    • Pull Master Branch:
      MDL-41922-master-c
    • Sprint:
      3.2 Sprint 1
    • Sprint:
      3.2 Sprint 1

      Description

      update: as of January 2015 it is reported that assignments no longer have problems in the students view (still some issues for teachers, see MDL-36233)

      Steps to reproduce:

      1. As a teacher:
        1. Create an assignment with a due date in the future
        2. Create an quiz with a due date in the future
      2. As a student
        1. Navigate to /my/ page, observe there are assignments and quizzes needing attention
        2. Submit your assignment for grading
        3. Attempt the quiz with correct answer

      Expected results:

      1. The course overview no longer displays that there are assignments/quizzes needing attention by the student

      Actual results:

      1. The block continues to display that the assignments and quizzes need attention even though the student can't do anything more with them.

        Gliffy Diagrams

          Attachments

          1. image1.png
            image1.png
            78 kB
          2. image2.png
            image2.png
            119 kB
          3. over_overview_fail.png
            over_overview_fail.png
            115 kB
          4. quiz1.png
            quiz1.png
            13 kB
          5. quiz2.png
            quiz2.png
            27 kB
          6. visibility-hidden.png
            visibility-hidden.png
            70 kB

            Issue Links

              Activity

              Hide
              xxanthee Xanthe Lawson added a comment -

              Thanks for raising this issue Forrest; we have many students who contact us in a panic when they get this message, thinking that something has gone wrong with the submission of their assignments. This is also frustrating for lecturers who then have to spend time letting the students know that 'Your assignment needs attention' actually means 'Your assignment is submitted and requires no further attention'.

              Show
              xxanthee Xanthe Lawson added a comment - Thanks for raising this issue Forrest; we have many students who contact us in a panic when they get this message, thinking that something has gone wrong with the submission of their assignments. This is also frustrating for lecturers who then have to spend time letting the students know that 'Your assignment needs attention' actually means 'Your assignment is submitted and requires no further attention'.
              Hide
              danmarsden Dan Marsden added a comment -

              Hi Forrest - it's hard to see here if you are reporting an issue with Turnitin or normal assignment in Moodle.

              If you are only reporting an issue with Turnitin we would close this as "not a bug" as Moodle core doesn't support or develop the turnitin assignment.

              Also - you have reported this as an improvement against the Moodle 2.2 assignment module - mod_assignment - this has been replaced with mod_assign in 2.3 and higher - no further feature work will be done on the 2.2 assignment as it has been replaced by mod_assign.

              If you think something needs to change in the mod_assign (2.3 assignment module) - please update the title/description of this bug to remove all references to Turnitin and only describe the issue you see with the new Moodle 2.3 assignment module.

              any issues with the turnitin assignment should be reported to Turnitin

              thanks!

              Show
              danmarsden Dan Marsden added a comment - Hi Forrest - it's hard to see here if you are reporting an issue with Turnitin or normal assignment in Moodle. If you are only reporting an issue with Turnitin we would close this as "not a bug" as Moodle core doesn't support or develop the turnitin assignment. Also - you have reported this as an improvement against the Moodle 2.2 assignment module - mod_assignment - this has been replaced with mod_assign in 2.3 and higher - no further feature work will be done on the 2.2 assignment as it has been replaced by mod_assign. If you think something needs to change in the mod_assign (2.3 assignment module) - please update the title/description of this bug to remove all references to Turnitin and only describe the issue you see with the new Moodle 2.3 assignment module. any issues with the turnitin assignment should be reported to Turnitin thanks!
              Hide
              forrest Forrest Duxbury added a comment -

              Hi Dan,

              Thanks for your quick reply.

              I'm concerned by both tools equally, they both have the same behaviour and that would lead me to believe they are using the same Moodle code and thus best fixed by Moodle. I have updated the images to highlight this.

              It could be an unreasonable assumption, but if at least the main Assignment tool is corrected I am happy to speak to Turnitin about their code. I can ask them to ensure the TII tool matches current Moodle assignment tool behaviour, which I can't currently do.

              We are using the newer assignment tool, thanks for picking it up, I have updated this. We are moving to Moodle 2.5 and I will be testing this, and I will update this ticket with my results. If resolved I will close this with an appropriate solution.

              Thanks!
              Forrest Duxbury

              Show
              forrest Forrest Duxbury added a comment - Hi Dan, Thanks for your quick reply. I'm concerned by both tools equally, they both have the same behaviour and that would lead me to believe they are using the same Moodle code and thus best fixed by Moodle. I have updated the images to highlight this. It could be an unreasonable assumption, but if at least the main Assignment tool is corrected I am happy to speak to Turnitin about their code. I can ask them to ensure the TII tool matches current Moodle assignment tool behaviour, which I can't currently do. We are using the newer assignment tool, thanks for picking it up, I have updated this. We are moving to Moodle 2.5 and I will be testing this, and I will update this ticket with my results. If resolved I will close this with an appropriate solution. Thanks! Forrest Duxbury
              Hide
              danmarsden Dan Marsden added a comment -

              It's likely that Turnitin have copied code from the Moodle Assignment codebase - but we can't fix their code - only the core code - so if you could update this description/title to describe only what you want changed in the Moodle core assignment that would help! - thanks!

              Show
              danmarsden Dan Marsden added a comment - It's likely that Turnitin have copied code from the Moodle Assignment codebase - but we can't fix their code - only the core code - so if you could update this description/title to describe only what you want changed in the Moodle core assignment that would help! - thanks!
              Hide
              forrest Forrest Duxbury added a comment -

              Hi Dan,

              That is fine, I am happy to contact them once the original Moodle code is resolved.

              Hopefully the changes have helped.

              Forrest

              Show
              forrest Forrest Duxbury added a comment - Hi Dan, That is fine, I am happy to contact them once the original Moodle code is resolved. Hopefully the changes have helped. Forrest
              Hide
              danmarsden Dan Marsden added a comment -

              thanks - that makes a bit more sense now!

              Show
              danmarsden Dan Marsden added a comment - thanks - that makes a bit more sense now!
              Hide
              forrest Forrest Duxbury added a comment -

              I have updated this for quizzes as well as our lecturers/students are also reporting this.

              Show
              forrest Forrest Duxbury added a comment - I have updated this for quizzes as well as our lecturers/students are also reporting this.
              Hide
              timhunt Tim Hunt added a comment -

              I have to say that this issue is almost incomprehensible. I think it is something to do with the My Moodle page, but it is not really clear. It would help if you could edit this issue to be

              1. Masively less verbose.
              2. Include detailed steps to reproduce.

              Show
              timhunt Tim Hunt added a comment - I have to say that this issue is almost incomprehensible. I think it is something to do with the My Moodle page, but it is not really clear. It would help if you could edit this issue to be 1. Masively less verbose. 2. Include detailed steps to reproduce.
              Hide
              forrest Forrest Duxbury added a comment -

              This is very basic. When a student submits an assignment or completes a quiz, the tool should not continue to say it needs attention.

              Steps to reproduce:
              1. Create a quiz or assignment, submit to it as student, look at the homepage notifications

              Show
              forrest Forrest Duxbury added a comment - This is very basic. When a student submits an assignment or completes a quiz, the tool should not continue to say it needs attention. Steps to reproduce: 1. Create a quiz or assignment, submit to it as student, look at the homepage notifications
              Hide
              timhunt Tim Hunt added a comment -

              That is not full steps to reproduce. Which homepage. Surely this only happens for quizzes with a close date? Good example of steps to reproduce here: https://tracker.moodle.org/browse/MDL-5688

              Show
              timhunt Tim Hunt added a comment - That is not full steps to reproduce. Which homepage. Surely this only happens for quizzes with a close date? Good example of steps to reproduce here: https://tracker.moodle.org/browse/MDL-5688
              Hide
              forrest Forrest Duxbury added a comment -

              My reasonable assumption is that Moodle Support staff:

              1. Are competent enough to know how to make a basic assignment or quiz in Moodle. Please refer to your support site under the 'Adding and editing an Assignment activity' title here: http://docs.moodle.org/24/en/Assignment_settings

              2. Know Moodle functionality well enough to know what a standard notification message is and where it is located, if only because it is used by multiple Moodle tools and plugins, and because the location was shown in the provided screen-shots

              3. That when presented with substantial information from the customer, and after forcing the customer to jump through multiple hoops by making them edit the ticket multiple times without attempting to acknowledge or address the issue, that support staff have sufficient good-will and customer service skills that they simply test what has been outlined

              Can this simply be tested? If you are having troubles replicating it, contact me for assistance.

              Show
              forrest Forrest Duxbury added a comment - My reasonable assumption is that Moodle Support staff: 1. Are competent enough to know how to make a basic assignment or quiz in Moodle. Please refer to your support site under the 'Adding and editing an Assignment activity' title here: http://docs.moodle.org/24/en/Assignment_settings 2. Know Moodle functionality well enough to know what a standard notification message is and where it is located, if only because it is used by multiple Moodle tools and plugins, and because the location was shown in the provided screen-shots 3. That when presented with substantial information from the customer, and after forcing the customer to jump through multiple hoops by making them edit the ticket multiple times without attempting to acknowledge or address the issue, that support staff have sufficient good-will and customer service skills that they simply test what has been outlined Can this simply be tested? If you are having troubles replicating it, contact me for assistance.
              Hide
              timhunt Tim Hunt added a comment -

              You know that Moodle is Open Source, right? I am not payed by Moodle, I work for the Open Universtiy in the UK, and am paid by them, just like you work for the university of New South Wales. My participation in this particular issue voluntary. Also, Moodle is a big complex beast. While I know the quiz backwards, I know almost nothing about the My Moodle page.

              If you want your bug fixed quickly, my advice to you is to make the problem report a clear and self-explanatory as possible, in the way I suggest. You don't have to follow my advice.

              Show
              timhunt Tim Hunt added a comment - You know that Moodle is Open Source, right? I am not payed by Moodle, I work for the Open Universtiy in the UK, and am paid by them, just like you work for the university of New South Wales. My participation in this particular issue voluntary. Also, Moodle is a big complex beast. While I know the quiz backwards, I know almost nothing about the My Moodle page. If you want your bug fixed quickly, my advice to you is to make the problem report a clear and self-explanatory as possible, in the way I suggest. You don't have to follow my advice.
              Hide
              sbourget Stephen Bourget added a comment -

              I think the issue here is not actually a quiz or assignment issue, but a problem with the course overview block.

              Skimming through the code quickly it looks like every module displayed in the block uses the same string 'You have {$a}s that need attention' and then it is up to the individual module (quiz, lesson, assignment, forum, etc) to display the information about any upcoming instances. The course overview block doesn't actually know anything about the individual instances, it simply prints the same headline for every module that will be displaying information in that block.

              I think the relevant code is here:
              http://git.moodle.org/gw?p=integration.git;a=blob;f=blocks/course_overview/renderer.php;h=6f33899ac122e047b8d5c22ab83cae90747d11dc;hb=refs/heads/MOODLE_25_STABLE#l162

              Forrest Duxbury,

              The simplest fix for this would be for the administrator on your site to use the Language customization tool to change that piece of text in the course overview block to display a something that you feel is better for your institution.
              (See http://docs.moodle.org/25/en/Language_editing)
              The string you want to change is "activityoverview"

              Show
              sbourget Stephen Bourget added a comment - I think the issue here is not actually a quiz or assignment issue, but a problem with the course overview block. Skimming through the code quickly it looks like every module displayed in the block uses the same string 'You have {$a}s that need attention' and then it is up to the individual module (quiz, lesson, assignment, forum, etc) to display the information about any upcoming instances. The course overview block doesn't actually know anything about the individual instances, it simply prints the same headline for every module that will be displaying information in that block. I think the relevant code is here: http://git.moodle.org/gw?p=integration.git;a=blob;f=blocks/course_overview/renderer.php;h=6f33899ac122e047b8d5c22ab83cae90747d11dc;hb=refs/heads/MOODLE_25_STABLE#l162 Forrest Duxbury, The simplest fix for this would be for the administrator on your site to use the Language customization tool to change that piece of text in the course overview block to display a something that you feel is better for your institution. (See http://docs.moodle.org/25/en/Language_editing ) The string you want to change is "activityoverview"
              Hide
              forrest Forrest Duxbury added a comment -

              Hi Tim,

              I knew Moodle was open-source, but I thought the Moodle tracker was worked on by paid Moodle company developers with the user community contributing as well. This is the first ticket I have raised and I attempted to put as much detail as possible. I wasn't expecting an active support service, just hoping that other Moodle users would identify with the ticket to drive resolution. But thanks for your assistance so far.

              Hi Stephen,

              That definitely gives me something to run with, thank you very much.

              Forrest Duxbury

              Show
              forrest Forrest Duxbury added a comment - Hi Tim, I knew Moodle was open-source, but I thought the Moodle tracker was worked on by paid Moodle company developers with the user community contributing as well. This is the first ticket I have raised and I attempted to put as much detail as possible. I wasn't expecting an active support service, just hoping that other Moodle users would identify with the ticket to drive resolution. But thanks for your assistance so far. Hi Stephen, That definitely gives me something to run with, thank you very much. Forrest Duxbury
              Hide
              paul.brown Paul Brown added a comment -

              We get constant messages from students on the issue (You have assignments that need attention) even though they have completed the assignments. Since the course work is work at your own pace we do not set Final Submission dates and with approximately 800 students this can be challenging as well as frustrating for our instructors and director. To resolve this issue, for the time being, I added the following custom CSS to hide that line of text.

              We use the Formal White them which we customize using the Custom CSS settings provide in the theme settings (see CSS code below). The custom CSS is saved into the database so that if Moodle is updated the custom CSS still remains in tack without breaking upon update.

              To enter the custom CSS in the Formal White (I am sure there is something similar in other themes) go to:

              Site Administration > Appearance > Themes > Formal White and then scroll to the very bottom where you will find the Custom CSS area.

              /* hides You have assignments that need attention using the visibility property set to hidden */
              .collapsibleregioncaption {
              visibility: hidden;
              }

              Show
              paul.brown Paul Brown added a comment - We get constant messages from students on the issue (You have assignments that need attention) even though they have completed the assignments. Since the course work is work at your own pace we do not set Final Submission dates and with approximately 800 students this can be challenging as well as frustrating for our instructors and director. To resolve this issue, for the time being, I added the following custom CSS to hide that line of text. We use the Formal White them which we customize using the Custom CSS settings provide in the theme settings (see CSS code below). The custom CSS is saved into the database so that if Moodle is updated the custom CSS still remains in tack without breaking upon update. To enter the custom CSS in the Formal White (I am sure there is something similar in other themes) go to: Site Administration > Appearance > Themes > Formal White and then scroll to the very bottom where you will find the Custom CSS area. /* hides You have assignments that need attention using the visibility property set to hidden */ .collapsibleregioncaption { visibility: hidden; }
              Hide
              forrest Forrest Duxbury added a comment -

              Hi Paul,

              Thanks for the contribution! I can see how that would be useful.

              We are currently upgrading from Moodle 2.3 -> 2.5, and during this our hosting provider (Netspot) is updating the language customisation as per Stephen's post.

              Our message is suitably generic so it can be used for all activities.

              We did find it was possible to set a specific message for Assignments, without affecting the other activities... but we didn't want to go down a path of creating/maintaining a unique message per activity.

              Best regards,
              Forrest Duxbury

              Show
              forrest Forrest Duxbury added a comment - Hi Paul, Thanks for the contribution! I can see how that would be useful. We are currently upgrading from Moodle 2.3 -> 2.5, and during this our hosting provider (Netspot) is updating the language customisation as per Stephen's post. Our message is suitably generic so it can be used for all activities. We did find it was possible to set a specific message for Assignments, without affecting the other activities... but we didn't want to go down a path of creating/maintaining a unique message per activity. Best regards, Forrest Duxbury
              Hide
              jamatrucola Joe Amatrucola added a comment -

              As the original author of the related forum discussion on this topic:
              https://moodle.org/mod/forum/discuss.php?d=226744
              I am posting to add my voice of support to this issue. I appreciate the solutions that have been suggested here regarding how to deal with the behavior as it currently exists (language customizations and CSS updates), but would offer that they seem like workarounds rather than solutions. If there is support behind this issue, perhaps we can continue the discussion along the lines of what is described in this post:
              https://moodle.org/mod/forum/discuss.php?d=226744#p993213
              and in earlier posts in this issue, so that the notification "You have assignments that need attention" regains some meaning? In other forum discussions, some have noted that their students & teachers have just become accustomed to ignoring the notification. Is that really the best answer?

              Show
              jamatrucola Joe Amatrucola added a comment - As the original author of the related forum discussion on this topic: https://moodle.org/mod/forum/discuss.php?d=226744 I am posting to add my voice of support to this issue. I appreciate the solutions that have been suggested here regarding how to deal with the behavior as it currently exists (language customizations and CSS updates), but would offer that they seem like workarounds rather than solutions. If there is support behind this issue, perhaps we can continue the discussion along the lines of what is described in this post: https://moodle.org/mod/forum/discuss.php?d=226744#p993213 and in earlier posts in this issue, so that the notification "You have assignments that need attention" regains some meaning? In other forum discussions, some have noted that their students & teachers have just become accustomed to ignoring the notification. Is that really the best answer?
              Hide
              mvgerwen Mitchell van Gerwen added a comment -

              We are using the plugin block "course overview on campus". the states of the assignments are shown more clearly. Maybe you can try it out

              https://moodle.org/plugins/view.php?plugin=block_course_overview_campus

              Show
              mvgerwen Mitchell van Gerwen added a comment - We are using the plugin block "course overview on campus". the states of the assignments are shown more clearly. Maybe you can try it out https://moodle.org/plugins/view.php?plugin=block_course_overview_campus
              Hide
              kanna Anna Krassa added a comment -

              Thank you Mitchell for the suggestion yet it's not always easy to use a plugin.

              One more vote to this bug, which appears in students' home page and confuses them. We actually don't use due dates just because of this problem.

              It's weird in 2.6 to be able to see detailed infos on the assignment status (submitted, graded), under the "you have assignments that need attention" phrase!

              We would appreciate a fix here... perhaps since we have full details on assignment status, can't you just remove this phrase completely? Or rephrase it from "you have assignments that need attention" to "course assignments"? :-/

              Show
              kanna Anna Krassa added a comment - Thank you Mitchell for the suggestion yet it's not always easy to use a plugin. One more vote to this bug, which appears in students' home page and confuses them. We actually don't use due dates just because of this problem. It's weird in 2.6 to be able to see detailed infos on the assignment status (submitted, graded), under the "you have assignments that need attention" phrase! We would appreciate a fix here... perhaps since we have full details on assignment status, can't you just remove this phrase completely? Or rephrase it from "you have assignments that need attention" to "course assignments"? :-/
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Thanks for reporting this Forrest,

              I agree that notifications should behave well. Currently, my home page (course_overview block) display what activity returns for print_overview().

              Every activity decides what it needs to display and I think this can be improved.

              I am putting this in backlog, feel free to work with us on this issue.
              If you are able to provide a patch or links to your Git repository branch, please add a patch label so we will spot it.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Thanks for reporting this Forrest, I agree that notifications should behave well. Currently, my home page (course_overview block) display what activity returns for print_overview(). Every activity decides what it needs to display and I think this can be improved. I am putting this in backlog, feel free to work with us on this issue. If you are able to provide a patch or links to your Git repository branch, please add a patch label so we will spot it.
              Hide
              zac Zachary Durber added a comment - - edited

              Hi all, I'm using MDL-47172 to correct the behaviour of the assignment notification there.

              I'll adjust it so that the students only have this notification when there is an open assignment pending a submission.

              Edit: I like your suggestion Joe, I'll investigate that too.

              Show
              zac Zachary Durber added a comment - - edited Hi all, I'm using MDL-47172 to correct the behaviour of the assignment notification there. I'll adjust it so that the students only have this notification when there is an open assignment pending a submission. Edit: I like your suggestion Joe, I'll investigate that too.
              Hide
              jamatrucola Joe Amatrucola added a comment -

              Thanks, Zachary. As you update the logic, please give some consideration to the suggestions in this discussion:
              https://moodle.org/mod/forum/discuss.php?d=226744#p993213
              including the logic for determining when the "You have assignments/quiz that need attention" notification appears on the teacher's course overview page as well. It would be great if the phrase could indicate to a teacher that he/she has to go in and grade submissions.

              Show
              jamatrucola Joe Amatrucola added a comment - Thanks, Zachary. As you update the logic, please give some consideration to the suggestions in this discussion: https://moodle.org/mod/forum/discuss.php?d=226744#p993213 including the logic for determining when the "You have assignments/quiz that need attention" notification appears on the teacher's course overview page as well. It would be great if the phrase could indicate to a teacher that he/she has to go in and grade submissions.
              Hide
              smily03 Chris Myers added a comment -

              Please see my comment here: https://tracker.moodle.org/browse/MDL-36233?focusedCommentId=309575&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-309575 for details on what's causing this on the faculty side. I'm guessing it could be the same cause on the student side.

              Show
              smily03 Chris Myers added a comment - Please see my comment here: https://tracker.moodle.org/browse/MDL-36233?focusedCommentId=309575&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-309575 for details on what's causing this on the faculty side. I'm guessing it could be the same cause on the student side.
              Hide
              tinarowe tina rowe added a comment -

              could we also have an option to just turn it off? It causes so much confusion with students and tutors and on the whole they don't need to be told anyway.

              Show
              tinarowe tina rowe added a comment - could we also have an option to just turn it off? It causes so much confusion with students and tutors and on the whole they don't need to be told anyway.
              Hide
              poltawski Dan Poltawski added a comment -

              I think this issue has got lost in all the comments on here, sorry to all the watchers. I've reproduced the issue, clarified the description and reclassified it as a bug.

              It has 74 votes here and for good reason - the course overview block is incorrectly reporting to students that there is action to do on activities which in fact there is none they can do. It seems like a poor design choice of the block to display the quiz/assignments in this situation and I can imagine for institutions this is a support nightmare.

              If you click the acitivites icons in block you see the real situation:

              My memory is a bit hazy - but I think this the block was repurposing an existing API function which didn't used to simply display 'x needs attention' and that change in purpose is probably what is causing the issue here.

              Show
              poltawski Dan Poltawski added a comment - I think this issue has got lost in all the comments on here, sorry to all the watchers. I've reproduced the issue, clarified the description and reclassified it as a bug. It has 74 votes here and for good reason - the course overview block is incorrectly reporting to students that there is action to do on activities which in fact there is none they can do. It seems like a poor design choice of the block to display the quiz/assignments in this situation and I can imagine for institutions this is a support nightmare. If you click the acitivites icons in block you see the real situation: My memory is a bit hazy - but I think this the block was repurposing an existing API function which didn't used to simply display 'x needs attention' and that change in purpose is probably what is causing the issue here.
              Hide
              poltawski Dan Poltawski added a comment -

              Note that one short term solution might be to use different terminology - but its clear to me that the purpose of this block shouldn't just to highlight various activities in non-closed states, it should be highlight things which need action - else thye can just go to the course page..

              Show
              poltawski Dan Poltawski added a comment - Note that one short term solution might be to use different terminology - but its clear to me that the purpose of this block shouldn't just to highlight various activities in non-closed states, it should be highlight things which need action - else thye can just go to the course page..
              Hide
              jamatrucola Joe Amatrucola added a comment -

              Dan, thanks for helping to move this issue forward, clarifying its details and reclassifying it as a bug. If you'd agree it's within scope, I'd ask that we not limit the focus to the notification for students only, but fix the issue for teachers as well. See the related comments above on Sept. 9 and 16. The issue title might be revised to read: "Course overview block incorrectly reports to students and teachers that quiz/assignments need attention"

              Show
              jamatrucola Joe Amatrucola added a comment - Dan, thanks for helping to move this issue forward, clarifying its details and reclassifying it as a bug. If you'd agree it's within scope, I'd ask that we not limit the focus to the notification for students only, but fix the issue for teachers as well. See the related comments above on Sept. 9 and 16. The issue title might be revised to read: "Course overview block incorrectly reports to students and teachers that quiz/assignments need attention"
              Hide
              pmk Przemek Kaszubski added a comment -

              I definitely second Joe's remark - the functionality of the My Home notifications can be improved a lot also for teachers.
              BTW SCORM packages also produce strange reports, hanging there all the time whether they have been viewed or not..
              On the other hand, workshops do not seem to produce notifications at all..
              I think the whole policy of course overview notifications needs simplifying / systematising - from the users' perspective.
              Students and teachers need a good dashboard - My Home does help but is yet rather far from perfection.
              I'm really happy to see this bug being flagged as critical and systematized. Many thanks!

              Show
              pmk Przemek Kaszubski added a comment - I definitely second Joe's remark - the functionality of the My Home notifications can be improved a lot also for teachers. BTW SCORM packages also produce strange reports, hanging there all the time whether they have been viewed or not.. On the other hand, workshops do not seem to produce notifications at all.. I think the whole policy of course overview notifications needs simplifying / systematising - from the users' perspective. Students and teachers need a good dashboard - My Home does help but is yet rather far from perfection. I'm really happy to see this bug being flagged as critical and systematized. Many thanks!
              Hide
              lenel Emilie Lenel added a comment - - edited

              I agree with Joe, we should not limit the focus to the noticiation for students only, but also fix the issue for teachers.
              I see that the status of this bug is still "open"
              I was thinking about hidding this text in css, and then display it again when the bug is fixed.
              We could add the property "display:none" to the class activity_overview, but it will hide all activity messages of the dashboard, isn't it ?
              Emilie

              Show
              lenel Emilie Lenel added a comment - - edited I agree with Joe, we should not limit the focus to the noticiation for students only, but also fix the issue for teachers. I see that the status of this bug is still "open" I was thinking about hidding this text in css, and then display it again when the bug is fixed. We could add the property "display:none" to the class activity_overview, but it will hide all activity messages of the dashboard, isn't it ? Emilie
              Hide
              peter nangle Peter Nangle added a comment -

              Forrest (the OP) and I are still getting periodic complaints about this, most recently regarding SCORM packages. I note it is up to 94 votes so I'm hoping there will be some progress soon. I think the core of this is that Moodle needs to differentiate between activities that actually require students to do something and activities trigger this message for other reasons.

              Show
              peter nangle Peter Nangle added a comment - Forrest (the OP) and I are still getting periodic complaints about this, most recently regarding SCORM packages. I note it is up to 94 votes so I'm hoping there will be some progress soon. I think the core of this is that Moodle needs to differentiate between activities that actually require students to do something and activities trigger this message for other reasons.
              Hide
              marina Marina Glancy added a comment -

              This issue is too generic. Each module type has to address the problem in itself.
              Some assignment problems were addressed in MDL-47172, other issues reported over assignment are MDL-37692 and MDL-36233
              Quiz also should be considered separately.
              SCORM is not mentioned here at all, I recommend you to create a new issue for SCORM with the correct component. Link it to this issue as related but the solutions will be completely different because the callbacks for the overview block are located in the individual modules

              Show
              marina Marina Glancy added a comment - This issue is too generic. Each module type has to address the problem in itself. Some assignment problems were addressed in MDL-47172 , other issues reported over assignment are MDL-37692 and MDL-36233 Quiz also should be considered separately. SCORM is not mentioned here at all, I recommend you to create a new issue for SCORM with the correct component. Link it to this issue as related but the solutions will be completely different because the callbacks for the overview block are located in the individual modules
              Hide
              danmarsden Dan Marsden added a comment -

              The ability to show the SCORM attempt status is a setting within the SCORM editing screen. Some organisations want this information to display in it's current form but I understand others may want slightly different information. As Marina mentions, feel free to create a new tracker issue to explain the improvements you would like specific to SCORM.

              Show
              danmarsden Dan Marsden added a comment - The ability to show the SCORM attempt status is a setting within the SCORM editing screen. Some organisations want this information to display in it's current form but I understand others may want slightly different information. As Marina mentions, feel free to create a new tracker issue to explain the improvements you would like specific to SCORM.
              Hide
              hartmut.s Hartmut Scherer added a comment -

              Is it possible to tie the notification of activities in Course overview to two events? Event A: student completes the activity before the due date. Then, the notification will stop.

              Event B: Student doesn't do anything in the activity. Then, the notification of the activity in the Course overview will only be displayed until the due (or cut off) date.

              So whichever event comes first will turn off the notification for students in Course overview.

              Show
              hartmut.s Hartmut Scherer added a comment - Is it possible to tie the notification of activities in Course overview to two events? Event A: student completes the activity before the due date. Then, the notification will stop. Event B: Student doesn't do anything in the activity. Then, the notification of the activity in the Course overview will only be displayed until the due (or cut off) date. So whichever event comes first will turn off the notification for students in Course overview.
              Hide
              Shupal Stefan added a comment -

              hey guys,

              is there something new about this issue and is it a offical core issue or just for every activity?

              Show
              Shupal Stefan added a comment - hey guys, is there something new about this issue and is it a offical core issue or just for every activity?
              Hide
              smily03 Chris Myers added a comment -

              Out of curiosity, is there something that we can be doing to try to help get this issue resolved?

              Show
              smily03 Chris Myers added a comment - Out of curiosity, is there something that we can be doing to try to help get this issue resolved?
              Hide
              eblanken Elizabeth Blankenship added a comment -

              If we could just turn these notices off at the site level, it would save so much confusion on the part of faculty and students.

              Show
              eblanken Elizabeth Blankenship added a comment - If we could just turn these notices off at the site level, it would save so much confusion on the part of faculty and students.
              Hide
              bltmacomb Barbara Taylor added a comment -

              It has been 2 years since this issue was first reported. Will there be a fix?

              Thanks,
              Barbara

              Show
              bltmacomb Barbara Taylor added a comment - It has been 2 years since this issue was first reported. Will there be a fix? Thanks, Barbara
              Hide
              smily03 Chris Myers added a comment -

              As an update, this is still an issue on Moodle 2.9.3+ (Build: 20151119)

              Show
              smily03 Chris Myers added a comment - As an update, this is still an issue on Moodle 2.9.3+ (Build: 20151119)
              Hide
              jamatrucola Joe Amatrucola added a comment -

              Still an issue for Moodle 3.0.1+ (Build: 20151221)

              Show
              jamatrucola Joe Amatrucola added a comment - Still an issue for Moodle 3.0.1+ (Build: 20151221)
              Hide
              marina Marina Glancy added a comment -

              Chris Myers, Joe Amatrucola, when you say that this is still an issue - which module type are you talking about. In my understanding assignment was fixed under MDL-47172
              is there something left to do for assignment here or is it just quiz that is left?

              Show
              marina Marina Glancy added a comment - Chris Myers , Joe Amatrucola , when you say that this is still an issue - which module type are you talking about. In my understanding assignment was fixed under MDL-47172 is there something left to do for assignment here or is it just quiz that is left?
              Hide
              smily03 Chris Myers added a comment -

              Marina Glancy, if you'd want to see my comments on MDL-36233, I've got the steps that I used to reproduce the issue; it still happens for us on 2.9.3+ (build 20151119.) If you want, I can try upgrading our test environment to the latest 2.x branch to see if it's still happening there?

              Show
              smily03 Chris Myers added a comment - Marina Glancy , if you'd want to see my comments on MDL-36233 , I've got the steps that I used to reproduce the issue; it still happens for us on 2.9.3+ (build 20151119.) If you want, I can try upgrading our test environment to the latest 2.x branch to see if it's still happening there?
              Hide
              smily03 Chris Myers added a comment -

              (I also have comments on that issue with what it looks like might be (partially?) causing the issue too.)

              Show
              smily03 Chris Myers added a comment - (I also have comments on that issue with what it looks like might be (partially?) causing the issue too.)
              Hide
              smily03 Chris Myers added a comment -

              (And, my comments have all been about assignments; I haven't tested the issue with quizzes.)

              Show
              smily03 Chris Myers added a comment - (And, my comments have all been about assignments; I haven't tested the issue with quizzes.)
              Hide
              bltmacomb Barbara Taylor added a comment -

              It also displays Turnitin assignments as needing attention. This is in 2.8.7

              Barbara

              Show
              bltmacomb Barbara Taylor added a comment - It also displays Turnitin assignments as needing attention. This is in 2.8.7 Barbara
              Hide
              marina Marina Glancy added a comment -

              Barbara Taylor, the callbacks for this block are located inside the modules. You have to create an issue on the turnitin tracker - it is not a standard plugin (this tracker project is only for core and standard modules)

              Show
              marina Marina Glancy added a comment - Barbara Taylor , the callbacks for this block are located inside the modules. You have to create an issue on the turnitin tracker - it is not a standard plugin (this tracker project is only for core and standard modules)
              Hide
              marina Marina Glancy added a comment -

              Chris Myers, the MDL-36233 is about what teacher sees and this issue is about students. I'm asking now if anything under THIS issue is still unresolved for the students?

              Show
              marina Marina Glancy added a comment - Chris Myers , the MDL-36233 is about what teacher sees and this issue is about students. I'm asking now if anything under THIS issue is still unresolved for the students?
              Hide
              smily03 Chris Myers added a comment -

              Sorry about that...just did some quick testing and it does look like the student issue is resolved now.

              Show
              smily03 Chris Myers added a comment - Sorry about that...just did some quick testing and it does look like the student issue is resolved now.
              Hide
              marina Marina Glancy added a comment -

              Thanks Chris,
              The problem with Quiz outlined in the original description is still present so I'm leaving this issue open

              Show
              marina Marina Glancy added a comment - Thanks Chris, The problem with Quiz outlined in the original description is still present so I'm leaving this issue open
              Hide
              jamatrucola Joe Amatrucola added a comment -

              Hi Marina,
              I see. I was indicating that from the teacher point of view (for assignments) this was still an issue, and hadn't tested from the student end. In fairness, I'm concerned about the teacher view just as much as the student view, so while I'm certainly happy that the student piece is being addressed, I hope there's a way that the momentum behind this long-outstanding issue can translate over to MDL-36233. There are others who've commented in this issue about the importance of fixing this for teachers as well, and I fear that it's not entirely apparent to all that we ought to start advocating for a fix in MDL-36233. FWIW, I have now started watching that issue and voted it up there.
              Thanks
              Joe

              Show
              jamatrucola Joe Amatrucola added a comment - Hi Marina, I see. I was indicating that from the teacher point of view (for assignments) this was still an issue, and hadn't tested from the student end. In fairness, I'm concerned about the teacher view just as much as the student view, so while I'm certainly happy that the student piece is being addressed, I hope there's a way that the momentum behind this long-outstanding issue can translate over to MDL-36233 . There are others who've commented in this issue about the importance of fixing this for teachers as well, and I fear that it's not entirely apparent to all that we ought to start advocating for a fix in MDL-36233 . FWIW, I have now started watching that issue and voted it up there. Thanks Joe
              Hide
              musolinom Mia Musolino added a comment -

              In 3.0, I am experiencing the issue with the teachers not seeing assignment notifications on the Dashboard. This is a serious issue for us.

              Show
              musolinom Mia Musolino added a comment - In 3.0, I am experiencing the issue with the teachers not seeing assignment notifications on the Dashboard. This is a serious issue for us.
              Hide
              fred Frédéric Massart added a comment -

              I posted on the quiz forum to get opinions: https://moodle.org/mod/forum/discuss.php?d=333564.

              Show
              fred Frédéric Massart added a comment - I posted on the quiz forum to get opinions: https://moodle.org/mod/forum/discuss.php?d=333564 .
              Hide
              fred Frédéric Massart added a comment -

              I've got a few rough patches for each of the solutions posted on the forum.

              A) Show when the last attempt is not finished.

              https://github.com/moodle/moodle/compare/master...FMCorz:MDL-41922-master-a

              B) Show when more attempts are allowed.

              https://github.com/moodle/moodle/compare/master...FMCorz:MDL-41922-master-b

              C) Show when no finished attempts are present.

              https://github.com/moodle/moodle/compare/master...FMCorz:MDL-41922-master-c

              As a developer, I personally prefer C for its simplicity, quick gain and lower impact on performance. B is the most costly of all, though I haven't tried hard to make it super efficient yet, I just wanted to pre-craft the solutions.

              Show
              fred Frédéric Massart added a comment - I've got a few rough patches for each of the solutions posted on the forum. A) Show when the last attempt is not finished. https://github.com/moodle/moodle/compare/master...FMCorz:MDL-41922-master-a B) Show when more attempts are allowed. https://github.com/moodle/moodle/compare/master...FMCorz:MDL-41922-master-b C) Show when no finished attempts are present. https://github.com/moodle/moodle/compare/master...FMCorz:MDL-41922-master-c As a developer, I personally prefer C for its simplicity, quick gain and lower impact on performance. B is the most costly of all, though I haven't tried hard to make it super efficient yet, I just wanted to pre-craft the solutions.
              Hide
              fred Frédéric Massart added a comment -

              Sending a patch for peer review.

              I went with option C, because:

              1. Option B is very similar to the existing behaviour, e.g. it will keep on reporting quizzes that may not be of interest to the student;
              2. Option A makes little sense as an attempt can only be started by a student, meaning that they would have to attempt one more attempt to then see the quiz as needing attention;
              3. Option C is an easy fix with a direct gain.

              There are many ways to improve the existing behaviour but then it should be considered an improvement and deferred to another issue.

              Cheers,
              Fred

              Show
              fred Frédéric Massart added a comment - Sending a patch for peer review. I went with option C, because: Option B is very similar to the existing behaviour, e.g. it will keep on reporting quizzes that may not be of interest to the student; Option A makes little sense as an attempt can only be started by a student, meaning that they would have to attempt one more attempt to then see the quiz as needing attention; Option C is an easy fix with a direct gain. There are many ways to improve the existing behaviour but then it should be considered an improvement and deferred to another issue. Cheers, Fred
              Hide
              cibot CiBoT added a comment -

              Code verified against automated checks.

              Checked MDL-41922 using repository: git://github.com/FMCorz/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Code verified against automated checks. Checked MDL-41922 using repository: git://github.com/FMCorz/moodle.git master (0 errors / 0 warnings) [branch: MDL-41922-master-c | CI Job ] More information about this report
              Hide
              timhunt Tim Hunt added a comment -
              1. I can't say I am a big fan of overloading the quiz_get_user_attempts API to that extent. But, I also cannot think of any other way to do it without duplicating code, which would be worse.
              2. I also don't really see why you have put AND userid = :userid into $attemptssq, but not other things. I would have left that clasuse separate in the place where all the SQL was put together, but again I don't think that is a big deal.
              3. This code seems buggy. https://github.com/FMCorz/moodle/compare/6a74e76...MDL-41922-master-c?w=1#diff-60e3ef4888f88976f619dd788dff385aR1480 $quiz->id is not set, right?
              4. The fact that bug is present suggests to me that a Behat test here would not be a waste of time.
              5. I guess this might have been a moment to change all this HTML generation to be in the quiz renderer, but you chose to consider that beyond the scope of this issue.

              I think of these, only 3 really needs to be fixed. However, you may also want to consider some of the other points. Let me know what you think.

              Show
              timhunt Tim Hunt added a comment - I can't say I am a big fan of overloading the quiz_get_user_attempts API to that extent. But, I also cannot think of any other way to do it without duplicating code, which would be worse. I also don't really see why you have put AND userid = :userid into $attemptssq, but not other things. I would have left that clasuse separate in the place where all the SQL was put together, but again I don't think that is a big deal. This code seems buggy. https://github.com/FMCorz/moodle/compare/6a74e76...MDL-41922-master-c?w=1#diff-60e3ef4888f88976f619dd788dff385aR1480 $quiz->id is not set, right? The fact that bug is present suggests to me that a Behat test here would not be a waste of time. I guess this might have been a moment to change all this HTML generation to be in the quiz renderer, but you chose to consider that beyond the scope of this issue. I think of these, only 3 really needs to be fixed. However, you may also want to consider some of the other points. Let me know what you think.
              Hide
              fred Frédéric Massart added a comment -

              Thanks Tim.

              1/ Me neither, that's why I added extensive Unit Tests to confirm that the behaviour is correct and hasn't changed.
              2/ I removed the need for $attemptsql.
              3/ Good catch, my bad!
              4/ Behat test added, it covers a few scenarios including the one that would have failed with #3.
              5/ I don't mind refactoring the code but I try not to fall into the habit of doing so because the chances of introducing regressions is greater. That also reduces the likelihood of having this issue backported.

              Sending for integration.

              Thanks!
              Fred

              Show
              fred Frédéric Massart added a comment - Thanks Tim. 1/ Me neither, that's why I added extensive Unit Tests to confirm that the behaviour is correct and hasn't changed. 2/ I removed the need for $attemptsql . 3/ Good catch, my bad! 4/ Behat test added, it covers a few scenarios including the one that would have failed with #3. 5/ I don't mind refactoring the code but I try not to fall into the habit of doing so because the chances of introducing regressions is greater. That also reduces the likelihood of having this issue backported. Sending for integration. Thanks! Fred
              Hide
              cibot CiBoT added a comment -

              Code verified against automated checks.

              Checked MDL-41922 using repository: git://github.com/FMCorz/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Code verified against automated checks. Checked MDL-41922 using repository: git://github.com/FMCorz/moodle.git MOODLE_30_STABLE (0 errors / 0 warnings) [branch: MDL-41922-30-c | CI Job ] MOODLE_31_STABLE (0 errors / 0 warnings) [branch: MDL-41922-31-c | CI Job ] master (0 errors / 0 warnings) [branch: MDL-41922-master-c | CI Job ] More information about this report
              Hide
              dobedobedoh Andrew Nicols added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              dobedobedoh Andrew Nicols added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              timhunt Tim Hunt added a comment -

              Thanks Fred.

              If you wanted to make the Behat tests slightly easier to read, you could calls the quizzes something better than Q1A, Q1D. Instead you could use something like C1-no-close. C1-future-close-to-finish. A bit verbose, but still easier to follow, I think.

              I am a big surprised that the second scenario works. When starting/submitting a quiz there is a Javascript confirm ... Ah! these are running without @javascript. I see.

              Thank you very much for sorting this one out.

              Show
              timhunt Tim Hunt added a comment - Thanks Fred. If you wanted to make the Behat tests slightly easier to read, you could calls the quizzes something better than Q1A, Q1D. Instead you could use something like C1-no-close. C1-future-close-to-finish. A bit verbose, but still easier to follow, I think. I am a big surprised that the second scenario works. When starting/submitting a quiz there is a Javascript confirm ... Ah! these are running without @javascript. I see. Thank you very much for sorting this one out.
              Hide
              fred Frédéric Massart added a comment -

              Thanks Tim.

              I've udpated the names of the quizzes. Indeed, it works without Javascript, so it's quick!

              Pleasure!

              Show
              fred Frédéric Massart added a comment - Thanks Tim. I've udpated the names of the quizzes. Indeed, it works without Javascript, so it's quick! Pleasure!
              Hide
              timhunt Tim Hunt added a comment -

              Yes, that helps. Thanks.

              Show
              timhunt Tim Hunt added a comment - Yes, that helps. Thanks.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Integrated (30, 31 & master), thanks!

              I've added the api_change label as far as it changes quiz_get_user_attempts(). Anyway, I'm not sure, as far as it's 100% BC, if such change should end documented in upgrade.txt or friends. For your consideration.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (30, 31 & master), thanks! I've added the api_change label as far as it changes quiz_get_user_attempts() . Anyway, I'm not sure, as far as it's 100% BC, if such change should end documented in upgrade.txt or friends. For your consideration.
              Hide
              timhunt Tim Hunt added a comment -

              It's 100% backwards compatible. No change to upgrade.txt needed, I think.

              Show
              timhunt Tim Hunt added a comment - It's 100% backwards compatible. No change to upgrade.txt needed, I think.
              Hide
              fred Frédéric Massart added a comment -

              I agree with Tim and removed the label. Thanks!

              Show
              fred Frédéric Massart added a comment - I agree with Tim and removed the label. Thanks!
              Hide
              marina Marina Glancy added a comment -

              Thanks Fred, all works great.
              I have noticed that I have the message "No attempts have been made on this quiz" that never changes, even if the attempt has been started.
              I hope it's not a problem

              Show
              marina Marina Glancy added a comment - Thanks Fred, all works great. I have noticed that I have the message "No attempts have been made on this quiz" that never changes, even if the attempt has been started. I hope it's not a problem
              Hide
              poltawski Dan Poltawski added a comment -

              Unfortunately the unit test introduced by this issue is failing randomly on ci servers, I've created MDL-54881 to address it

              Show
              poltawski Dan Poltawski added a comment - Unfortunately the unit test introduced by this issue is failing randomly on ci servers, I've created MDL-54881 to address it
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks for your contributions! This change is now available from the main moodle.git repository and will shortly be available on download.moodle.org.

              Strive not to be a success, but rather to be of value.
              – Albert Einstein

              Show
              poltawski Dan Poltawski added a comment - Thanks for your contributions! This change is now available from the main moodle.git repository and will shortly be available on download.moodle.org. Strive not to be a success, but rather to be of value. – Albert Einstein

                People

                • Votes:
                  130 Vote for this issue
                  Watchers:
                  92 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Jul/16