Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41944

Improve performance of Online users block

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.11, 2.3.9, 2.4.6, 2.5.2, 2.7.7, 2.8.5, 2.9.1, 3.0
    • Fix Version/s: 3.0
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide

      Add the online users block to a page. Simulate logged in users by logging in as a few different users using separate browsers/computers. Verify that all logged in users still appear in the block.

      Try the above when filtering on a group is effective (in a course with separated groups forced, logged in as student). Verify that all recently logged in users who are part of the student group still appear in the block while others are not.

      Run unit tests against all DBs.

      Show
      Add the online users block to a page. Simulate logged in users by logging in as a few different users using separate browsers/computers. Verify that all logged in users still appear in the block. Try the above when filtering on a group is effective (in a course with separated groups forced, logged in as student). Verify that all recently logged in users who are part of the student group still appear in the block while others are not. Run unit tests against all DBs.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull Master Branch:
      MDL-41944_block_online_users_perf

      Description

      The online users block uses MAX + GROUP BY when it is not needed. A significant performance gain can be achieved by fixing this.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              barrysspace Barry Oosthuizen
              Reporter:
              barrysspace Barry Oosthuizen
              Peer reviewer:
              John Okely
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                16/Nov/15