Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41958

Steps not shown consistently during import

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.2, 3.4.4, 3.5.1, 3.6.6, 3.7.2, 3.8
    • Fix Version/s: 3.9
    • Component/s: Backup
    • Testing Instructions:
      Hide

      First test:

      1. Test in Classic and Boost
      2. Provide two courses
      3. Go to the first course and go to Course administration → Import
      4. Cross check the "1. Course selection" bit is shown in the status indicator
      5. Choose the second course to import from, click "continue"
      6. In the following page cross check that only the "2. Initial settings" bit is highlighted (that's the MDL-41868 part of this fix).
      7. Proceed until the last page, perform the import.
      8. Upon arriving at the end of the import process cross check that the "6. Complete" bit is visible and highlighted.

      Second test:

      1. Test in Classic and Boost
      2. Go to a course and go to Course administration → Restore
      3. Upload each of the two mdz files MDL-41958-backup-unkown.mbz and MDL-41958-backup-moodle2.mbz and click on 'Restore'.
      4. Verify the "continue" button on the next page are solid ones (btn-primary)
      5. Upload a backup file with a format, which is not in moodle2 format, (see attached manual-1.9.zip and verify the third changed continue button of this patch (I don't have one) is also solid (in the page that says "The selected file is not a standard Moodle backup...".
      Show
      First test: Test in Classic and Boost Provide two courses Go to the first course and go to Course administration → Import Cross check the "1. Course selection" bit is shown in the status indicator Choose the second course to import from, click "continue" In the following page cross check that only the "2. Initial settings" bit is highlighted (that's the MDL-41868 part of this fix). Proceed until the last page, perform the import. Upon arriving at the end of the import process cross check that the "6. Complete" bit is visible and highlighted. Second test: Test in Classic and Boost Go to a course and go to Course administration → Restore Upload each of the two mdz files MDL-41958-backup-unkown.mbz and MDL-41958-backup-moodle2.mbz and click on 'Restore'. Verify the "continue" button on the next page are solid ones (btn-primary) Upload a backup file with a format, which is not in moodle2 format, (see attached manual-1.9.zip and verify the third changed continue button of this patch (I don't have one) is also solid (in the page that says "The selected file is not a standard Moodle backup...".
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull 3.7 Branch:
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-41958-master

      Description

      During the import process, the import process steps are not shown during the first step (1. Course selection) or the last step (6. Complete). This is inconsistent with the restore process (at least the last step) and it might be confusing for users to have the steps, but not show the steps, particularly at the final step.

        Attachments

        1. Confirmed fixed.png
          Confirmed fixed.png
          337 kB
        2. manual-1.9.zip
          2.33 MB
        3. MDL-41958-backup-moodle2.mbz
          4 kB
        4. MDL-41958-backup-unkown.mbz
          0.1 kB
        5. MDL-41958-both_bold.png
          MDL-41958-both_bold.png
          26 kB
        6. MDL-41958-status.gif
          MDL-41958-status.gif
          581 kB
        7. MDL-41958-status.gif
          MDL-41958-status.gif
          549 kB
        8. MDL-41958-step_1_boost.png
          MDL-41958-step_1_boost.png
          113 kB
        9. MDL-41958-step_1.png
          MDL-41958-step_1.png
          66 kB
        10. MDL-41958-step_2_boost.png
          MDL-41958-step_2_boost.png
          78 kB
        11. MDL-41958-step_2.png
          MDL-41958-step_2.png
          75 kB
        12. MDL-41958-step_3_boost.png
          MDL-41958-step_3_boost.png
          77 kB
        13. MDL-41958-step_3.png
          MDL-41958-step_3.png
          79 kB
        14. MDL-41958-step_4_boost.png
          MDL-41958-step_4_boost.png
          97 kB
        15. MDL-41958-step_4.png
          MDL-41958-step_4.png
          70 kB
        16. MDL-41958-step_5_boost.png
          MDL-41958-step_5_boost.png
          74 kB
        17. MDL-41958-step_5.png
          MDL-41958-step_5.png
          45 kB
        18. MDL-41958-step_6_boost.png
          MDL-41958-step_6_boost.png
          112 kB
        19. MDL-41958-step_6.png
          MDL-41958-step_6.png
          89 kB
        20. PeerReview-22-10-2019-Import-Step6.png
          PeerReview-22-10-2019-Import-Step6.png
          32 kB
        21. PeerReview-22-10-2019-Restore-Step6.png
          PeerReview-22-10-2019-Restore-Step6.png
          32 kB
        22. sample.patch
          1 kB
        23. updated_sample.patch
          5 kB

          Issue Links

            Activity

              People

              Assignee:
              lucaboesch Luca Bösch
              Reporter:
              salvetore Michael de Raadt
              Peer reviewer:
              Tobias Reischmann
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Gladys Basiana
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 15 minutes
                  1h 15m