Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41988

behat_base::spin could be improved to allow micro sleep

    XMLWordPrintable

Details

    • MOODLE_26_STABLE
    • MOODLE_26_STABLE
    • 41988-26
    • Hide

      Check that the behat tests pass as normal.
      The new functionality can't be tested in core presently, if you are very eager you could run the behat tests I have for MDL-31830

      Show
      Check that the behat tests pass as normal. The new functionality can't be tested in core presently, if you are very eager you could run the behat tests I have for MDL-31830

    Description

      While working on course management behat tests I had a need to use spin.
      I found there was one limitation, it uses sleep so the min wait time is 1s.
      I needed to watch for a DOM change that would last for just 1s and as such came up with this modification.

      Really it will allow us to tweak for performance more easily at a later date and at the same time also adds the ability to switch a closure for an array that maps to a class method to be called instead.

      Attachments

        Issue Links

          Activity

            People

              samhemelryk Sam Hemelryk
              samhemelryk Sam Hemelryk
              David Monllaó David Monllaó
              Marina Glancy Marina Glancy
              Frédéric Massart Frédéric Massart
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.