Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-41996

Displaying a broken link when a student hasn't attempted the quiz

          Details

          • Testing Instructions:
            Hide

            Setup new quiz with 1 question.
            Enrol 2 students.
            Attempt with one student and finish.
            Review attempts and show 'enrolled users who have not attempted the quiz'
            "Review attempt" link will not be shown.
            Review attempts and show 'enrolled users who have attempted the quiz'
            "Review attempt" link will be shown.

            Show
            Setup new quiz with 1 question. Enrol 2 students. Attempt with one student and finish. Review attempts and show 'enrolled users who have not attempted the quiz' "Review attempt" link will not be shown. Review attempts and show 'enrolled users who have attempted the quiz' "Review attempt" link will be shown.
          • Affected Branches:
            MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
          • Fixed Branches:
            MOODLE_24_STABLE, MOODLE_25_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            mdl41996-master
          • Pull Master Diff URL:

            Description

            When you look in the quiz overview report for a student that hasn't completed the quiz, there is a link to review attempt when they haven't attempted it!

            Error: Can not find data record in database table quiz_attempts.

              Gliffy Diagrams

                Attachments

                  Issue Links

                  is duplicated by

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-48381 Quiz reports give a 'Review attempt' link even if they student has not attempted the quiz

                  • Major - Major loss of function, incorrect output
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    timhunt Tim Hunt added a comment -

                    How did no-one notice that before?

                    Please can you edit the testing instructions to be testing instructions, and not steps to reproduce.

                    Show
                    timhunt Tim Hunt added a comment - How did no-one notice that before? Please can you edit the testing instructions to be testing instructions, and not steps to reproduce.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    I had some problems with your patches above for 25_STABLE and 24_STABLE, so I just have cherry-picked the master fix to those branches.

                    23_STABLE is out of support since some months ago… so this won't land there.

                    Integrated (24, 25 & master), thanks!

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - I had some problems with your patches above for 25_STABLE and 24_STABLE, so I just have cherry-picked the master fix to those branches. 23_STABLE is out of support since some months ago… so this won't land there. Integrated (24, 25 & master), thanks!
                    Hide
                    Permalink
                    abgreeve Adrian Greeve added a comment -

                    Tested on the 2.4, 2.5 and master integration branches.
                    No broken links in the quiz reports anymore.
                    Test passed.

                    Show
                    abgreeve Adrian Greeve added a comment - Tested on the 2.4, 2.5 and master integration branches. No broken links in the quiz reports anymore. Test passed.
                    Hide
                    Permalink
                    poltawski Dan Poltawski added a comment -

                    You did it!

                    Thanks for your contribution, this change has been merged upstream and is now available on your local git mirror and on download sites shortly.

                    Show
                    poltawski Dan Poltawski added a comment - You did it! Thanks for your contribution, this change has been merged upstream and is now available on your local git mirror and on download sites shortly.

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        3 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          11/Nov/13