Displaying a broken link when a student hasn't attempted the quiz

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.3.9, 2.4.6, 2.5.2, 2.6
Fix Version/s: 2.4.7, 2.5.3
Component/s: Quiz
Labels:
- netspot
- partner
- patch
- triaged

Testing Instructions:

Hide

Setup new quiz with 1 question.
Enrol 2 students.
Attempt with one student and finish.
Review attempts and show 'enrolled users who have not attempted the quiz'
"Review attempt" link will not be shown.
Review attempts and show 'enrolled users who have attempted the quiz'
"Review attempt" link will be shown.

Show
Setup new quiz with 1 question. Enrol 2 students. Attempt with one student and finish. Review attempts and show 'enrolled users who have not attempted the quiz' "Review attempt" link will not be shown. Review attempts and show 'enrolled users who have attempted the quiz' "Review attempt" link will be shown.
Affected Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
Fixed Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE
Pull from Repository:
https://github.com/tlock/moodle.git
Pull 2.4 Branch:
mdl41996-moodle24
Pull 2.4 Diff URL:
https://github.com/tlock/moodle/commit/60952908e8ebd6cbef5a276079a7a15855ef50af
Pull 2.5 Branch:
mdl41996-moodle25
Pull 2.5 Diff URL:
https://github.com/tlock/moodle/commit/7c87df64894df23ee9ed5abe91ea402b7f458cbd
Pull Master Branch:
mdl41996-master
Pull Master Diff URL:
https://github.com/tlock/moodle/commit/7d0f566b2da72388d4df07dde99bd1ad491e4875

Description

When you look in the quiz overview report for a student that hasn't completed the quiz, there is a link to review attempt when they haven't attempted it!

Error: Can not find data record in database table quiz_attempts.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Tim Hunt added a comment - 26/Sep/13 8:50 AM

How did no-one notice that before?

Please can you edit the testing instructions to be testing instructions, and not steps to reproduce.

Show

Tim Hunt added a comment - 26/Sep/13 8:50 AM How did no-one notice that before? Please can you edit the testing instructions to be testing instructions, and not steps to reproduce.

Hide

Permalink

Eloy Lafuente (stronk7) added a comment - 01/Oct/13 6:07 PM

I had some problems with your patches above for 25_STABLE and 24_STABLE, so I just have cherry-picked the master fix to those branches.

23_STABLE is out of support since some months ago… so this won't land there.

Integrated (24, 25 & master), thanks!

Show

Eloy Lafuente (stronk7) added a comment - 01/Oct/13 6:07 PM I had some problems with your patches above for 25_STABLE and 24_STABLE, so I just have cherry-picked the master fix to those branches. 23_STABLE is out of support since some months ago… so this won't land there. Integrated (24, 25 & master), thanks!

Hide

Permalink

Adrian Greeve added a comment - 02/Oct/13 4:18 AM

Tested on the 2.4, 2.5 and master integration branches.
No broken links in the quiz reports anymore.
Test passed.

Show

Adrian Greeve added a comment - 02/Oct/13 4:18 AM Tested on the 2.4, 2.5 and master integration branches. No broken links in the quiz reports anymore. Test passed.

Hide

Permalink

Dan Poltawski added a comment - 04/Oct/13 4:24 AM

You did it!

Thanks for your contribution, this change has been merged upstream and is now available on your local git mirror and on download sites shortly.

Show

Dan Poltawski added a comment - 04/Oct/13 4:24 AM You did it! Thanks for your contribution, this change has been merged upstream and is now available on your local git mirror and on download sites shortly.

People

Assignee:

Tim Lock

Reporter:

Tim Lock

Peer reviewer:

Tim Hunt

Integrator:

Eloy Lafuente (stronk7)

Tester:

Adrian Greeve

Participants:

Adrian Greeve, Dan Poltawski, Eloy Lafuente (stronk7), Tim Hunt, Tim Lock

Vote (0)

Watch (2)

Dates

Created:

26/Sep/13 4:13 AM

Updated:

04/Oct/13 4:24 AM

Resolved:

04/Oct/13 4:24 AM

Agile

View on Board