Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42006

Make use of new moodle_url() accessors

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Development in progress
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.5.2
    • Fix Version/s: BACKEND
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      TO TESTER: There is a lot of info here, we are just checking all the areas where url parsing has changed, so you need to just make sure the url parsing continues to work and there isn't a massive bug causing issues. Remember this when working through. Some testing instructions are vague on assumption you know or can learn how to do the steps to get to the point of the test.

      1. Go to
        Site administration / ▶︎ Development / ▶︎ Make JMeter test plan
      2. [Do the setup required on that page]
      3. Download the test plan
      4. Open the XML file and ensure the properties for host and sitepath have been replaced correctly, e.g

          <elementProp name="host" elementType="Argument">
            <stringProp name="Argument.name">host</stringProp>
            <stringProp name="Argument.value">moodle.dev</stringProp>
            <stringProp name="Argument.metadata">=</stringProp>
          </elementProp>
          <elementProp name="sitepath" elementType="Argument">
            <stringProp name="Argument.name">sitepath</stringProp>
            <stringProp name="Argument.value">/pm</stringProp>
            <stringProp name="Argument.metadata">=</stringProp>
          </elementProp>
        

      1. DP FIXME: Conncet to an external backpack
      2. DP FIXME: Open the badge edit form, check the hidden itme 'hiddenurl'
      1. Ensure useexternalblogs is enabled
      2. Go to Dashboard / ▶︎ Preferences / ▶︎ Blogs / ▶︎ External blogs and register an external blog (e.g. http://feeds.bbci.co.uk/news/video_and_audio/technology/rss.xml)
      3. Go to your blog and ensure the "Retrieved from:" sends to the same place before and after the patch
      1. Install a new moodle install
      2. Check the siteidentifier in config table
      1. Go admin settings for noreplyaddress
      2. Ensure the default noreplyaddress is the same before and afer patch (e.g. Default: noreply@moodle.dev)
      3. Repeat the same for chat_serverhost (e.g. Default: moodle.dev)
      1. Setup your moodle to send emails, post some forum posts and wait to recieve the email to arrive
      2. verify the mail headers List-Id: and Message-ID:, verify they have the same hostname part before and after the patch
      1. Run the LTI QA test MDLQA-8880
      1. Run unit tets
      Show
      TO TESTER: There is a lot of info here, we are just checking all the areas where url parsing has changed, so you need to just make sure the url parsing continues to work and there isn't a massive bug causing issues. Remember this when working through. Some testing instructions are vague on assumption you know or can learn how to do the steps to get to the point of the test. Go to Site administration / ▶︎ Development / ▶︎ Make JMeter test plan [Do the setup required on that page] Download the test plan Open the XML file and ensure the properties for host and sitepath have been replaced correctly, e.g <elementProp name="host" elementType="Argument"> <stringProp name="Argument.name">host</stringProp> <stringProp name="Argument.value">moodle.dev</stringProp> <stringProp name="Argument.metadata">=</stringProp> </elementProp> <elementProp name="sitepath" elementType="Argument"> <stringProp name="Argument.name">sitepath</stringProp> <stringProp name="Argument.value">/pm</stringProp> <stringProp name="Argument.metadata">=</stringProp> </elementProp> DP FIXME: Conncet to an external backpack DP FIXME: Open the badge edit form, check the hidden itme 'hiddenurl' Ensure useexternalblogs is enabled Go to Dashboard / ▶︎ Preferences / ▶︎ Blogs / ▶︎ External blogs and register an external blog (e.g. http://feeds.bbci.co.uk/news/video_and_audio/technology/rss.xml ) Go to your blog and ensure the "Retrieved from:" sends to the same place before and after the patch Install a new moodle install Check the siteidentifier in config table Go admin settings for noreplyaddress Ensure the default noreplyaddress is the same before and afer patch (e.g. Default: noreply@moodle.dev) Repeat the same for chat_serverhost (e.g. Default: moodle.dev) Setup your moodle to send emails, post some forum posts and wait to recieve the email to arrive verify the mail headers List-Id: and Message-ID:, verify they have the same hostname part before and after the patch Run the LTI QA test MDLQA-8880 Run unit tets
    • Affected Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-42006-master

      Description

      Following on from MDL-41806 I'm creating this bug to tidy up places where urls are being parsed that could now use the new accessor methods.

      The specific case they were created for was in MDL-40848 but a quick grep of the code for parse_url() finds a few other places that could be simplified now.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              poltawski Dan Poltawski
              Reporter:
              simoncoggins Simon Coggins
              Peer reviewer:
              Jun Pataleta
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated: