Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42023

Edit PDF: Integrate editpdf plugin for mod_assign

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6, FRONTEND
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to the admin settings page for the annotate pdf plugin.
      2. Make sure ghostscript is installed on your system and the path is correct in the setting.
      3. Test the ghostscript path and make sure the test image displays.
      4. Upload some stamps
      5. Create an assignment with submission files enabled, and annotate pdf (feedback) enabled.
      6. Login as a student and add a pdf file as your submission to the assignment
      7. Login as a teacher and grade the student (not quickgrade)
      8. The work flow is to click "Launch PDF Editor" on the grading page to start the editor - changes are automatically saved as you go - but are not sent to the student until you click save on the grading page which also generates the feedback pdf.
      9. Do some exploratory testing in different browsers.
      10. Backup the assignment
      11. Delete some stamps that were used in the assignment
      12. Restore the assignment
      13. Verify the stamps still display in the assignment

      Known issues at this time:
      Behat tests. We will work on behat tests for this - but it will probably require changes to behat for 2 reasons - the first is that the tests should be skipped if ghostscript is not installed/available. Currently skipped tests in behat count pretty much like failures (according to David) so we will need some better behaviour here if we are to add tests. The second reason is that in order to draw etc, you need click and drag - which doesn't work very well with behat. (There are unit tests).

      RTL support. We still have an open issue to add extra fonts and some RTL switching behaviour for comments. We will get this finished for the release.

      Background processing. Would be lovely - but there are big cron/locking issues to finish first (see the chain from MDL-25500). I have done heaps of work on these but they will not be ready for 2.6.

      Icon colours. There is an open issue to finalise the colours of the icons for comments.

      Show
      Go to the admin settings page for the annotate pdf plugin. Make sure ghostscript is installed on your system and the path is correct in the setting. Test the ghostscript path and make sure the test image displays. Upload some stamps Create an assignment with submission files enabled, and annotate pdf (feedback) enabled. Login as a student and add a pdf file as your submission to the assignment Login as a teacher and grade the student (not quickgrade) The work flow is to click "Launch PDF Editor" on the grading page to start the editor - changes are automatically saved as you go - but are not sent to the student until you click save on the grading page which also generates the feedback pdf. Do some exploratory testing in different browsers. Backup the assignment Delete some stamps that were used in the assignment Restore the assignment Verify the stamps still display in the assignment Known issues at this time: Behat tests. We will work on behat tests for this - but it will probably require changes to behat for 2 reasons - the first is that the tests should be skipped if ghostscript is not installed/available. Currently skipped tests in behat count pretty much like failures (according to David) so we will need some better behaviour here if we are to add tests. The second reason is that in order to draw etc, you need click and drag - which doesn't work very well with behat. (There are unit tests). RTL support. We still have an open issue to add extra fonts and some RTL switching behaviour for comments. We will get this finished for the release. Background processing. Would be lovely - but there are big cron/locking issues to finish first (see the chain from MDL-25500 ). I have done heaps of work on these but they will not be ready for 2.6. Icon colours. There is an open issue to finalise the colours of the icons for comments.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-42023-master
    • Story Points (Obsolete):
      13
    • Sprint:
      FRONTEND Sprint 5

      Description

      This task is to integrate the initial version of the editpdf plugin. There are a few issues in the Epic that will be done after the release of 2.6 (particularly the background processing) so we want to keep the epic open and make this first version one of the sub tasks.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  11 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    18/Nov/13