Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.5
-
Fix Version/s: 2.5.3
-
Component/s: Installation
-
Testing Instructions:
-
Workaround:
-
Affected Branches:MOODLE_25_STABLE
-
Fixed Branches:MOODLE_25_STABLE
-
Pull from Repository:
-
Pull Master Branch:w45_
MDL-42044_m26_zipaddon -
Pull Master Diff URL:
-
Story Points:3
-
Sprint:BACKEND Sprint 6
Description
When the auto install add ons validation looks for the /lang/en folder.
If it does not find it, then validation fails and the plugin cannot be installed.
Depending on how the add on zip file was created however, there may be no folder entries in the zip file. Just files with the full file path.
Most unzip apps can handle both ok. To illustrate, the contents of the PoodLL filter which fails validation look a bit like this:
poodll/lang/en/filter_poodll.php
poodll/module.js
poodll/pix/download.gif
But the ensemble filter zip which passes validation looks like this:
ensemble/lang/
ensemble/lang/en/
ensemble/lang/en/filter_ensemble.php
ensemble/pix/
ensemble/pix/icon.png
The code that does all this in:
admin/tool/installaddon/classes/validator.php
And the area that needs to be fixed is in function:
validate_language_pack