Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42054

phpmailer unit test redirection is using incorrect test

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.6, 2.5.2, 2.6
    • Fix Version/s: 2.4.7, 2.5.3
    • Component/s: Unit tests
    • Labels:
    • Story Points:
      2
    • Sprint:
      BACKEND Sprint 5

      Description

      see https://tracker.moodle.org/browse/MDL-41196?focusedCommentId=246970&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-246970

      Yuliya Bozhko added a comment - 29/Sep/13 10:50 PM
      Looking through the comments history, I think in moodle_phpmailer.php it should check not redirected messages, but redirected emails...

      if (PHPUNIT_TEST && phpunit_util::is_redirecting_phpmailer()) {

      Otherwise, if I redirect emails only, my message sink is always empty. Discovered while trying to write tests for MDL-41956.

        Attachments

          Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-41956 Accept attachments in message_send() in email message provider

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42224 clean up messaging and email redirection in unit tests

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-41196 Add phpmailer message sink to allow unit testing of email_to_user

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41197 core_text::convert produces notices when experiencing invalid utf8 params or char not in target encoding

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              skodak Petr Skoda
              Integrator:
              Dan Poltawski
              Tester:
              Rossiani Wijaya
              Participants:
              Component watchers:
              Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Nov/13