Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42054

phpmailer unit test redirection is using incorrect test

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 2.4.7, 2.5.3
    • 2.4.6, 2.5.2, 2.6
    • Unit tests
    • 2
    • BACKEND Sprint 5

    Description

      see https://tracker.moodle.org/browse/MDL-41196?focusedCommentId=246970&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-246970

      Yuliya Bozhko added a comment - 29/Sep/13 10:50 PM
      Looking through the comments history, I think in moodle_phpmailer.php it should check not redirected messages, but redirected emails...

      if (PHPUNIT_TEST && phpunit_util::is_redirecting_phpmailer()) {

      Otherwise, if I redirect emails only, my message sink is always empty. Discovered while trying to write tests for MDL-41956.

      Attachments

        Issue Links

          Activity

            People

              skodak Petr Skoda (Inactive)
              skodak Petr Skoda (Inactive)
              Dan Poltawski Dan Poltawski
              Rossiani Wijaya Rossiani Wijaya
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.