Moodle
  1. Moodle
  2. MDL-42068

File picker course listing use courselistshortnames to display course name

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.6, 2.5.2, 2.6
    • Fix Version/s: 2.4.7, 2.5.3
    • Component/s: Filepicker
    • Labels:
    • Testing Instructions:
      Hide

      Test 1

      1. Log in as admin
      2. Enable courselistshortnames under course settings (Home ► Site administration ► Appearance ► Courses)
      3. Create a course
      4. Add a resource file to the course
      5. Edit that resource
      6. In file upload window click "add" to get filepicker to show
      7. Click "Server Files"
      8. Navigate category structure to find course under any view(Icon, Detail, or Tree)
      9. Make sure name of courses are like "COURSE_SHORT_NAME COURSE_FULL_NAME"
      10. Login as Instructor or user with permission to see "Server Files"
      11. Repeat Steps 5-9

      Test 2:

      1. Deselect courselistshortnames (See Test 1 steps 1-2)
      2. Repeat steps 5-9 from Test 1
      3. make sure you see course Fullname only.
      Show
      Test 1 Log in as admin Enable courselistshortnames under course settings (Home ► Site administration ► Appearance ► Courses) Create a course Add a resource file to the course Edit that resource In file upload window click "add" to get filepicker to show Click "Server Files" Navigate category structure to find course under any view(Icon, Detail, or Tree) Make sure name of courses are like "COURSE_SHORT_NAME COURSE_FULL_NAME" Login as Instructor or user with permission to see "Server Files" Repeat Steps 5-9 Test 2: Deselect courselistshortnames (See Test 1 steps 1-2) Repeat steps 5-9 from Test 1 make sure you see course Fullname only.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:
      wip-MDL-42068-m26-showshortnamefilepicker
    • Rank:
      53265

      Description

      I've filed this as an improvement but this could be considered a bug by some.

      In the file picker under the repo "Server Files". The course listing for files only shows the fullname. I need to be able to see the shortname as well.

        Activity

        Hide
        James Henestofel added a comment -

        I've created the fix on my github repo

        Show
        James Henestofel added a comment - I've created the fix on my github repo
        Hide
        Marina Glancy added a comment -

        Thanks James, this is a great spotting and fix.

        TO INTEGRATORS: It can be (and imho should be) cherry-picked to 2.4 and 2.5
        Please ignore the fact that I'm both assignee and peer reviewer - I can't assign it to James

        Show
        Marina Glancy added a comment - Thanks James, this is a great spotting and fix. TO INTEGRATORS: It can be (and imho should be) cherry-picked to 2.4 and 2.5 Please ignore the fact that I'm both assignee and peer reviewer - I can't assign it to James
        Hide
        Marina Glancy added a comment -

        James, just one thing - can you please change your commit message so it starts with the issue number followed by space. Thanks

        Show
        Marina Glancy added a comment - James, just one thing - can you please change your commit message so it starts with the issue number followed by space. Thanks
        Hide
        James Henestofel added a comment -

        Marina,
        I've updated the commit message with the issue number. A thing about Github though is that it seems to be lagging in updating when you are looking at the file's commit message. But the main commit message seems to be updated.

        Show
        James Henestofel added a comment - Marina, I've updated the commit message with the issue number. A thing about Github though is that it seems to be lagging in updating when you are looking at the file's commit message. But the main commit message seems to be updated.
        Hide
        James Henestofel added a comment -

        Marina,
        Github finally updated correctly. The commit message shows correctly with the issue number at the beginning.

        Show
        James Henestofel added a comment - Marina, Github finally updated correctly. The commit message shows correctly with the issue number at the beginning.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        James Henestofel added a comment -

        Rebased

        Show
        James Henestofel added a comment - Rebased
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (24, 25 & master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (24, 25 & master), thanks!
        Hide
        Frédéric Massart added a comment -

        Passing, thanks.

        Show
        Frédéric Massart added a comment - Passing, thanks.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Yes, it's happening (somewhere in the French Polynesia, right now). And you did it, raising Moodle to new excellency levels.

        Or, if you prefer, yes, you fixed that boring issue.

        Thanks anyway! Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Yes, it's happening (somewhere in the French Polynesia, right now). And you did it, raising Moodle to new excellency levels. Or, if you prefer, yes, you fixed that boring issue. Thanks anyway! Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: