Moodle
  1. Moodle
  2. MDL-42069

Quiz: provide student lastname sort option in grading report (manual grading)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.6, 2.5.2, 2.6
    • Fix Version/s: 2.4.7, 2.5.3
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      In course suitable for testing:

      Create a quiz activity with an essay question.

      Login to the course using at least two different accounts with 'student' roles (gradable roles), and submit quiz attempts as each. Make sure the students' names are such that they will display in different order when changing sort order from first to last name, e.g. Zachary Adams, Michael Murphy.

      Login to the course with an instructor or admin role. Select the test, and in the Administration block, select Quiz administration->Results->Manual grading. In the resulting display, click the 'grade' or 'grade all' link.

      The manual grading report is displayed. In the 'Options' section, select different values for the 'Order attempts' drop-down list and verify the display list is appropriate for the selection made.

      Show
      In course suitable for testing: Create a quiz activity with an essay question. Login to the course using at least two different accounts with 'student' roles (gradable roles), and submit quiz attempts as each. Make sure the students' names are such that they will display in different order when changing sort order from first to last name, e.g. Zachary Adams, Michael Murphy. Login to the course with an instructor or admin role. Select the test, and in the Administration block, select Quiz administration->Results->Manual grading. In the resulting display, click the 'grade' or 'grade all' link. The manual grading report is displayed. In the 'Options' section, select different values for the 'Order attempts' drop-down list and verify the display list is appropriate for the selection made.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull 2.4 Branch:
    • Pull 2.5 Branch:
    • Pull Master Branch:
    • Rank:
      53266

      Description

      Provide student lastname sort option in grading report (manual grading) giving instructors an option to enter grades in same order as they may have been organized elsewhere.

      One possible code change (3 files) is referenced below in the Pull 2.5 Diff Url.

        Activity

        Hide
        Tim Hunt added a comment -

        The patch looks great until the very end.

        1. $DB->sql_fullname('u.lastname', 'u.firstname') is just meaningless. This should be

        $orderby = 'u.lastname, u.firstname'

        and similarly for the other case in the if.

        2. The commented out default: clause confused me at first. I think you should not comment you 'default :', and rather than having commented out $orderby = "idnumber"; you should just have a comment that explains what is going on.

        3. Moodle coding style says no space before the :.

        4. The commit comment is nearly the right style, but the fist line is too long. See http://docs.moodle.org/dev/Commit_cheat_sheet.

        5. Since this is a new feature / improvement, really it should me master branch only, but it is such a good simple change, we can do it on all branches. Really you should make versions of the commit for each branch, but if you can't we can cherry-pick.

        Thanks for working on this. With just a bit of polishing it will be ready for integrations.

        Show
        Tim Hunt added a comment - The patch looks great until the very end. 1. $DB->sql_fullname('u.lastname', 'u.firstname') is just meaningless. This should be $orderby = 'u.lastname, u.firstname' and similarly for the other case in the if. 2. The commented out default: clause confused me at first. I think you should not comment you 'default :', and rather than having commented out $orderby = "idnumber"; you should just have a comment that explains what is going on. 3. Moodle coding style says no space before the :. 4. The commit comment is nearly the right style, but the fist line is too long. See http://docs.moodle.org/dev/Commit_cheat_sheet . 5. Since this is a new feature / improvement, really it should me master branch only, but it is such a good simple change, we can do it on all branches. Really you should make versions of the commit for each branch, but if you can't we can cherry-pick. Thanks for working on this. With just a bit of polishing it will be ready for integrations.
        Hide
        Tim Hunt added a comment -

        Oh, final point:

        6. Before this can be integrated, we need some testing instructions. Would you like to have a go at writing some?

        Show
        Tim Hunt added a comment - Oh, final point: 6. Before this can be integrated, we need some testing instructions. Would you like to have a go at writing some?
        Hide
        Fred Woolard added a comment -

        Tim, Thanks for the review. I can make the suggested changes and set up appropriate branches for each of the stable releases + master. Also, I'd be happy to make an attempt at testing instructions.

        Show
        Fred Woolard added a comment - Tim, Thanks for the review. I can make the suggested changes and set up appropriate branches for each of the stable releases + master. Also, I'd be happy to make an attempt at testing instructions.
        Hide
        Fred Woolard added a comment -

        Have revised changes per suggestion. Update references for pull branches/diff urls. Have done preliminary testing on each of the branches using testing instructions. There is a branch available for MOODLE_22_STABLE also if desired.

        Show
        Fred Woolard added a comment - Have revised changes per suggestion. Update references for pull branches/diff urls. Have done preliminary testing on each of the branches using testing instructions. There is a branch available for MOODLE_22_STABLE also if desired.
        Hide
        Tim Hunt added a comment -

        Great. Submitting for integration.

        Show
        Tim Hunt added a comment - Great. Submitting for integration.
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Fred Woolard added a comment -

        Rebased branches.

        Show
        Fred Woolard added a comment - Rebased branches.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (24, 25 & master), thanks!

        (23 is not supported since some months ago)

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (24, 25 & master), thanks! (23 is not supported since some months ago)
        Hide
        Frédéric Massart added a comment -

        Passing, thanks.

        Show
        Frédéric Massart added a comment - Passing, thanks.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Yes, it's happening (somewhere in the French Polynesia, right now). And you did it, raising Moodle to new excellency levels.

        Or, if you prefer, yes, you fixed that boring issue.

        Thanks anyway! Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Yes, it's happening (somewhere in the French Polynesia, right now). And you did it, raising Moodle to new excellency levels. Or, if you prefer, yes, you fixed that boring issue. Thanks anyway! Ciao
        Hide
        Mary Cooch added a comment -

        Removing docs_required (somewhat belatedly) as this is now documented on the http://docs.moodle.org/en/Quiz_manual_grading_report and for 2.5 also.

        Show
        Mary Cooch added a comment - Removing docs_required (somewhat belatedly) as this is now documented on the http://docs.moodle.org/en/Quiz_manual_grading_report and for 2.5 also.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: