Moodle
  1. Moodle
  2. MDL-4207

Don't overwrite modified user profile values with empty LDAP values when 'unlocked if empty' is set

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.8.6, 1.9.2
    • Component/s: Authentication
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_16_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE
    • Rank:
      37006

      Description

      I understand that if user profile values are locked to LDAP, then LDAP should provide those values.

      But in my mind the purpose of the setting unlocked if empty is to allow the user to fill in a value for the selected field if LDAP is giving nothing for this field. Thus it would make sense to let this value stand in until LDAP is giving a value for this field.

        Activity

        Hide
        Martin Dougiamas added a comment -

        From Samuli Karevaara (samuli.karevaara at lamk.fi) Thursday, 5 January 2006, 09:41 PM:

        Added a patch I'm using to fill this feature request.

        Show
        Martin Dougiamas added a comment - From Samuli Karevaara (samuli.karevaara at lamk.fi) Thursday, 5 January 2006, 09:41 PM: Added a patch I'm using to fill this feature request.
        Hide
        Samuli Karevaara added a comment -

        The patch was lost in the old tracker, so I'm attaching it again. This is old, for 1.6...

        Show
        Samuli Karevaara added a comment - The patch was lost in the old tracker, so I'm attaching it again. This is old, for 1.6...
        Hide
        Iñaki Arenaza added a comment -

        Samuli,

        I fully agree with you, so I'm goint to assign the bug to myself and fix it in 1.8, 1.9 and HEAD using your patch.

        Saludos. Iñaki.

        Show
        Iñaki Arenaza added a comment - Samuli, I fully agree with you, so I'm goint to assign the bug to myself and fix it in 1.8, 1.9 and HEAD using your patch. Saludos. Iñaki.
        Hide
        Iñaki Arenaza added a comment -

        Patch applied in 1.8, 1.9 and HEAD.

        Samuli, thanks a lot for your patch!

        Saludos. Iñaki.

        Show
        Iñaki Arenaza added a comment - Patch applied in 1.8, 1.9 and HEAD. Samuli, thanks a lot for your patch! Saludos. Iñaki.
        Hide
        Samuli Karevaara added a comment -

        Thanks, Iñaki!

        Show
        Samuli Karevaara added a comment - Thanks, Iñaki!
        Hide
        Petr Škoda added a comment -

        thanks

        Show
        Petr Škoda added a comment - thanks

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: