Moodle
  1. Moodle
  2. MDL-42078

Uninstalling multiple plugins usability and bugfixes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Installation, Usability
    • Labels:
    • Testing Instructions:
      Hide

      1/ run unit tests
      2/ install via web and CLI installer
      3/ try upgrade from 2.2 and upgrade from 2.5
      4/ use add-on installer
      5/ somehow try updater (no idea how to make it work in master branch)
      6/ test uninstallation of all plugin types via overview page - it should return there
      7/ test uninstall via all custom plugin type management pages
      8/ go through all plugin settings pages and verify management pages work

      note: the core_component changes require version bump, workaround is to purge cache dir or visit admin/index.php

      Show
      1/ run unit tests 2/ install via web and CLI installer 3/ try upgrade from 2.2 and upgrade from 2.5 4/ use add-on installer 5/ somehow try updater (no idea how to make it work in master branch) 6/ test uninstallation of all plugin types via overview page - it should return there 7/ test uninstall via all custom plugin type management pages 8/ go through all plugin settings pages and verify management pages work note: the core_component changes require version bump, workaround is to purge cache dir or visit admin/index.php
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w41_MDL-42078_m26_uninstallcleanup
    • Story Points:
      40
    • Rank:
      53275
    • Sprint:
      BACKEND Sprint 6

      Description

      Suddenly some of my dev sites have started to show a lot of "missing from disk" plugins, mainly innocent ones (no DB...). That was integrated last week if I'm not wrong.

      What I'm finding annoying is that, if I click the "uninstall" button to get rid of any of them.... after confirmation and deletion... I'm redirected to admin/index.php, where the missing plugins are also show BUT WITHOUT uninstall option. So I've to go again to admin/plugins.php and continue with the next one.

      Just guessing if it would be possible any of this:

      • Add the uninstall option to admin/index.php, or
      • After uninstall, get redirected to the page that ignited the uninstall (admin/plugins.php).

      Ciao

        Issue Links

          Activity

          Hide
          Petr Škoda added a comment - - edited

          Hmmm, we could probably use SESSION to redirect back to plugins overview or management page

          Show
          Petr Škoda added a comment - - edited Hmmm, we could probably use SESSION to redirect back to plugins overview or management page
          Hide
          Petr Škoda added a comment -

          Oh, I noticed some breakage in question related management, it is not yet using the new plugin uninstall features, but it should at least work now. I have also completely reworked the assign subplugin uninstall...

          Show
          Petr Škoda added a comment - Oh, I noticed some breakage in question related management, it is not yet using the new plugin uninstall features, but it should at least work now. I have also completely reworked the assign subplugin uninstall...
          Hide
          Petr Škoda added a comment - - edited

          Hi, Eloy! This got a bit bigger than I expected, but hopefully it should be working fine now.

          There is only one potential problem, I did not know what dom element id to set on the plugin type headings on the plugin overview page - I wanted it to scroll to the proper place after uninstall. I used "/admin/plugins.php#plugin_type_cell_xxxxx" for now...

          Show
          Petr Škoda added a comment - - edited Hi, Eloy! This got a bit bigger than I expected, but hopefully it should be working fine now. There is only one potential problem, I did not know what dom element id to set on the plugin type headings on the plugin overview page - I wanted it to scroll to the proper place after uninstall. I used "/admin/plugins.php#plugin_type_cell_xxxxx" for now...
          Hide
          Petr Škoda added a comment -

          Adding Tim and Damyon - any objections?

          Show
          Petr Škoda added a comment - Adding Tim and Damyon - any objections?
          Hide
          Petr Škoda added a comment -

          reopening, I am working on much bigger refactoring and more improvements related to core_component, plugin_manager and updater...

          Show
          Petr Škoda added a comment - reopening, I am working on much bigger refactoring and more improvements related to core_component, plugin_manager and updater...
          Hide
          Petr Škoda added a comment -

          submitting this little mammoth for peer review...

          Show
          Petr Škoda added a comment - submitting this little mammoth for peer review...
          Hide
          Damyon Wiese added a comment -

          The assign changes look good to me - the only issue is that there will be a conflict with MDL-41131.

          Show
          Damyon Wiese added a comment - The assign changes look good to me - the only issue is that there will be a conflict with MDL-41131 .
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Looks mammothtly correct, so sending it to integration.

          Show
          Eloy Lafuente (stronk7) added a comment - Looks mammothtly correct, so sending it to integration.
          Hide
          Tim Hunt added a comment -

          I had a quick look, and it looks good to me:

          • It is another step forwards in our quest to make all add-on types more similar in common areas.
          • In the quiz/question area, we don't seem to have lost any of the custom behaviour, but it is not impelemtned in a better organised way.

          Thanks Petr.

          For a change of this size, I would have preferred more detailed testing instructions. For example explicitly verfiying that all the behaviour of admin/qtypes.php still works correctly, and the same for all other plugin types.

          Show
          Tim Hunt added a comment - I had a quick look, and it looks good to me: It is another step forwards in our quest to make all add-on types more similar in common areas. In the quiz/question area, we don't seem to have lost any of the custom behaviour, but it is not impelemtned in a better organised way. Thanks Petr. For a change of this size, I would have preferred more detailed testing instructions. For example explicitly verfiying that all the behaviour of admin/qtypes.php still works correctly, and the same for all other plugin types.
          Hide
          Petr Škoda added a comment -

          Right, I forgot to update the instructions, I am still testing if everything works as before or better. Thanks!

          Show
          Petr Škoda added a comment - Right, I forgot to update the instructions, I am still testing if everything works as before or better. Thanks!
          Hide
          Sam Hemelryk added a comment -

          Thanks Petr - I couldn't spot anything wrong with this and it has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Petr - I couldn't spot anything wrong with this and it has been integrated now
          Hide
          Adrian Greeve added a comment -

          Ran through the testing instruction.
          Test passed.

          Show
          Adrian Greeve added a comment - Ran through the testing instruction. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Yes, it's happening (somewhere in the French Polynesia, right now). And you did it, raising Moodle to new excellency levels.

          Or, if you prefer, yes, you fixed that boring issue.

          Thanks anyway! Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Yes, it's happening (somewhere in the French Polynesia, right now). And you did it, raising Moodle to new excellency levels. Or, if you prefer, yes, you fixed that boring issue. Thanks anyway! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile