Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42104

Trap focus for open modal (backport of MDL-35926)

    XMLWordPrintable

Details

    • MOODLE_24_STABLE, MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • Hide
      1. Login as a student
      2. Navigate to a course
      3. Click the assignment
      4. Click add submissions
      5. Click the Add... button in the file picker
      • Tab through the page and make sure it only select the elements within the modal.

      Additional Test (optional):

      • Repeat the above steps with screenreader on and make sure the screen reader only read elements within the modal.

      Notes: This patch only affects the forward tab direct, shift tab will still get out of the loop. It also only affects a limited set of windows - which are just the ones from filepicker/filemanager (e.g. file properties, create folder, unzip etc).

      Show
      Login as a student Navigate to a course Click the assignment Click add submissions Click the Add... button in the file picker Tab through the page and make sure it only select the elements within the modal. Additional Test (optional): Repeat the above steps with screenreader on and make sure the screen reader only read elements within the modal. Notes: This patch only affects the forward tab direct, shift tab will still get out of the loop. It also only affects a limited set of windows - which are just the ones from filepicker/filemanager (e.g. file properties, create folder, unzip etc).
    • FRONTEND Sprint 8

    Description

      Issue
      Context change - When the user activates Add.. modal, the focus is not being put in the modal window but is being sent back to the top of the page. Screen reader and keyboard users now have to make their way back to the modal window, only to find out it's impossible to get back in it (and therefore, close it).

      Standard Level
      WCAG 2 3.2.2 (A) http://www.w3.org/WAI/WCAG20/quickref/#qr-minimize-error-cues

      Impact
      Critical

      Example Link
      http://demo.moodle.net/mod/assign/view.php?id=1778&action=editsubmission

      Test Steps

      1. Login as a student
      2. Navigate to a course
      3. Click the assignment
      4. Click add submissions
      5. Click the Add... button in the file picker with a screen reader one
      6. Notice the screen reader starts reading at the top of the page.

      Attachments

        Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43827 Its not possible to download, delete, unzip or set file as main using the keyboard/screenreader

          • Major - Major loss of function, incorrect output
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43778 Fix trap focus modal in Mac

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35926 Add.. modal allows tab focus to go outside the modal

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Activity

            People

              rwijaya Rossiani Wijaya
              rwijaya Rossiani Wijaya
              Andrew Lyons Andrew Lyons
              Damyon Wiese Damyon Wiese
              Dan Poltawski Dan Poltawski
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Barbara Ramiro, Bas Brands, Mathew May, David Woloszyn, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/Mar/14