Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42117

Drag and drop upload of resources breaks AJAX actions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Course, JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      As usual with JS issues, this needs to be tested in a variety of browsers, with JS consoles open.

      • Open a course
      • Turn editing on
      • Drag + drop a couple of new files in place
        • Confirm that the actionmenu is added correctly
        • Confirm that the actionmenu opens as anticipated
        • Confirm that you can toggle the show/hide without the page reloading
        • Confirm that the group mode toggle works without the page reloading
        • Confirm that the left and right indents work without the page reloading
      • Ensure that the activity is not hidden
      • Toggle hide on the section
        • Confirm that the section hides
        • Confirm that the activity is changed to be hidden too
      • Unhide the section
        • Confirm that the section unhides
        • Confirm that the activity is changed to be visible too
      • Hide the activity again
        • Confirm that the activity is now hidden
      • Toggle hide on the section
        • Confirm that the section hides
        • Confirm that the activity remains hidden
      • Unhide the section
        • Confirm that the section unhides
        • Confirm that the activity remains hidden
      • Drag/drop the activity into a different (unhidden) section
        • Confirm that the activity remains hidden
      • Unhide the activity
        • Confirm that the activity becomes visible
      • Drag it back into a hidden section
        • Confirm that the activity becomes hidden
      • Delete the activity
        • Confirm that it is deleted without the page reloading
      Show
      As usual with JS issues, this needs to be tested in a variety of browsers, with JS consoles open. Open a course Turn editing on Drag + drop a couple of new files in place Confirm that the actionmenu is added correctly Confirm that the actionmenu opens as anticipated Confirm that you can toggle the show/hide without the page reloading Confirm that the group mode toggle works without the page reloading Confirm that the left and right indents work without the page reloading Ensure that the activity is not hidden Toggle hide on the section Confirm that the section hides Confirm that the activity is changed to be hidden too Unhide the section Confirm that the section unhides Confirm that the activity is changed to be visible too Hide the activity again Confirm that the activity is now hidden Toggle hide on the section Confirm that the section hides Confirm that the activity remains hidden Unhide the section Confirm that the section unhides Confirm that the activity remains hidden Drag/drop the activity into a different (unhidden) section Confirm that the activity remains hidden Unhide the activity Confirm that the activity becomes visible Drag it back into a hidden section Confirm that the activity becomes hidden Delete the activity Confirm that it is deleted without the page reloading
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-42117-master
    • Story Points:
      13
    • Sprint:
      FRONTEND Sprint 6

      Description

      1. In a course, as a teacher with editing on..
      2. Drag and drop (file drag and drop) an image into a section and choose 'create a file resource'
      3. Change the visibility to hidden
      4. Attempt to do things with the resource just uploaded such as hide, move etc.

      Expected results:
      All actions work as normal.

      Actual result:
      The ajax breaks on those resources, the hidden icon isn't working and you can't move the resources.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dobedobedoh Andrew Nicols
                Reporter:
                poltawski Dan Poltawski
                Peer reviewer:
                Damyon Wiese
                Integrator:
                Dan Poltawski
                Tester:
                Dan Poltawski
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Jake Dallimore, Jun Pataleta, Ryan Wyllie
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/13