Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42131

Edit PDF missing require_login on some pages.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      Use the editpdf plugin (submit a pdf file as a student with annotate pdf enabled, then login as a teacher and add some annotations/comments, save the grade, then view the generated pdf).
      Go to the admin settings for Annotate PDF feedback plugin and use the test ghostscript path link. Verify that you get a smiley.

      Testing note: If this breaks anything, it will be that the editpdf dialogue will fail to load due to ajax errors, or the admin testgs page will show errors.

      Show
      Use the editpdf plugin (submit a pdf file as a student with annotate pdf enabled, then login as a teacher and add some annotations/comments, save the grade, then view the generated pdf). Go to the admin settings for Annotate PDF feedback plugin and use the test ghostscript path link. Verify that you get a smiley. Testing note: If this breaks anything, it will be that the editpdf dialogue will fail to load due to ajax errors, or the admin testgs page will show errors.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-42131-master
    • Story Points:
      1
    • Sprint:
      FRONTEND Sprint 5

      Description

      ajax.php and testgs.php are missing require_login

      Also suggested by Petr:
      Use require - not require_once for config.php
      and
      thirdpartylibs.xml should be in the plugin - not in /lib

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Jérôme Mouneyrac
              Integrator:
              Dan Poltawski
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13