Loading...

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_26_STABLE
Epic Link:
Add Upload PDF to core
Pull from Repository:
git://github.com/damyon/moodle.git
Pull Main Branch:
~~MDL-42131~~-master
Pull Main Diff URL:
https://github.com/damyon/moodle/compare/c92182597783495ebc75c5442ba8496dcded9904...MDL-42131-master
Testing Instructions:

Hide

Use the editpdf plugin (submit a pdf file as a student with annotate pdf enabled, then login as a teacher and add some annotations/comments, save the grade, then view the generated pdf).
Go to the admin settings for Annotate PDF feedback plugin and use the test ghostscript path link. Verify that you get a smiley.

Testing note: If this breaks anything, it will be that the editpdf dialogue will fail to load due to ajax errors, or the admin testgs page will show errors.

Show
Use the editpdf plugin (submit a pdf file as a student with annotate pdf enabled, then login as a teacher and add some annotations/comments, save the grade, then view the generated pdf). Go to the admin settings for Annotate PDF feedback plugin and use the test ghostscript path link. Verify that you get a smiley. Testing note: If this breaks anything, it will be that the editpdf dialogue will fail to load due to ajax errors, or the admin testgs page will show errors.

ajax.php and testgs.php are missing require_login

Also suggested by Petr:
Use require - not require_once for config.php
and
thirdpartylibs.xml should be in the plugin - not in /lib

is blocked by

MDL-42150 Edit PDF Ajax error saving pages.

Testing discovered

MDL-42023 Edit PDF: Integrate editpdf plugin for mod_assign

Participants:: Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Jérôme Mouneyrac, Mark Nelson