Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42131

Edit PDF missing require_login on some pages.

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.6
    • 2.6
    • Assignment
    • MOODLE_26_STABLE
    • MOODLE_26_STABLE
    • MDL-42131-master
    • Hide

      Use the editpdf plugin (submit a pdf file as a student with annotate pdf enabled, then login as a teacher and add some annotations/comments, save the grade, then view the generated pdf).
      Go to the admin settings for Annotate PDF feedback plugin and use the test ghostscript path link. Verify that you get a smiley.

      Testing note: If this breaks anything, it will be that the editpdf dialogue will fail to load due to ajax errors, or the admin testgs page will show errors.

      Show
      Use the editpdf plugin (submit a pdf file as a student with annotate pdf enabled, then login as a teacher and add some annotations/comments, save the grade, then view the generated pdf). Go to the admin settings for Annotate PDF feedback plugin and use the test ghostscript path link. Verify that you get a smiley. Testing note: If this breaks anything, it will be that the editpdf dialogue will fail to load due to ajax errors, or the admin testgs page will show errors.
    • 1
    • FRONTEND Sprint 5

    Description

      ajax.php and testgs.php are missing require_login

      Also suggested by Petr:
      Use require - not require_once for config.php
      and
      thirdpartylibs.xml should be in the plugin - not in /lib

      Attachments

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42150 Edit PDF Ajax error saving pages.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-42023 Edit PDF: Integrate editpdf plugin for mod_assign

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              damyon Damyon Wiese
              damyon Damyon Wiese
              Jérôme Mouneyrac Jérôme Mouneyrac
              Dan Poltawski Dan Poltawski
              Mark Nelson Mark Nelson
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/13