Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42151

The test plan templates does not include the version nor commit of the moodle codebase that generated it

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.2
    • Fix Version/s: 2.5.3
    • Component/s: Performance
    • Labels:
    • Testing Instructions:
      Hide
      1. Run admin/tool/generator/cli/maketestplan.php
      2. Download and open the provided .jmx file (you can see it in the CLI output)
      3. You SHOULD see a moodleversion XML structure, where the Argument.value property value matches the $version specified in /moodle/dirroot/version.php (you can search moodleversion and will appear)
      Show
      Run admin/tool/generator/cli/maketestplan.php Download and open the provided .jmx file (you can see it in the CLI output) You SHOULD see a moodleversion XML structure, where the Argument.value property value matches the $version specified in /moodle/dirroot/version.php (you can search moodleversion and will appear)
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-42151_master

      Description

      (Related with https://github.com/moodlehq/moodle-performance-comparison)

      The generator tool will change over time and results generated after those changes should not be compared with previous results as the "base" is not the same, we will maintain a list of those versions (weekly release version or commit hash) in the default config file (webserver_config.properties - https://github.com/moodlehq/moodle-performance-comparison/blob/master/webserver_config.properties.dist#L38) A new user var placeholder in the templated filled with the version or hash of the codebase would solve it.

      I'll add a patch here and ask for feedback as the alternative would be to manage it from https://github.com/moodlehq/moodle-performance-comparison, I would rather prefer here because when the jmeter server and the web server are in different servers to get the $basecommit hash would be more complicated.

        Attachments

          Activity

            People

            Assignee:
            dmonllao David Monllaó
            Reporter:
            dmonllao David Monllaó
            Peer reviewer:
            Petr Skoda
            Integrator:
            Dan Poltawski
            Tester:
            Mark Nelson
            Participants:
            Component watchers:
            Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Nov/13