Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42166

Finalise deprecation of repository sync methods

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.7.3, 2.8.1
    • 2.9
    • Files API, Repositories
    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • MOODLE_29_STABLE
    • MDL-42166-master
    • Hide
      1. Check that behat and php unit passed on the nightly server (If there are errors relating to repositories, this issue may likely be the cause) http://nightly.test.in.moodle.com:8080/view/Master/
      2. Go to Home ► My profile ► My private files
      3. Use a core repository plugin (e.g. wikimedia) to add an image to my private files
      4. Ensure that the file is successfully added, and has a filesize
      5. Use a repository plugin from the plugins DB to add an image to my private files
      6. Create a "page" activity module on a course.
      7. Insert an image from a core repository plugin
      8. Ensure it is inserted with no errors and displays correctly
      9. Insert an image from a repository plugin from the plugins DB
      10. Ensure it is inserted with no errors and displays correctly
      Show
      Check that behat and php unit passed on the nightly server (If there are errors relating to repositories, this issue may likely be the cause) http://nightly.test.in.moodle.com:8080/view/Master/ Go to Home ► My profile ► My private files Use a core repository plugin (e.g. wikimedia) to add an image to my private files Ensure that the file is successfully added, and has a filesize Use a repository plugin from the plugins DB to add an image to my private files Create a "page" activity module on a course. Insert an image from a core repository plugin Ensure it is inserted with no errors and displays correctly Insert an image from a repository plugin from the plugins DB Ensure it is inserted with no errors and displays correctly
    • BACKEND Sprint 19
    • Medium

    Description

      In MDL-42016 the repositories API for synchronising external references was simplified.

      Remove completely:
      stored_file::set_filesize()
      stored_file::replace_content_with()
      repository::reset_caches()
      repository::sync_external_file()

      In repository::__call() remove code related to functions:
      sync_individual_file()
      get_file_by_reference()
      get_reference_file_lifetime()

      probably there will be nothing left in __call() at all so it can be deleted.

      In repository::sync_reference() remove all code starting from comment "Backward compatibility (Moodle 2.3-2.5)". Replace it with "return false;"

      Attachments

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42016 Simplify repository API to sync files

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              johno John Okely
              marina Marina Glancy
              Ankit Agarwal Ankit Agarwal
              Dan Poltawski Dan Poltawski
              Dan Poltawski Dan Poltawski
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/May/15