Loading...

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE
Fixed Branches:
MOODLE_26_STABLE
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull Main Branch:
~~MDL-42173~~-master
Pull Main Diff URL:
https://github.com/ankitagarwal/moodle/compare/83a3e35...MDL-42173-master
Testing Instructions:
Hide

Enable max debug in moodle config.

Enable email based Self registration.

Set the registration settings to use email based self registration

Try registering for an account. Make sure no errors/warnings/notices are produced during the process.

Fill the registration form again and leave the firstname field empty and fill the rest properly and submit. Make sure you get a validation error saying "Missing given name". Try the same with "lastname".
Show
Enable max debug in moodle config. Enable email based Self registration. Set the registration settings to use email based self registration Try registering for an account. Make sure no errors/warnings/notices are produced during the process. Fill the registration form again and leave the firstname field empty and fill the rest properly and submit. Make sure you get a validation error saying "Missing given name". Try the same with "lastname".

While investigating ~~MDL-42138~~, I noticed that registration page is generating notices as below:-

You need to update your sql to include additional name fields in the user object.

line 3601 of /lib/moodlelib.php: call to debugging()

line 65 of /login/signup_form.php: call to fullname()

line 191 of /lib/formslib.php: call to login_signup_form->definition()

line 312 of /lib/authlib.php: call to moodleform->moodleform()

line 50 of /login/signup.php: call to auth_plugin_base->signup_form()

is blocked by

MDL-42177 Removing $a->firstname or $a->lastname from the fullnamedisplay string results in errors.

Testing discovered

MDL-42138 Required custom profile fields, are not required with Guest status

Participants:: Adrian Greeve, Andrew Davis, Ankit Agarwal, Dan Poltawski, Eloy Lafuente (stronk7), Marina Glancy