Moodle
  1. Moodle
  2. MDL-42188

Delete some old yui/build/xxx leftovers from core

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.2, 2.6
    • Fix Version/s: 2.5.3
    • Component/s: AJAX and JavaScript
    • Labels:
      None

      Description

      Whenever any "src" file (css, image, js…) is renamed/deleted from a yui module, their corresponding "build" counterparts need to be deleted too.

      Since some hours ago we are detecting such "orphaned" (not used anymore) files with the Ci servers and they are reporting some (master and also 25_STABLE):

      http://integration.moodle.org/job/06.%20Run%20shifter%20for%20all%20modules%20(master)/1043/console

      calendar/yui/build/moodle-calendar-eventmanager/assets/skins/sam/eventmanager.css
      theme/bootstrapbase/yui/build/moodle-theme_bootstrap-bootstrap/moodle-theme_bootstrap-bootstrap-debug.js
      theme/bootstrapbase/yui/build/moodle-theme_bootstrap-bootstrap/moodle-theme_bootstrap-bootstrap-min.js
      theme/bootstrapbase/yui/build/moodle-theme_bootstrap-bootstrap/moodle-theme_bootstrap-bootstrap.js
      

      This is, simply about to get rid of them from core. If anything else stops working because of these deletion, then the yui module is, for sure, missing something into its "src" contents.

      Ciao

        Gliffy Diagrams

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          Sending straight to integration. It has been verified to be the solution and the team agrees, plus we need CI jobs passing ASAP, so go to paint another bikeshed, dear, lol.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Sending straight to integration. It has been verified to be the solution and the team agrees, plus we need CI jobs passing ASAP, so go to paint another bikeshed, dear, lol. Ciao
          Hide
          Sam Hemelryk added a comment -

          Sorry for the noise

          Show
          Sam Hemelryk added a comment - Sorry for the noise
          Hide
          Sam Hemelryk added a comment -

          Thanks Eloy this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Eloy this has been integrated now.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Passing this in behalf of CI servers.

          Show
          Eloy Lafuente (stronk7) added a comment - Passing this in behalf of CI servers.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Yes, it's happening (somewhere in the French Polynesia, right now). And you did it, raising Moodle to new excellency levels.

          Or, if you prefer, yes, you fixed that boring issue.

          Thanks anyway! Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Yes, it's happening (somewhere in the French Polynesia, right now). And you did it, raising Moodle to new excellency levels. Or, if you prefer, yes, you fixed that boring issue. Thanks anyway! Ciao

            People

            • Assignee:
              Eloy Lafuente (stronk7)
              Reporter:
              Eloy Lafuente (stronk7)
              Integrator:
              Sam Hemelryk
              Tester:
              Eloy Lafuente (stronk7)
              Participants:
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: