Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42194

Underscores banned in string identifiers?

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.6
    • Fix Version/s: None
    • Component/s: Language
    • Labels:
      None
    • Affected Branches:
      MOODLE_26_STABLE

      Description

      Recently, many events added underscores in string identifiers, e.g.:

      mod/chat/lang/en/chat.php:$string['event_instances_list_viewed'] = 'Instances list viewed';
      mod/chat/lang/en/chat.php:$string['event_message_sent'] = 'Message sent';
      mod/chat/lang/en/chat.php:$string['event_sessions_viewed'] = 'Sessions viewed';
      mod/choice/lang/en/choice.php:$string['event_answer_created'] = 'Choice made';
      mod/choice/lang/en/choice.php:$string['event_answer_updated'] = 'Choice updated';
      mod/choice/lang/en/choice.php:$string['event_choice_viewed'] = 'Choice viewed';
      mod/choice/lang/en/choice.php:$string['event_report_viewed'] = 'Choice report viewed';
      

      There are different points of view on whether these underscore seperators should be allowed, this suggests no:
      http://docs.moodle.org/dev/Languages#HTML_help_files_replaced_with_ordinary_strings

      If banned - these strings should be fixed up.

      If not - we have it documented here.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: