Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42201

Creating a course and running the cron causes 'Error' to be displayed in backup report.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.6, 2.5
    • Fix Version/s: 2.4.7, 2.5.3
    • Component/s: Backup
    • Labels:
      None
    • Testing Instructions:
      Hide
      Test 1 - Master only
      1. Upgrade to the latest master and check that the backup_courses table lists the 'laststatus' field's default value as '5'.
      2. Do a fresh install of master and do the same.
      Test 2 - All versions
      1. Log in as an administrator and ensure you are using the standard theme.
      2. Create a new course.
      3. Visit <yoursite>/admin/settings.php?section=automated
      4. Set 'Active' to 'Enabled', select the current day for 'Schedule' and set the time to 10 minutes in the future. Note, the time selected here is in GMT, so do not set this assuming it is in the user timezone.
      5. Open another tab and visit <yoursite>/admin/cron.php.
      6. Open another tab and visit <yoursite>/report/backups/index.php and make sure the status next to your course is 'Waiting to create first backup' (the same colour as the 'OK' status), the text is green and the 'Next backup' is scheduled 10 minutes in the future.
      7. On 2.5 and master, change your theme to clean and check the colour remains green.
      8. Wait until you pass the time listed for when the backup occurs.
      9. Run the cron and then refresh the backup report page and ensure the status has been set to 'OK' for the new course.
      10. Run the cron again, refresh the backup report page and check that the status still says 'OK' for the new course.
      Show
      Test 1 - Master only Upgrade to the latest master and check that the backup_courses table lists the 'laststatus' field's default value as '5'. Do a fresh install of master and do the same. Test 2 - All versions Log in as an administrator and ensure you are using the standard theme. Create a new course. Visit <yoursite>/admin/settings.php?section=automated Set 'Active' to 'Enabled', select the current day for 'Schedule' and set the time to 10 minutes in the future. Note, the time selected here is in GMT, so do not set this assuming it is in the user timezone. Open another tab and visit <yoursite>/admin/cron.php. Open another tab and visit <yoursite>/report/backups/index.php and make sure the status next to your course is 'Waiting to create first backup' (the same colour as the 'OK' status), the text is green and the 'Next backup' is scheduled 10 minutes in the future. On 2.5 and master, change your theme to clean and check the colour remains green. Wait until you pass the time listed for when the backup occurs. Run the cron and then refresh the backup report page and ensure the status has been set to 'OK' for the new course. Run the cron again, refresh the backup report page and check that the status still says 'OK' for the new course.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-42201_master
    • Story Points:
      8
    • Sprint:
      BACKEND Sprint 6

      Description

      It was discussed with Eloy that we would do the fix for MDL-37181, with the knowledge of this issue, and fix this here.

      The solution is to create a new status for the backups when they are first created to something like 'Waiting for first backup', rather than setting the status to the default (Error).

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Nov/13