Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42210

Add label for text, textarea and select dropdown input elements in Feedback module

    Details

    • Testing Instructions:
      Hide

      As an administrator:

      1. Enable the feedback module going to the admin tree -> plugins -> activity modules -> Manage activities
      2. Go to a course and add a Feedback activity and then view the activity
      3. Add a "Short text answer" question.
      4. Add a "Longer text answer" question.
      5. Add a "Numeric answer" question.
      6. Add a "Multiple choice" question, selecting the "Multiple choice - single answer allowed (dropdownlist)" for the "Multiple choice type" option.
      7. Add a "Multiple choice (rated)" question, selecting the "Multiple choice (rated) - single answer allowed (dropdownlist)" for the "Multiple choice type" option.

      With Editing Mode ON

      Feedback Form Preview - Click on the field label for each of the fields. Notice that focus is given to the input field. View at the HTML code and notice that the input fields have "label for" tags associating them.

      With Editing Mode OFF

      While viewing the Feedback form, click on the field label for each of the fields. Notice that focus is given to the input field . View at the HTML code and notice that the input fields have "label for" tags associating them.

      In order to make Feedback forms WCAG 2.0 compliant, each input field must have a label associated with it.

      The checkbox and radio type input fields were tested and do not have this issue.

      Show
      As an administrator: Enable the feedback module going to the admin tree -> plugins -> activity modules -> Manage activities Go to a course and add a Feedback activity and then view the activity Add a "Short text answer" question. Add a "Longer text answer" question. Add a "Numeric answer" question. Add a "Multiple choice" question, selecting the "Multiple choice - single answer allowed (dropdownlist)" for the "Multiple choice type" option. Add a "Multiple choice (rated)" question, selecting the "Multiple choice (rated) - single answer allowed (dropdownlist)" for the "Multiple choice type" option. With Editing Mode ON Feedback Form Preview - Click on the field label for each of the fields. Notice that focus is given to the input field. View at the HTML code and notice that the input fields have "label for" tags associating them. With Editing Mode OFF While viewing the Feedback form, click on the field label for each of the fields. Notice that focus is given to the input field . View at the HTML code and notice that the input fields have "label for" tags associating them. In order to make Feedback forms WCAG 2.0 compliant, each input field must have a label associated with it. The checkbox and radio type input fields were tested and do not have this issue.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-42210_master

      Description

      There are several input fields that do not have labels explicitly tied to them:

      • Numeric | numeric
      • Shorter Text field | textfield
      • Longer Text field | textarea
      • Multiple Choice - single answer allowed (dropdownlist) | multichoice
      • Multiple Choice (rated) - single answer allowed (dropdownlist) | multichoicerated

      The first three were missing the "label for" tags completely.

      The multichoice and multichoicerated were only missing a label when using the dropdownlist format as the other formats appear to have been addressed by MDL-34564.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Nov/13