Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42223

Deprecate $CFG->cachejs in favour of reusing $CFG->debug

    XMLWordPrintable

Details

    • MOODLE_26_STABLE
    • MDL-42223-master
    • Hide
      • open browser tools -> network tab
      • ensure that debug developer is not set
      • purge caches
      • refresh any page in moodle
      • open the JS console and run

        M.cfg.jsrev
        

        • confirm that the jsrev matches the int in the URL from the previous step
      • browser around Moodle a bit
        • confirm everything is all hunky dory
      • increase debug level to debug_developer
      • refresh the page again
        • confirm that the int in the URL is now -1
        • confirm that the int in M.cfg.jsrev is also -1
      Show
      open browser tools -> network tab ensure that debug developer is not set purge caches refresh any page in moodle *confirm that the calls to theme/yui_combo.php include a timestamp (ignoring the YUI version ones). For example http://banana.local/moodle/sm/theme/yui_combo.php?m/1381393757/core/popuphelp/popuphelp-min.js* open the JS console and run M.cfg.jsrev confirm that the jsrev matches the int in the URL from the previous step browser around Moodle a bit confirm everything is all hunky dory increase debug level to debug_developer refresh the page again confirm that the int in the URL is now -1 confirm that the int in M.cfg.jsrev is also -1
    • 13
    • FRONTEND Sprint 6

    Description

      As a result of MDL-41985, this has been suggested to reduce the number of options relating to JS. We currently have:

      • $CFG->cachejs
      • $CFG->jsrev
      • $CFG->debug

      The proposal is to:

      • remove $CFG->cachejs; and
      • when $CFG->debug == DEBUG_DEVELOPER:
        • set $CFG->jsrev = -1

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Petr Skoda Petr Skoda
              Damyon Wiese Damyon Wiese
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: