Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42234

Notice undefined variable when disabling all repositories

    Details

    • Testing Instructions:
      Hide
      1. Disable all of the repositories
      2. [Test] When all of the repositories have been disabled, ensure that there are no notices.
      3. Enable previously selected repositories.
      4. [Test] Make sure that you still don't see any notices.
      Show
      Disable all of the repositories [Test] When all of the repositories have been disabled, ensure that there are no notices. Enable previously selected repositories. [Test] Make sure that you still don't see any notices.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-42234-master
    • Sprint:
      BACKEND Sprint 6
    • Sprint:
      BACKEND Sprint 6

      Description

      When you disable all of the repositories you get the following notice:

      Notice: Undefined variable: alreadyplugins in /home/adrian/moodles/stable_master_postgres/moodle/admin/repository.php on line 401 Warning: in_array() expects parameter 2 to be array, null given in /home/adrian/moodles/stable_master_postgres/moodle/admin/repository.php on line 401 
      

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks Adrian,

            Patch looks spot-on. Pushing for integration.
            [y] Syntax
            [y] Whitespace
            [y] Output
            [-] Language
            [-] Databases
            [y] Testing (instructions and automated tests)
            [-] Security
            [-] Documentation
            [y] Git
            [y] Sanity check

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks Adrian, Patch looks spot-on. Pushing for integration. [y] Syntax [y] Whitespace [y] Output [-] Language [-] Databases [y] Testing (instructions and automated tests) [-] Security [-] Documentation [y] Git [y] Sanity check
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            abgreeve Adrian Greeve added a comment -

            Rebased.

            Show
            abgreeve Adrian Greeve added a comment - Rebased.
            Hide
            marina Marina Glancy added a comment -

            Thanks Adrian for working on it.

            Can we better instead move the line #300

            $alreadyplugins = array();

            in front of if() block. It will make the code easier to read and will prevent from other bugs like that when new code is added.
            Thanks again.

            Show
            marina Marina Glancy added a comment - Thanks Adrian for working on it. Can we better instead move the line #300 $alreadyplugins = array(); in front of if() block. It will make the code easier to read and will prevent from other bugs like that when new code is added. Thanks again.
            Hide
            abgreeve Adrian Greeve added a comment -

            Thanks Marina,

            I've re-worked the fix as you have suggested.

            It should be ready to go.

            Show
            abgreeve Adrian Greeve added a comment - Thanks Marina, I've re-worked the fix as you have suggested. It should be ready to go.
            Hide
            marina Marina Glancy added a comment -

            Thanks Adrian, this has been integrated in 2.4, 2.5 and master

            Show
            marina Marina Glancy added a comment - Thanks Adrian, this has been integrated in 2.4, 2.5 and master
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Works as described

            Show
            dobedobedoh Andrew Nicols added a comment - Works as described
            Hide
            poltawski Dan Poltawski added a comment -

            Hurrah! Thanks for your contribution - this fix is part of Moodle.

            Show
            poltawski Dan Poltawski added a comment - Hurrah! Thanks for your contribution - this fix is part of Moodle.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Nov/13