Moodle
  1. Moodle
  2. MDL-42234

Notice undefined variable when disabling all repositories

    Details

    • Rank:
      53480
    • Sprint:
      BACKEND Sprint 6

      Description

      When you disable all of the repositories you get the following notice:

      Notice: Undefined variable: alreadyplugins in /home/adrian/moodles/stable_master_postgres/moodle/admin/repository.php on line 401 Warning: in_array() expects parameter 2 to be array, null given in /home/adrian/moodles/stable_master_postgres/moodle/admin/repository.php on line 401 
      

        Activity

        Hide
        Rajesh Taneja added a comment -

        Thanks Adrian,

        Patch looks spot-on. Pushing for integration.
        [y] Syntax
        [y] Whitespace
        [y] Output
        [-] Language
        [-] Databases
        [y] Testing (instructions and automated tests)
        [-] Security
        [-] Documentation
        [y] Git
        [y] Sanity check

        Show
        Rajesh Taneja added a comment - Thanks Adrian, Patch looks spot-on. Pushing for integration. [y] Syntax [y] Whitespace [y] Output [-] Language [-] Databases [y] Testing (instructions and automated tests) [-] Security [-] Documentation [y] Git [y] Sanity check
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Adrian Greeve added a comment -

        Rebased.

        Show
        Adrian Greeve added a comment - Rebased.
        Hide
        Marina Glancy added a comment -

        Thanks Adrian for working on it.

        Can we better instead move the line #300

        $alreadyplugins = array();
        

        in front of if() block. It will make the code easier to read and will prevent from other bugs like that when new code is added.
        Thanks again.

        Show
        Marina Glancy added a comment - Thanks Adrian for working on it. Can we better instead move the line #300 $alreadyplugins = array(); in front of if() block. It will make the code easier to read and will prevent from other bugs like that when new code is added. Thanks again.
        Hide
        Adrian Greeve added a comment -

        Thanks Marina,

        I've re-worked the fix as you have suggested.

        It should be ready to go.

        Show
        Adrian Greeve added a comment - Thanks Marina, I've re-worked the fix as you have suggested. It should be ready to go.
        Hide
        Marina Glancy added a comment -

        Thanks Adrian, this has been integrated in 2.4, 2.5 and master

        Show
        Marina Glancy added a comment - Thanks Adrian, this has been integrated in 2.4, 2.5 and master
        Hide
        Andrew Nicols added a comment -

        Works as described

        Show
        Andrew Nicols added a comment - Works as described
        Hide
        Dan Poltawski added a comment -

        Hurrah! Thanks for your contribution - this fix is part of Moodle.

        Show
        Dan Poltawski added a comment - Hurrah! Thanks for your contribution - this fix is part of Moodle.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile