Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42239

Calendar tooltips have bad aria-controls values

    Details

    • Testing Instructions:
      Hide
      1. Log in as admin.
      2. Create a few events for upcoming days in future.
      3. Load up a page which has calendar mini block.
      4. Straight after page load inspect page source code and make sure the <a> tag displaying the date elements doesn't have any "aria-controlls" attribute. Check this for date with no events, current date, and a future date with events.
      5. Mouse over current date, make sure <a> tag for the date now has a "Aria-controls" attribute pointing to the panel div.
      6. Mouse over any date without any events, make sure the td tag for the date does not have any "Aria-controls" attribute associated.
      7. Mouse over any other date with events, make sure <a> tag for the date now has a "aria-controls" attribute pointing to the panel div.
      8. Install chrome extension https://chrome.google.com/webstore/detail/accessibility-developer-t/fpkknkljclfencbdbgkenhalefipecmb and run the tool on a freshly loaded page and make sure the test "ARIA state and property values must be valid" passes.

      PS:- There are some rendering issues with the mouseover panel, those are not related to this fix.

      Show
      Log in as admin. Create a few events for upcoming days in future. Load up a page which has calendar mini block. Straight after page load inspect page source code and make sure the <a> tag displaying the date elements doesn't have any "aria-controlls" attribute. Check this for date with no events, current date, and a future date with events. Mouse over current date, make sure <a> tag for the date now has a "Aria-controls" attribute pointing to the panel div. Mouse over any date without any events, make sure the td tag for the date does not have any "Aria-controls" attribute associated. Mouse over any other date with events, make sure <a> tag for the date now has a "aria-controls" attribute pointing to the panel div. Install chrome extension https://chrome.google.com/webstore/detail/accessibility-developer-t/fpkknkljclfencbdbgkenhalefipecmb and run the tool on a freshly loaded page and make sure the test "ARIA state and property values must be valid" passes. PS:- There are some rendering issues with the mouseover panel, those are not related to this fix.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-42239-master
    • Story Points (Obsolete):
      5
    • Sprint:
      BACKEND Sprint 6

      Description

      On a course with the calendar block added and some events added, the aria-controls value points to a non-existant ID.

      The chrome accessibility audit points out the severe nature of this.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Nov/13