Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42265

make Browse Users list scrollable for smaller screens

    Details

    • Testing Instructions:
      Hide

      Navigate to Site Administration > Accounts > Browse list of users.

      Drag your browser window to be narrow enough that the last column isn't visible. Without the patch, the final column(s) become inaccessible.
      With the patch, a scroll bar should appear at the bottom of the table, allowing you to scroll horizontally.

      Show
      Navigate to Site Administration > Accounts > Browse list of users. Drag your browser window to be narrow enough that the last column isn't visible. Without the patch, the final column(s) become inaccessible. With the patch, a scroll bar should appear at the bottom of the table, allowing you to scroll horizontally.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-42265-browse_users_scroll

      Description

      On lower resolution screens, it's handy if the Browse Users list can scroll similar to Gradebook. The following adjustment has been tested as working:

      In admin/user.php, change:
      echo html_writer::table($table);

      to:

      echo html_writer::start_tag('div', array('class'=>'no-overflow'));
      echo html_writer::table($table);
      echo html_writer::end_tag('div');

        Gliffy Diagrams

          Attachments

          1. 24-standard.png
            24-standard.png
            50 kB
          2. 25-clean.png
            25-clean.png
            35 kB
          3. 25-standard.png
            25-standard.png
            41 kB
          4. integration-clean.png
            integration-clean.png
            34 kB
          5. integration-standard.png
            integration-standard.png
            48 kB

            Activity

            Hide
            phalacee Jason Fowler added a comment -

            Hi Ray, thanks for the patch.

            Can we please get the other fields filled in for the github repository - it makes the integrators life easier - and could this be backported to 2.5 at least please?
            The commit message doesn't include the component that was changed either.

            Other than that, it looks good.

            Show
            phalacee Jason Fowler added a comment - Hi Ray, thanks for the patch. Can we please get the other fields filled in for the github repository - it makes the integrators life easier - and could this be backported to 2.5 at least please? The commit message doesn't include the component that was changed either. Other than that, it looks good.
            Hide
            raymor Ray Morris added a comment -

            As requested, I've filled in additional fields and added it to my 2.5 branch.
            Because the commit hash is based on the commit message and changing it would require rewriting history,
            I did not change the message for the master branch.

            Show
            raymor Ray Morris added a comment - As requested, I've filled in additional fields and added it to my 2.5 branch. Because the commit hash is based on the commit message and changing it would require rewriting history, I did not change the message for the master branch.
            Hide
            phalacee Jason Fowler added a comment -

            Hi Ray,

            Thanks you changing that. There is no problem with changing the history prior to it getting to integration, but I'll push this through now.

            Show
            phalacee Jason Fowler added a comment - Hi Ray, Thanks you changing that. There is no problem with changing the history prior to it getting to integration, but I'll push this through now.
            Hide
            damyon Damyon Wiese added a comment -

            Thanks Ray,

            This fix looks good (and safe).

            I cherry-picked this to 24, 25 and master.

            Show
            damyon Damyon Wiese added a comment - Thanks Ray, This fix looks good (and safe). I cherry-picked this to 24, 25 and master.
            Hide
            barbararamiro Barbara Ramiro added a comment - - edited

            Last step on the testing instruction says... With the patch, a scroll bar should appear at the bottom of the table, allowing you to scroll horizontally.

            I can only see the horizontal scroll on clean theme but not on standard. Is this expected only on clean theme?

            version Standard Clean
            integration
            2.5
            2.4 -
            Show
            barbararamiro Barbara Ramiro added a comment - - edited Last step on the testing instruction says... With the patch, a scroll bar should appear at the bottom of the table , allowing you to scroll horizontally. I can only see the horizontal scroll on clean theme but not on standard. Is this expected only on clean theme? version Standard Clean integration 2.5 2.4 -
            Hide
            barbararamiro Barbara Ramiro added a comment -

            Passing this.

            Quoting Damyon... "looking at it - on standard - a scroll bar is not needed, because it the last column is never not visible (the entire page becomes scrollable)"

            Show
            barbararamiro Barbara Ramiro added a comment - Passing this. Quoting Damyon... "looking at it - on standard - a scroll bar is not needed, because it the last column is never not visible (the entire page becomes scrollable)"
            Hide
            raymor Ray Morris added a comment -

            Checking it in many of the included themes, it appears that on about half the new scrollbar is not needed and therefore does not appear. With the other half, it's needed and appears.

            Show
            raymor Ray Morris added a comment - Checking it in many of the included themes, it appears that on about half the new scrollbar is not needed and therefore does not appear. With the other half, it's needed and appears.
            Hide
            barbararamiro Barbara Ramiro added a comment -

            Thanks for the info Ray (" ,)

            Show
            barbararamiro Barbara Ramiro added a comment - Thanks for the info Ray (" ,)
            Hide
            damyon Damyon Wiese added a comment -

            Here lies 52 bugs.
            All fixed or swept under a rug.
            If they come back one day,
            To our dismay,
            We all will feel quite un-smug.

            Thanks for the reporting/fixing/testing on this issue. It has been sent upstream.

            Show
            damyon Damyon Wiese added a comment - Here lies 52 bugs. All fixed or swept under a rug. If they come back one day, To our dismay, We all will feel quite un-smug. Thanks for the reporting/fixing/testing on this issue. It has been sent upstream.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Nov/13