Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.5.2, 2.6
-
Component/s: Administration, Themes, Usability
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_25_STABLE, MOODLE_26_STABLE
-
Fixed Branches:MOODLE_24_STABLE, MOODLE_25_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-42265-browse_users_scroll -
Pull Master Diff URL:
Description
On lower resolution screens, it's handy if the Browse Users list can scroll similar to Gradebook. The following adjustment has been tested as working:
In admin/user.php, change:
echo html_writer::table($table);
to:
echo html_writer::start_tag('div', array('class'=>'no-overflow'));
echo html_writer::table($table);
echo html_writer::end_tag('div');
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
As requested, I've filled in additional fields and added it to my 2.5 branch.
Because the commit hash is based on the commit message and changing it would require rewriting history,
I did not change the message for the master branch.
Hi Ray,
Thanks you changing that. There is no problem with changing the history prior to it getting to integration, but I'll push this through now.
Thanks Ray,
This fix looks good (and safe).
I cherry-picked this to 24, 25 and master.
Last step on the testing instruction says... With the patch, a scroll bar should appear at the bottom of the table, allowing you to scroll horizontally.
I can only see the horizontal scroll on clean theme but not on standard. Is this expected only on clean theme?
| version | Standard | Clean |
|---|---|---|
| integration |  |
 |
| 2.5 |  |
 |
| 2.4 |  |
- |
Passing this.
Quoting Damyon... "looking at it - on standard - a scroll bar is not needed, because it the last column is never not visible (the entire page becomes scrollable)"
Checking it in many of the included themes, it appears that on about half the new scrollbar is not needed and therefore does not appear. With the other half, it's needed and appears.
Thanks for the info Ray (" ,)
Here lies 52 bugs.
All fixed or swept under a rug.
If they come back one day,
To our dismay,
We all will feel quite un-smug.
Thanks for the reporting/fixing/testing on this issue. It has been sent upstream.
Hi Ray, thanks for the patch.
Can we please get the other fields filled in for the github repository - it makes the integrators life easier - and could this be backported to 2.5 at least please?
The commit message doesn't include the component that was changed either.
Other than that, it looks good.