Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42317

TinyMCE editor can overlap with Blocks on New Event Page in Calendar in Clean Theme

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      In Moodle 2.6 stable

      1. Set your screen resolution to WXGA+ (1440 x 900 - equivalent to a standard 19" monitor).
      2. Log in as an admin
      3. Browse to the home page and click on the calendar month in the calendar block
      4. Proceed to the add event form
      5. Check that you see blocks on both sides and that the labels for form fields are above the elements.
      6. Increase your screensize to FHD
      7. Check that you see the form labels next to the elements now.

      In master

      1. Run `git revert 566889a`
      2. Repeat the 26 testing steps above.

      In master only (its an improvement really)
      Hint to check the pagelayout look for a body class "pagelayout-*" where * is the layout being used.

      1. Log in as an admin.
      2. Browse to a course, select restore from settings, select a backup file and restore, check the next page has a pagelayout of admin.
      3. Browse to a course, select badges > Add a new badge from settings, create a new badge, select to edit the badge you just created, check the pagelayout is course.
      4. Browse to a course with completion, add the completion status block, log in as a student and browse to the course, click the "details" link in the completion status block, check the next page has layout report (because it is a report).
      5. Add an RSS feed bloack, click edit settings in the block, Add a feed http://rss.slashdot.org/Slashdot/slashdot, Edit the feed and check that page layout is "admin"
      6. In the settings block browse to My profile settings > Blogs > Preferences and check the next page has the "admin" page layout.
      7. Browse to the front page, click the month in the calendar block, click to add an event, check the next page has the "admin" layout.
      8. Browse back to the calendar month, click the "Manage subscriptions" button down the bottom on the next page check the layout is "admin"
      9. Browse back to the course with completion, select "Course completion" in the settings block and check the next page uses the "admin" layout (same layout as the edit course page).
      10. Browse to a course and then select Course administration > Users > groups in the settings block.
        • Click create group and check the next page uses "admin" layout. Click back in your browser.
        • Click "Auto-create groups" and check the next page uses "admin" layout. Click back in your browser.
        • Click "Import groups" and check the next page uses "admin" layout. Click back in your browser.
        • Click the groupings tab, click create grouping and check the next page uses "admin" layout.
      11. Enable at least one portfolio, add a topic to site news on the front page, browse back to the front page, select "export to portfolio" on the site news article and check the next page uses "admin" layout.
      12. Turn on enablemobilewebservice, browse to My Profile settings > Security keys and check the page is using the "admin" layout.
      13. Browse to My profile settings > Portfolios > Configure and check the page is using the "admin" layout.
      14. Browse to My profile settings > Portfolios > Transfer logs and check the page is using the "report" layout.
      Show
      In Moodle 2.6 stable Set your screen resolution to WXGA+ (1440 x 900 - equivalent to a standard 19" monitor). Log in as an admin Browse to the home page and click on the calendar month in the calendar block Proceed to the add event form Check that you see blocks on both sides and that the labels for form fields are above the elements. Increase your screensize to FHD Check that you see the form labels next to the elements now. In master Run `git revert 566889a` Repeat the 26 testing steps above. In master only (its an improvement really) Hint to check the pagelayout look for a body class "pagelayout-*" where * is the layout being used. Log in as an admin. Browse to a course, select restore from settings, select a backup file and restore, check the next page has a pagelayout of admin. Browse to a course, select badges > Add a new badge from settings, create a new badge, select to edit the badge you just created, check the pagelayout is course. Browse to a course with completion, add the completion status block, log in as a student and browse to the course, click the "details" link in the completion status block, check the next page has layout report (because it is a report). Add an RSS feed bloack, click edit settings in the block, Add a feed http://rss.slashdot.org/Slashdot/slashdot , Edit the feed and check that page layout is "admin" In the settings block browse to My profile settings > Blogs > Preferences and check the next page has the "admin" page layout. Browse to the front page, click the month in the calendar block, click to add an event, check the next page has the "admin" layout. Browse back to the calendar month, click the "Manage subscriptions" button down the bottom on the next page check the layout is "admin" Browse back to the course with completion, select "Course completion" in the settings block and check the next page uses the "admin" layout (same layout as the edit course page). Browse to a course and then select Course administration > Users > groups in the settings block. Click create group and check the next page uses "admin" layout. Click back in your browser. Click "Auto-create groups" and check the next page uses "admin" layout. Click back in your browser. Click "Import groups" and check the next page uses "admin" layout. Click back in your browser. Click the groupings tab, click create grouping and check the next page uses "admin" layout. Enable at least one portfolio, add a topic to site news on the front page, browse back to the front page, select "export to portfolio" on the site news article and check the next page uses "admin" layout. Turn on enablemobilewebservice, browse to My Profile settings > Security keys and check the page is using the "admin" layout. Browse to My profile settings > Portfolios > Configure and check the page is using the "admin" layout. Browse to My profile settings > Portfolios > Transfer logs and check the page is using the "report" layout.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      42317-27
    • Pull Master Diff URL:
    • Story Points:
      20
    • Sprint:
      FRONTEND Sprint 10

      Description

      See attached screenshot.

      I thought this was a bug in Essential at first. TinyMCE is over too far to the right and usually overlaps with the blocks on the right. This can be avoided with a really wide browser window in Clean but not in Essential.

        Attachments

        1. ForumPostScreenshot.png
          ForumPostScreenshot.png
          37 kB
        2. RTL.png
          RTL.png
          6 kB
        3. sshot26.png
          sshot26.png
          146 kB
        4. tinymce block overlap in calendar.PNG
          tinymce block overlap in calendar.PNG
          80 kB

          Issue Links

            Activity

              People

              Assignee:
              samhemelryk Sam Hemelryk
              Reporter:
              worfds91 Joshua Bragg
              Peer reviewer:
              Andrew Davis
              Integrator:
              Dan Poltawski
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Bas Brands
              Votes:
              3 Vote for this issue
              Watchers:
              13 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14