Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-42245 META: Follow up issues with new course management interface
  3. MDL-42318

Incorrect reordering in new category management interface

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Administration, Course
    • Labels:
    • Testing Instructions:
      Hide

      Prerequisite:

      1. Create role 'blindmanager' which is a copy of manager but without capabilities to view hidden courses and categories
      2. Create users:
        • User1 has 'manager' role
        • User2 has 'blindmanager' role
      3. Create categories as admin or User1
        • Cat1. Visible
        • Cat2. Hidden
        • Cat3. Visible.
        • Create sub categories under Cat3 - Subcat4 (visible) and Subcat5 (visible)
        • Create courses in Cat1: C1(visible), C2 (hidden) and C3 (visible)
        • Create courses in Cat3: C4(visible), C5 (visible) and C6 (visible)

      Test 1:

      1. Login as user2
      2. Make sure you don't get to see up/down icons to resort Cat1, Cat3.
      3. When you attempt to resort a set of categories that includes hidden categories (ie when All categories is selected), there should be no change after the sort.
      4. Make sure yo see up/down to resort for subcat4 and subcat5

      Test 2:

      1. As User2, select Cat1
      2. Make sure you don't see move icons for courses and you should see C1 and C3 only. (Also you can't/can resort courses by name)
      3. Select Cat3 and make sure move icons are visible and you can see all 3 courses (C4, C5 and C6)
      4. Make sure number of courses in the category list and in the bottom of courses list is correct (does not include invisible courses)

      Test 3:

      1. As User1 you should always see move icons for course and categories. Also, you should see all courses and categories (hidden or visible)
      Show
      Prerequisite: Create role 'blindmanager' which is a copy of manager but without capabilities to view hidden courses and categories Create users: User1 has 'manager' role User2 has 'blindmanager' role Create categories as admin or User1 Cat1. Visible Cat2. Hidden Cat3. Visible. Create sub categories under Cat3 - Subcat4 (visible) and Subcat5 (visible) Create courses in Cat1: C1(visible), C2 (hidden) and C3 (visible) Create courses in Cat3: C4(visible), C5 (visible) and C6 (visible) Test 1: Login as user2 Make sure you don't get to see up/down icons to resort Cat1, Cat3. When you attempt to resort a set of categories that includes hidden categories (ie when All categories is selected), there should be no change after the sort. Make sure yo see up/down to resort for subcat4 and subcat5 Test 2: As User2, select Cat1 Make sure you don't see move icons for courses and you should see C1 and C3 only. (Also you can't/can resort courses by name) Select Cat3 and make sure move icons are visible and you can see all 3 courses (C4, C5 and C6) Make sure number of courses in the category list and in the bottom of courses list is correct (does not include invisible courses) Test 3: As User1 you should always see move icons for course and categories. Also, you should see all courses and categories (hidden or visible)
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      wip-MDL-42318-master

      Description

      Preparation.
      Create uses with two different roles.
      User1 have moodle/category:manage, moodle/category:viewhiddencategories, moodle/course:viewhiddencourses/.
      User2 have moodle/category:manage and do not have moodle/category:viewhiddencategories, moodle/course:viewhiddencourses/.

      Create categories with first user
      Cat1. Visible
      Cat2. Hidden
      Cat3. Visible.

      Problem.
      Manage categories them with user2. You'll see only Cat1 and Cat3. Move Cat3 up. You'll see that Cat3 is over Cat1. But if you reload page, you'll see that Cat3 is under Cat1. That's because actual ordering ic Cat1, Cat3, Cat2 now (check with user1).
      Same for courses reordering (if moving with arrows).

      This may be very confusing if having many hidden categories.

      In course listing for user2, you'll see "Showing all 3 courses", when he see only 2 courses.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              vadimon Vadim Dvorovenko
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              Damyon Wiese
              Tester:
              Michael de Raadt
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13